All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx]  ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: extract engine WA programming to common resume function
Date: Thu, 30 Jan 2020 15:58:13 +0200	[thread overview]
Message-ID: <20200130135813.GB13686@intel.com> (raw)
In-Reply-To: <158039146921.16598.16786857738481185551@skylake-alporthouse-com>

On Thu, Jan 30, 2020 at 01:37:49PM +0000, Chris Wilson wrote:
> Quoting Patchwork (2020-01-30 06:49:28)
> > #### Possible regressions ####
> > 
> >   * igt@i915_selftest@live_active:
> >     - fi-bwr-2160:        [PASS][1] -> [DMESG-WARN][2] +12 similar issues
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7840/fi-bwr-2160/igt@i915_selftest@live_active.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16327/fi-bwr-2160/igt@i915_selftest@live_active.html
> 
> Well it works on Crestline. Broadwater snafu?

Does the w/a thing actually work correctly for masked registers?
It look to use rmw even for masked registers and IIRC some masked
registers return 0xffff for the mask when read. I lost track of the
values and masks being passed around before I got down that deep so
can't immediatly see if the code is guaranteed to set only the
expected mask bit(s) for the write.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-01-30 13:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 23:58 [Intel-gfx] [PATCH 1/2] drm/i915: extract engine WA programming to common resume function Daniele Ceraolo Spurio
2020-01-29 23:59 ` [Intel-gfx] [PATCH 2/2] drm/i915: Move ringbuffer WAs to engine workaround list Daniele Ceraolo Spurio
2020-01-30  0:16   ` Chris Wilson
2020-01-30  0:08 ` [Intel-gfx] [PATCH 1/2] drm/i915: extract engine WA programming to common resume function Chris Wilson
2020-01-30  6:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2020-01-30 13:37   ` Chris Wilson
2020-01-30 13:58     ` Ville Syrjälä [this message]
2020-01-30 14:08       ` Chris Wilson
2020-01-30 19:20         ` Daniele Ceraolo Spurio
2020-01-30 19:26           ` Ville Syrjälä
2020-01-30 18:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: extract engine WA programming to common resume function (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200130135813.GB13686@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.