From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v4 6/6] console: Drop misleading comment
Date: Thu, 30 Jan 2020 17:25:58 +0200 [thread overview]
Message-ID: <20200130152558.51839-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200130152558.51839-1-andriy.shevchenko@linux.intel.com>
/* find the last or real console */
This comment is misleading. The purpose of the loop is to check
if we are trying to register boot console when one had been
registered before.
Suggested-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v4: new patch
kernel/printk/printk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 0117d4d92a8e..e5388c8a88c6 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2661,7 +2661,6 @@ void register_console(struct console *newcon)
* already have a valid console
*/
if (newcon->flags & CON_BOOT) {
- /* find the last or real console */
for_each_console(bcon) {
if (!(bcon->flags & CON_BOOT)) {
pr_info("Too late to register bootconsole %s%d\n",
--
2.24.1
prev parent reply other threads:[~2020-01-30 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 15:25 [PATCH v4 1/6] console: Don't perform test for CON_BRL flag Andy Shevchenko
2020-01-30 15:25 ` [PATCH v4 2/6] console: Drop double check for console_drivers being non-NULL Andy Shevchenko
2020-01-30 15:25 ` [PATCH v4 3/6] console: Use for_each_console() helper in unregister_console() Andy Shevchenko
2020-01-30 15:25 ` [PATCH v4 4/6] console: Avoid positive return code from unregister_console() Andy Shevchenko
2020-01-30 15:25 ` [PATCH v4 5/6] console: Introduce ->exit() callback Andy Shevchenko
2020-01-31 1:31 ` Sergey Senozhatsky
2020-01-31 11:27 ` Andy Shevchenko
2020-02-01 1:08 ` Sergey Senozhatsky
2020-02-03 13:34 ` Andy Shevchenko
2020-01-30 15:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130152558.51839-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.