From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] git: Make submodule check only needed modules
Date: Thu, 30 Jan 2020 16:46:18 +0000 [thread overview]
Message-ID: <20200130164618.GS1891831@redhat.com> (raw)
In-Reply-To: <87pnf0c2r8.fsf@secure.laptop>
On Thu, Jan 30, 2020 at 05:44:59PM +0100, Juan Quintela wrote:
> Daniel P. Berrangé <berrange@redhat.com> wrote:
> > On Thu, Jan 30, 2020 at 05:28:10PM +0100, Juan Quintela wrote:
> >> If one is compiling more than one tree from the same source, it is
> >> possible that they need different submodules. Change the check to see
> >> that all modules that we are interested in are updated, discarding the
> >> ones that we don't care about.
> >>
> >> Signed-off-by: Juan Quintela <quintela@redhat.com>
> >>
> >
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Should I send the pull request?
Sure, I'm was leaving this for the "Misc queue" maintainer but if yuou
want it sooner....
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-01-30 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 16:28 [PATCH v2] git: Make submodule check only needed modules Juan Quintela
2020-01-30 16:31 ` Daniel P. Berrangé
2020-01-30 16:44 ` Juan Quintela
2020-01-30 16:46 ` Daniel P. Berrangé [this message]
2020-01-30 17:02 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130164618.GS1891831@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.