From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1838AC2D0DB for ; Thu, 30 Jan 2020 17:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5F6C20707 for ; Thu, 30 Jan 2020 17:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580404768; bh=P16QSKE8ku4fF+SjmfmNSNgJGXbxNh+qk4h1QxfDtRg=; h=In-Reply-To:References:Subject:To:From:Cc:Date:List-ID:From; b=rNPK6oopYAXxJHCEpnpTLlePi6NgH6eyDRhWm/pWGsbIe5MvCua3olr2c9Y37RdVY fe/ATJcX3XT8tEGZUeFHV5IrP1+TTAF7Ppd9NdvxTxr44f/Nnz6+BoQ8TtiN1PVq2Y UMV5KiTk4bMkWqTBSRD8W18VcQ/PVDumSDwNqy3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbgA3RT2 (ORCPT ); Thu, 30 Jan 2020 12:19:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:50170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbgA3RT2 (ORCPT ); Thu, 30 Jan 2020 12:19:28 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9ECF206F0; Thu, 30 Jan 2020 17:19:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580404767; bh=P16QSKE8ku4fF+SjmfmNSNgJGXbxNh+qk4h1QxfDtRg=; h=In-Reply-To:References:Subject:To:From:Cc:Date:From; b=XspM3mAH2XZiehQ/9QxiSTvZzS36uR/CHiXvMz9GgglifpeVLNqLLri/kfx3L0KuK pEQCgVVbzlmWi2rfB0omxlId9lF8fqnZwSj14LtiPA4wcPXo2POdX4g3LlFKdK4jJy PYuUAdOsHeu487wns6oqVRfnKSTACILGOnkywm/8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200129163821.1547295-1-heiko@sntech.de> References: <20200129163821.1547295-1-heiko@sntech.de> Subject: Re: [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout To: Heiko Stuebner , linux-clk@vger.kernel.org From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, heiko@sntech.de, christoph.muellner@theobroma-systems.com, zhangqing@rock-chips.com, robin.murphy@arm.com, Heiko Stuebner User-Agent: alot/0.8.1 Date: Thu, 30 Jan 2020 09:19:26 -0800 Message-Id: <20200130171927.C9ECF206F0@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Heiko Stuebner (2020-01-29 08:38:19) > From: Heiko Stuebner >=20 > Instead of open coding the polling of the lock status, use the > handy readl_poll_timeout for this. As the pll locking is normally > blazingly fast and we don't want to incur additional delays, we're > not doing any sleeps similar to for example the imx clk-pllv4 > and define a very safe but still short timeout of 1ms. >=20 > Suggested-by: Stephen Boyd > Signed-off-by: Heiko Stuebner > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout Date: Thu, 30 Jan 2020 09:19:26 -0800 Message-ID: <20200130171927.C9ECF206F0@mail.kernel.org> References: <20200129163821.1547295-1-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20200129163821.1547295-1-heiko@sntech.de> Sender: linux-clk-owner@vger.kernel.org To: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, heiko@sntech.de, christoph.muellner@theobroma-systems.com, zhangqing@rock-chips.com, robin.murphy@arm.com, Heiko Stuebner List-Id: linux-rockchip.vger.kernel.org Quoting Heiko Stuebner (2020-01-29 08:38:19) > From: Heiko Stuebner >=20 > Instead of open coding the polling of the lock status, use the > handy readl_poll_timeout for this. As the pll locking is normally > blazingly fast and we don't want to incur additional delays, we're > not doing any sleeps similar to for example the imx clk-pllv4 > and define a very safe but still short timeout of 1ms. >=20 > Suggested-by: Stephen Boyd > Signed-off-by: Heiko Stuebner > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8798C3F68F for ; Thu, 30 Jan 2020 17:19:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EF462083E for ; Thu, 30 Jan 2020 17:19:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sbS+5OHz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XspM3mAH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EF462083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:To:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3c2F9Ur5o8rJBe2dsdVxAb5/YpD4IXOQMoNfpqBKg3w=; b=sbS+5OHzjb8qh7 lgDKECmuEPklgSF/b9k3vyn8VqZhd7L5grAep5nSYi3Gq5I910wvkVDjZGOZrGSOz2N8gKOHP0H+p Vh7Ek8wDuTbm1Zi+IUVe8E0FiK6S2y4++s35RcLYAfuCNSFOPVpXAfsJCBhBs4TKSna9JCgr4dSye Jk/Hc+avJtHpWtHz0hDEFw2J1UAbslKMX33FpyBFunLInZtmo+F5M5cRj6SKrPKcBaUmCl0S+N14I aviXhEPYiRo9J5I4arbcsPJYsFyCOFJHulf0BhQj1x+j8HJo6psNrH8kay7hFNHT30W6tE20VPlNv js7MVRVJ6GaXELR08lLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixDTW-0006av-Uy; Thu, 30 Jan 2020 17:19:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixDTU-0006a7-OW; Thu, 30 Jan 2020 17:19:29 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9ECF206F0; Thu, 30 Jan 2020 17:19:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580404767; bh=P16QSKE8ku4fF+SjmfmNSNgJGXbxNh+qk4h1QxfDtRg=; h=In-Reply-To:References:Subject:To:From:Cc:Date:From; b=XspM3mAH2XZiehQ/9QxiSTvZzS36uR/CHiXvMz9GgglifpeVLNqLLri/kfx3L0KuK pEQCgVVbzlmWi2rfB0omxlId9lF8fqnZwSj14LtiPA4wcPXo2POdX4g3LlFKdK4jJy PYuUAdOsHeu487wns6oqVRfnKSTACILGOnkywm/8= MIME-Version: 1.0 In-Reply-To: <20200129163821.1547295-1-heiko@sntech.de> References: <20200129163821.1547295-1-heiko@sntech.de> Subject: Re: [PATCH v3 1/3] clk: rockchip: convert rk3399 pll type to use readl_poll_timeout To: Heiko Stuebner , linux-clk@vger.kernel.org From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 30 Jan 2020 09:19:26 -0800 Message-Id: <20200130171927.C9ECF206F0@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200130_091928_816886_C0BE460D X-CRM114-Status: UNSURE ( 7.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, Heiko Stuebner , mturquette@baylibre.com, zhangqing@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, christoph.muellner@theobroma-systems.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Heiko Stuebner (2020-01-29 08:38:19) > From: Heiko Stuebner > > Instead of open coding the polling of the lock status, use the > handy readl_poll_timeout for this. As the pll locking is normally > blazingly fast and we don't want to incur additional delays, we're > not doing any sleeps similar to for example the imx clk-pllv4 > and define a very safe but still short timeout of 1ms. > > Suggested-by: Stephen Boyd > Signed-off-by: Heiko Stuebner > --- Reviewed-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel