From: Richard Cochran <richardcochran@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 1/2] net: mdio: of: fix potential NULL pointer derefernce
Date: Thu, 30 Jan 2020 21:17:34 -0800 [thread overview]
Message-ID: <20200131051734.GA1398@localhost> (raw)
In-Reply-To: <20200130174451.17951-1-michael@walle.cc>
On Thu, Jan 30, 2020 at 06:44:50PM +0100, Michael Walle wrote:
> of_find_mii_timestamper() returns NULL if no timestamper is found.
> Therefore, guard the unregister_mii_timestamper() calls.
>
> Fixes: 1dca22b18421 ("net: mdio: of: Register discovered MII time stampers.")
> Signed-off-by: Michael Walle <michael@walle.cc>
Good catch.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2020-01-31 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 17:44 [PATCH net-next 1/2] net: mdio: of: fix potential NULL pointer derefernce Michael Walle
2020-01-30 17:44 ` [PATCH net-next 2/2] net: mii_timestamper: fix static allocation by PHY driver Michael Walle
2020-01-31 5:18 ` Richard Cochran
2020-01-31 5:17 ` Richard Cochran [this message]
2020-01-31 15:49 ` [PATCH net-next 1/2] net: mdio: of: fix potential NULL pointer derefernce Jakub Kicinski
2020-02-02 20:13 ` Michael Walle
2020-02-02 20:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131051734.GA1398@localhost \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.