From: <sjpark@amazon.com>
To: <edumazet@google.com>, <davem@davemloft.net>
Cc: <shuah@kernel.org>, <netdev@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sj38.park@gmail.com>, <aams@amazon.com>,
SeongJae Park <sjpark@amazon.de>
Subject: [PATCH 1/3] net/ipv4/inet_timewait_sock: Fix inconsistent comments
Date: Fri, 31 Jan 2020 13:24:19 +0100 [thread overview]
Message-ID: <20200131122421.23286-2-sjpark@amazon.com> (raw)
In-Reply-To: <20200131122421.23286-1-sjpark@amazon.com>
From: SeongJae Park <sjpark@amazon.de>
Commit ec94c2696f0b ("tcp/dccp: avoid one atomic operation for timewait
hashdance") mistakenly erased a comment for the second step of
`inet_twsk_hashdance()`. This commit restores it for better
readability.
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
net/ipv4/inet_timewait_sock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c
index c411c87ae865..fbfcd63cc170 100644
--- a/net/ipv4/inet_timewait_sock.c
+++ b/net/ipv4/inet_timewait_sock.c
@@ -120,6 +120,7 @@ void inet_twsk_hashdance(struct inet_timewait_sock *tw, struct sock *sk,
spin_lock(lock);
+ /* Step 2: Hash TW into tcp ehash chain. */
inet_twsk_add_node_rcu(tw, &ehead->chain);
/* Step 3: Remove SK from hash chain */
--
2.17.1
next prev parent reply other threads:[~2020-01-31 12:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 12:24 [PATCH 0/3] Fix reconnection latency caused by FIN/ACK handling race sjpark
2020-01-31 12:24 ` sjpark [this message]
2020-01-31 14:54 ` [PATCH 1/3] net/ipv4/inet_timewait_sock: Fix inconsistent comments Eric Dumazet
2020-01-31 15:09 ` sjpark
2020-01-31 12:24 ` [PATCH 2/3] tcp: Reduce SYN resend delay if a suspicous ACK is received sjpark
2020-01-31 15:01 ` Eric Dumazet
2020-01-31 16:12 ` sjpark
2020-01-31 16:55 ` Eric Dumazet
2020-01-31 17:05 ` sjpark
2020-01-31 17:08 ` Eric Dumazet
2020-01-31 15:10 ` Neal Cardwell
2020-01-31 18:12 ` Eric Dumazet
2020-01-31 22:11 ` Neal Cardwell
2020-01-31 22:17 ` SeongJae Park
2020-02-01 3:55 ` Neal Cardwell
2020-02-01 6:08 ` SeongJae Park
2020-02-01 13:30 ` Neal Cardwell
2020-01-31 22:53 ` Eric Dumazet
2020-02-03 15:40 ` David Laight
2020-02-03 15:54 ` Eric Dumazet
2020-01-31 12:24 ` [PATCH 3/3] selftests: net: Add FIN_ACK processing order related latency spike test sjpark
2020-01-31 14:56 ` Eric Dumazet
2020-01-31 15:13 ` sjpark
2020-01-31 14:00 ` [PATCH 0/3] Fix reconnection latency caused by FIN/ACK handling race David Laight
2020-01-31 15:05 ` sjpark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131122421.23286-2-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=aams@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.