From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Fri, 31 Jan 2020 12:06:15 +0000 Subject: Re: [PATCH 1/5] KVM: Pass kvm_init()'s opaque param to additional arch funcs Message-Id: <20200131130615.3b21b28d.cohuck@redhat.com> List-Id: References: <20200130001023.24339-1-sean.j.christopherson@intel.com> <20200130001023.24339-2-sean.j.christopherson@intel.com> In-Reply-To: <20200130001023.24339-2-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org On Wed, 29 Jan 2020 16:10:19 -0800 Sean Christopherson wrote: > Pass @opaque to kvm_arch_hardware_setup() and > kvm_arch_check_processor_compat() to allow architecture specific code to > reference @opaque without having to stash it away in a temporary global > variable. This will enable x86 to separate its vendor specific callback > ops, which are passed via @opaque, into "init" and "runtime" ops without > having to stash away the "init" ops. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/mips/kvm/mips.c | 4 ++-- > arch/powerpc/kvm/powerpc.c | 4 ++-- > arch/s390/kvm/kvm-s390.c | 4 ++-- > arch/x86/kvm/x86.c | 4 ++-- > include/linux/kvm_host.h | 4 ++-- > virt/kvm/arm/arm.c | 4 ++-- > virt/kvm/kvm_main.c | 18 ++++++++++++++---- > 7 files changed, 26 insertions(+), 16 deletions(-) > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index eb3709d55139..5ad252defa54 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4345,14 +4345,22 @@ struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void) > return &kvm_running_vcpu; > } > > -static void check_processor_compat(void *rtn) > +struct kvm_cpu_compat_check { > + void *opaque; > + int *ret; > +}; > + > +static void check_processor_compat(void *data) > { > - *(int *)rtn = kvm_arch_check_processor_compat(); > + struct kvm_cpu_compat_check *c = data; > + > + *c->ret = kvm_arch_check_processor_compat(c->opaque); > } This function also looks better now :) Reviewed-by: Cornelia Huck Tested-by: Cornelia Huck #s390 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D90C35240 for ; Fri, 31 Jan 2020 12:06:43 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 71CFC20705 for ; Fri, 31 Jan 2020 12:06:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X5KHvz87" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71CFC20705 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C14164A4F7; Fri, 31 Jan 2020 07:06:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NK+wVzNUBX9H; Fri, 31 Jan 2020 07:06:41 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B81FA4A551; Fri, 31 Jan 2020 07:06:41 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8CD584A50F for ; Fri, 31 Jan 2020 07:06:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yf-Q9MElJlIO for ; Fri, 31 Jan 2020 07:06:39 -0500 (EST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AB43D4A4F7 for ; Fri, 31 Jan 2020 07:06:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580472399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O8Za+S+RT8N2UwLMl2kq7dZ6BHikmL9Pgno023mZKr8=; b=X5KHvz87m8Ema2TsvSEuE2xrHGiaqpy/wYvTZRGTzt+6A/SxjuByjvcZJJgwkzMPu+jupx ID2Z0mij6wXO/GMU/KNSEsPS/eqZL899ddI1S3sTul5woYBXEuWmWS3Zlcwi4rHuGtrfDp Qyu1FbfQfDU3ZAk2AXEjJ8TBxnpXtgM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-Ih36PAVQOHGA5sgccpxLOw-1; Fri, 31 Jan 2020 07:06:36 -0500 X-MC-Unique: Ih36PAVQOHGA5sgccpxLOw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 738599275B; Fri, 31 Jan 2020 12:06:33 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46DCC5C3FA; Fri, 31 Jan 2020 12:06:18 +0000 (UTC) Date: Fri, 31 Jan 2020 13:06:15 +0100 From: Cornelia Huck To: Sean Christopherson Subject: Re: [PATCH 1/5] KVM: Pass kvm_init()'s opaque param to additional arch funcs Message-ID: <20200131130615.3b21b28d.cohuck@redhat.com> In-Reply-To: <20200130001023.24339-2-sean.j.christopherson@intel.com> References: <20200130001023.24339-1-sean.j.christopherson@intel.com> <20200130001023.24339-2-sean.j.christopherson@intel.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Cc: Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, 29 Jan 2020 16:10:19 -0800 Sean Christopherson wrote: > Pass @opaque to kvm_arch_hardware_setup() and > kvm_arch_check_processor_compat() to allow architecture specific code to > reference @opaque without having to stash it away in a temporary global > variable. This will enable x86 to separate its vendor specific callback > ops, which are passed via @opaque, into "init" and "runtime" ops without > having to stash away the "init" ops. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/mips/kvm/mips.c | 4 ++-- > arch/powerpc/kvm/powerpc.c | 4 ++-- > arch/s390/kvm/kvm-s390.c | 4 ++-- > arch/x86/kvm/x86.c | 4 ++-- > include/linux/kvm_host.h | 4 ++-- > virt/kvm/arm/arm.c | 4 ++-- > virt/kvm/kvm_main.c | 18 ++++++++++++++---- > 7 files changed, 26 insertions(+), 16 deletions(-) > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index eb3709d55139..5ad252defa54 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4345,14 +4345,22 @@ struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void) > return &kvm_running_vcpu; > } > > -static void check_processor_compat(void *rtn) > +struct kvm_cpu_compat_check { > + void *opaque; > + int *ret; > +}; > + > +static void check_processor_compat(void *data) > { > - *(int *)rtn = kvm_arch_check_processor_compat(); > + struct kvm_cpu_compat_check *c = data; > + > + *c->ret = kvm_arch_check_processor_compat(c->opaque); > } This function also looks better now :) Reviewed-by: Cornelia Huck Tested-by: Cornelia Huck #s390 _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9254AC35240 for ; Fri, 31 Jan 2020 12:06:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6935820705 for ; Fri, 31 Jan 2020 12:06:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FNOhNJEB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728485AbgAaMGm (ORCPT ); Fri, 31 Jan 2020 07:06:42 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36529 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728481AbgAaMGm (ORCPT ); Fri, 31 Jan 2020 07:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580472401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O8Za+S+RT8N2UwLMl2kq7dZ6BHikmL9Pgno023mZKr8=; b=FNOhNJEBcvCYTW3H9XXRq3pr0djOxSNGvOyyLHA7HQl5CWyIwtje7m+w4lOCskh0UwxqeN g58/76vBqQtcSql6Vy0Dc9zbzFWF8k/rlj50Eu2poAoEdXGw2d1/hiP3XlElnT5jVH8uXo Kly5JkzQo463fmWRY/cQV+Jvt8pAvwg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-Ih36PAVQOHGA5sgccpxLOw-1; Fri, 31 Jan 2020 07:06:36 -0500 X-MC-Unique: Ih36PAVQOHGA5sgccpxLOw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 738599275B; Fri, 31 Jan 2020 12:06:33 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46DCC5C3FA; Fri, 31 Jan 2020 12:06:18 +0000 (UTC) Date: Fri, 31 Jan 2020 13:06:15 +0100 From: Cornelia Huck To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] KVM: Pass kvm_init()'s opaque param to additional arch funcs Message-ID: <20200131130615.3b21b28d.cohuck@redhat.com> In-Reply-To: <20200130001023.24339-2-sean.j.christopherson@intel.com> References: <20200130001023.24339-1-sean.j.christopherson@intel.com> <20200130001023.24339-2-sean.j.christopherson@intel.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, 29 Jan 2020 16:10:19 -0800 Sean Christopherson wrote: > Pass @opaque to kvm_arch_hardware_setup() and > kvm_arch_check_processor_compat() to allow architecture specific code to > reference @opaque without having to stash it away in a temporary global > variable. This will enable x86 to separate its vendor specific callback > ops, which are passed via @opaque, into "init" and "runtime" ops without > having to stash away the "init" ops. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/mips/kvm/mips.c | 4 ++-- > arch/powerpc/kvm/powerpc.c | 4 ++-- > arch/s390/kvm/kvm-s390.c | 4 ++-- > arch/x86/kvm/x86.c | 4 ++-- > include/linux/kvm_host.h | 4 ++-- > virt/kvm/arm/arm.c | 4 ++-- > virt/kvm/kvm_main.c | 18 ++++++++++++++---- > 7 files changed, 26 insertions(+), 16 deletions(-) > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index eb3709d55139..5ad252defa54 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4345,14 +4345,22 @@ struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void) > return &kvm_running_vcpu; > } > > -static void check_processor_compat(void *rtn) > +struct kvm_cpu_compat_check { > + void *opaque; > + int *ret; > +}; > + > +static void check_processor_compat(void *data) > { > - *(int *)rtn = kvm_arch_check_processor_compat(); > + struct kvm_cpu_compat_check *c = data; > + > + *c->ret = kvm_arch_check_processor_compat(c->opaque); > } This function also looks better now :) Reviewed-by: Cornelia Huck Tested-by: Cornelia Huck #s390 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040E8C33CB2 for ; Fri, 31 Jan 2020 12:08:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9CD420705 for ; Fri, 31 Jan 2020 12:08:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GLHv0cj+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dLrpOCao" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9CD420705 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x36rT51BZN1QX9rGR8y3SimOf0pO9yk+20X6h5hRflY=; b=GLHv0cj+Ow0fDC oSCRcMuZgtutLEamQs9KZnuonaPOvDLd4QcwSkE5pJ3iGt4Whv3f4VmJTqQ5NK1ZIzZBp1qT4P6Zn kHt3RMuhqrDBC5VbQJnriEZ8Mh3EoxWTO0g6Kd/o20sdMxfC69uJ/OQ3CovBuc2+v32cIsAmger71 BdHsaklVEfu+ISNzFzJ2aCCnhV9DP1q+gP/8bSP+Tk48IWPniGbPmRogpimW2eFaonZae7aULORC5 /rPRTawgNKiMteDmgvXP56EQw1T1TIdB83noS6VThCYYj2NzDcAhewmMM8nyvkiHvdW9wFYO7HuNh /KLx14eZ8DLY7V1hHREg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixV6C-00014S-C9; Fri, 31 Jan 2020 12:08:36 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixV68-000140-Mv for linux-arm-kernel@lists.infradead.org; Fri, 31 Jan 2020 12:08:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580472510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O8Za+S+RT8N2UwLMl2kq7dZ6BHikmL9Pgno023mZKr8=; b=dLrpOCao8Ad6VfdE8Otqi7oyHOqzC07Xf1ypnmlTiVhmslj0/M1ZeoDTWM6KyJl+WATqqh KF2CBVlZMf+zr+hsyc7+KnsbCAWx8PgG/rRDO4+IJT1lf6LGPjGYJ/3K212nHqeR0dtrQD zLA6bg8C+WlYFunLtqfN2cS713GFa/c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-Ih36PAVQOHGA5sgccpxLOw-1; Fri, 31 Jan 2020 07:06:36 -0500 X-MC-Unique: Ih36PAVQOHGA5sgccpxLOw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 738599275B; Fri, 31 Jan 2020 12:06:33 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46DCC5C3FA; Fri, 31 Jan 2020 12:06:18 +0000 (UTC) Date: Fri, 31 Jan 2020 13:06:15 +0100 From: Cornelia Huck To: Sean Christopherson Subject: Re: [PATCH 1/5] KVM: Pass kvm_init()'s opaque param to additional arch funcs Message-ID: <20200131130615.3b21b28d.cohuck@redhat.com> In-Reply-To: <20200130001023.24339-2-sean.j.christopherson@intel.com> References: <20200130001023.24339-1-sean.j.christopherson@intel.com> <20200130001023.24339-2-sean.j.christopherson@intel.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200131_040832_966751_A51D611A X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Morse , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 29 Jan 2020 16:10:19 -0800 Sean Christopherson wrote: > Pass @opaque to kvm_arch_hardware_setup() and > kvm_arch_check_processor_compat() to allow architecture specific code to > reference @opaque without having to stash it away in a temporary global > variable. This will enable x86 to separate its vendor specific callback > ops, which are passed via @opaque, into "init" and "runtime" ops without > having to stash away the "init" ops. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/mips/kvm/mips.c | 4 ++-- > arch/powerpc/kvm/powerpc.c | 4 ++-- > arch/s390/kvm/kvm-s390.c | 4 ++-- > arch/x86/kvm/x86.c | 4 ++-- > include/linux/kvm_host.h | 4 ++-- > virt/kvm/arm/arm.c | 4 ++-- > virt/kvm/kvm_main.c | 18 ++++++++++++++---- > 7 files changed, 26 insertions(+), 16 deletions(-) > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index eb3709d55139..5ad252defa54 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4345,14 +4345,22 @@ struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void) > return &kvm_running_vcpu; > } > > -static void check_processor_compat(void *rtn) > +struct kvm_cpu_compat_check { > + void *opaque; > + int *ret; > +}; > + > +static void check_processor_compat(void *data) > { > - *(int *)rtn = kvm_arch_check_processor_compat(); > + struct kvm_cpu_compat_check *c = data; > + > + *c->ret = kvm_arch_check_processor_compat(c->opaque); > } This function also looks better now :) Reviewed-by: Cornelia Huck Tested-by: Cornelia Huck #s390 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel