From: Rob Herring <robh@kernel.org>
To: Akash Asthana <akashast@codeaurora.org>
Cc: robh+dt@kernel.org, agross@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, mgautam@codeaurora.org,
rojay@codeaurora.org, c_skakit@codeaurora.org,
Akash Asthana <akashast@codeaurora.org>
Subject: Re: [PATCH V3] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML
Date: Fri, 31 Jan 2020 08:24:29 -0600 [thread overview]
Message-ID: <20200131142429.GA5642@bogus> (raw)
In-Reply-To: <1580378322-32729-1-git-send-email-akashast@codeaurora.org>
On Thu, 30 Jan 2020 15:28:42 +0530, Akash Asthana wrote:
> Convert QUP geni-se bindings to DT schema format using json-schema.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> Changes in V2:
> - As per Stephen's comment corrected defintion of interrupts for UART node.
> Any valid UART node must contain atleast 1 interrupts.
>
> Changes in V3:
> - As per Rob's comment, added number of reg entries for reg property.
> - As per Rob's comment, corrected unit address to hex.
> - As per Rob's comment, created a pattern which matches everything common
> to geni based I2C, SPI and UART controller and then one pattern for each.
> - As per Rob's comment, restored original example.
>
> .../devicetree/bindings/soc/qcom/qcom,geni-se.txt | 94 ---------
> .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 211 +++++++++++++++++++++
> 2 files changed, 211 insertions(+), 94 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
warning: no schema found in file: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml: ignoring, error in schema: properties: clocks: minItems
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml: properties:clocks:minItems: False schema does not allow 2
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml: properties:clocks:maxItems: False schema does not allow 2
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1231351
Please check and re-submit.
prev parent reply other threads:[~2020-01-31 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 9:58 [PATCH V3] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML Akash Asthana
2020-01-31 14:24 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131142429.GA5642@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=c_skakit@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.