From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v2 2/2] tpm: tpm2_bios_measurements_next should increase position index
Date: Sat, 1 Feb 2020 19:03:29 +0200 [thread overview]
Message-ID: <20200201170329.GA14875@linux.intel.com> (raw)
In-Reply-To: <16bde2d6-4208-e478-0ac3-163b5c3a1eaa@virtuozzo.com>
On Thu, Jan 30, 2020 at 01:23:21PM +0300, Vasily Averin wrote:
> If seq_file .next function does not change position index,
> read after non-zero lseek can generate unexpected output.
Is it unwanted or unexpected? Unexpected would be mean random
output. I don't think that is the case. Please describe more
throughly.
> For /sys/kernel/security/tpm0/binary_bios_measurements:
> 1) read after lseek beyond end of file generates whole last line.
> 2) read after lseek to middle of last line generates
> expected end of last line and unexpected whole last line once again.
>
> Cc: stable@vger.kernel.org
> Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code ...")
>
No empty line here.
> https://bugzilla.kernel.org/show_bug.cgi?id=206283
"Link: https://bugzilla.kernel.org/show_bug.cgi?id=206283"
/Jarkko
next prev parent reply other threads:[~2020-02-01 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 7:48 [PATCH 1/2] tpm1_bios_measurements_next should increase position index Vasily Averin
2020-01-29 13:23 ` Jarkko Sakkinen
2020-01-29 13:25 ` Jarkko Sakkinen
2020-01-30 10:23 ` [PATCH v2 0/2] tpm: seq_file .next functions " Vasily Averin
2020-01-30 10:23 ` [PATCH v2 1/2] tpm: tpm1_bios_measurements_next " Vasily Averin
2020-01-30 10:23 ` [PATCH v2 2/2] tpm: tpm2_bios_measurements_next " Vasily Averin
2020-02-01 17:03 ` Jarkko Sakkinen [this message]
2020-02-03 5:14 ` Vasily Averin
2020-02-05 22:03 ` Jarkko Sakkinen
2020-02-25 6:26 ` [PATCH v3 1/2] tpm: tpm1_bios_measurements_next " Vasily Averin
2020-02-25 10:27 ` Jarkko Sakkinen
2020-02-25 10:29 ` Jarkko Sakkinen
2020-02-25 6:26 ` [PATCH v3 2/2] tpm: tpm2_bios_measurements_next " Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201170329.GA14875@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.