All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Yunjian Wang <wangyunjian@huawei.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, xudingke@huawei.com
Subject: Re: [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format
Date: Sun, 2 Feb 2020 14:55:26 +0800	[thread overview]
Message-ID: <20200202065526.GH54838@intel.com> (raw)
In-Reply-To: <1578918028-23280-1-git-send-email-wangyunjian@huawei.com>

On 01/13, Yunjian Wang wrote:
>Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>
>Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>---
> drivers/net/e1000/em_ethdev.c  | 2 +-
> drivers/net/e1000/igb_ethdev.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
>index 080cbe2df..188cda350 100644
>--- a/drivers/net/e1000/em_ethdev.c
>+++ b/drivers/net/e1000/em_ethdev.c
>@@ -1605,7 +1605,7 @@ eth_em_interrupt_action(struct rte_eth_dev *dev,
> 	} else {
> 		PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id);
> 	}
>-	PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
>+	PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
> 		     pci_dev->addr.domain, pci_dev->addr.bus,
> 		     pci_dev->addr.devid, pci_dev->addr.function);
> 
>diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
>index a3e30dbe5..30e303c9b 100644
>--- a/drivers/net/e1000/igb_ethdev.c
>+++ b/drivers/net/e1000/igb_ethdev.c
>@@ -2914,7 +2914,7 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev,
> 				     dev->data->port_id);
> 		}
> 
>-		PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
>+		PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
> 			     pci_dev->addr.domain,
> 			     pci_dev->addr.bus,
> 			     pci_dev->addr.devid,
>-- 
>2.19.1
>
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

      reply	other threads:[~2020-02-02  6:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 12:20 [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format Yunjian Wang
2020-02-02  6:55 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200202065526.GH54838@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.