From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: Kamal Heib <kamalheib1@gmail.com>,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH for-next] RDMA/providers: Fix return value when QP type isn't supported
Date: Sun, 2 Feb 2020 11:29:56 +0200 [thread overview]
Message-ID: <20200202092956.GI414821@unreal> (raw)
In-Reply-To: <1f508bbc-d858-13b6-d81e-db95fa172e9a@intel.com>
On Thu, Jan 30, 2020 at 11:07:17AM -0500, Dennis Dalessandro wrote:
> On 1/30/2020 3:39 AM, Leon Romanovsky wrote:
> > On Thu, Jan 30, 2020 at 10:20:49AM +0200, Kamal Heib wrote:
> > > The proper return code is "-EOPNOTSUPP" when the requested QP type is
> > > not supported by the provider.
> > >
> > > Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> > > ---
> > > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +-
> > > drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> > > drivers/infiniband/hw/hns/hns_roce_qp.c | 2 +-
> > > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 2 +-
> > > drivers/infiniband/hw/mlx4/qp.c | 2 +-
> > > drivers/infiniband/hw/mlx5/qp.c | 2 +-
> > > drivers/infiniband/hw/mthca/mthca_provider.c | 2 +-
> > > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
> > > drivers/infiniband/hw/qedr/verbs.c | 2 +-
> > > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +-
> > > drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 2 +-
> > > drivers/infiniband/sw/rdmavt/qp.c | 2 +-
> > > drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> > > 13 files changed, 13 insertions(+), 13 deletions(-)
> >
> > *_err() prints definitely should go too. Simple user space
> > application will create DDOS on dmesg with those prints.
> >
> > I would say that other prints should be removed too or at least
> > put in general way inside the caller of ->create_qp() callback.
>
> I'd agree but I don't think that has to be done in this patch. This looks
> fine to me.
No doubts, I simply want to reduce the amount of churn.
Thanks
>
> -Denny
>
>
next prev parent reply other threads:[~2020-02-02 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 8:20 [PATCH for-next] RDMA/providers: Fix return value when QP type isn't supported Kamal Heib
2020-01-30 8:39 ` Leon Romanovsky
2020-01-30 16:07 ` Dennis Dalessandro
2020-02-02 9:29 ` Leon Romanovsky [this message]
2020-01-30 16:08 ` Dennis Dalessandro
2020-02-20 23:01 ` Kamal Heib
2020-02-21 16:47 ` Jason Gunthorpe
2020-03-04 16:14 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200202092956.GI414821@unreal \
--to=leon@kernel.org \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.