From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:3aa:0:0:0:0 with SMTP id v10csp3531770lfp; Sun, 2 Feb 2020 21:33:51 -0800 (PST) X-Google-Smtp-Source: APXvYqwPX3ohC97qzz27bLRhlEeVptwVv9v2sJh43JFJ6zuDzqcM2Vkxy1IDB3Z6nNqxCHGhS9O2 X-Received: by 2002:a05:620a:15d2:: with SMTP id o18mr21460713qkm.362.1580708031163; Sun, 02 Feb 2020 21:33:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580708031; cv=none; d=google.com; s=arc-20160816; b=RAmOLLAv/yZ3ejPB1qD1R7Z8UlsAWge4l5wDPdhRQhDG1HRe+5yDp3DnVKuDSJCOxv gGeFDZMi4S/O+MowRHp2IdOLXke8Y/ROsNdTCnUm10+dkfGdSFf68MclWMKnrf5+06ps mNQn9k0UBjcVdjPTm+wKDYJLqrpbIdTl7uLaHXMpDwzDT6ki5PkKtH/xlYO7dQIJIn3e 62P2mcJEvQC+9Tgc/LLR7rmWe9Oe8V6fMxNoHALz+LxDj8tJwPEdML4MdT+K3X2WDv33 D2yANfmsDdUupFaoDpDYlY12FgQG34AFLdq5IQRokanh8cx1htnaz7hpeXmKCQg6XYD2 2ruQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:to:from:date:dkim-signature; bh=1v5ZDgJz4lo0/aHyDLKtNK1jfVSHLJs35hRLryCl0B0=; b=MC2zCvX5MstkTo6BdQG28gW4zWGawJpHhoZ3Y6+wAGxP2dFBiuqlyJrKDWck+zWr8Y AziMSF7mPknTkYRsB/WQDuz9qbRUMTSRhm3+rfcif4sj7jHpZF/WYMINkFehu7P25CVc xEnSdvQs02+ADMz9p0+ooe1wepyh/++zkKw0HWkA5R96CSeXHuWdTADkCVqXAsHHJUAA fSH6krIdxzqGvxQWiJg4b6xwT1BbQB8g4jmwqUjFeS45Vap6oiCMRrjsc/Nb8i30nR9U jZX3Gof0dpHCknRh3mT4b8t5EZubgxl7FFtspC7iJfBNZePEejY7Bd0k2qOuJvjfTGg5 f7rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="ivzqs/nL"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b13si11348087qtp.218.2020.02.02.21.33.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Feb 2020 21:33:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b="ivzqs/nL"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:34484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyUMo-0000SL-Jc for alex.bennee@linaro.org; Mon, 03 Feb 2020 00:33:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49530) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyUMY-0000NQ-To for qemu-arm@nongnu.org; Mon, 03 Feb 2020 00:33:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyUMX-0005uk-Iy for qemu-arm@nongnu.org; Mon, 03 Feb 2020 00:33:34 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:56884 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyUMX-0005uS-9x for qemu-arm@nongnu.org; Mon, 03 Feb 2020 00:33:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580708013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1v5ZDgJz4lo0/aHyDLKtNK1jfVSHLJs35hRLryCl0B0=; b=ivzqs/nLqjbaSZt7dZl1cOClVFf/QnGvhGG/EBc+Tn80c8O8p/6RCYXCEoog0YGJiXQT/Y mYNtg6s0wIZnpAWCFok+ee7cvl7LAcz/2TafEiAGY+uYu6OCqX8pCCKWY8eawU5TTl0Yfu snQshpXrmCjEHRq3EUsGrTysXefSbqk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-3fGjkFmtMmKy4p7kdD1ezQ-1; Mon, 03 Feb 2020 00:33:18 -0500 Received: by mail-wm1-f72.google.com with SMTP id 7so4328719wmf.9 for ; Sun, 02 Feb 2020 21:33:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D/ynwPAmUV5gzUzi87Vny8EAYzqtaWbLP3m6OVmvvSQ=; b=KeQylIkBhofNbypc/7AByFuu2fnu737J5L7sqzKL0FTNLyKZuRkV5HMmRnKRI9hAWf ts9UWUj7JRj3WcgWKVZeD/aDOZWfB9H/E7FR/TZgqlfp62oRu84b/Ufk4ha7dTLWxd6P lwxTC+1aRJN9lVNA6LU8lOcNixFEq2s2i/4ZDT1I2prSEeyGf4uuHSX23gLyRznVykmp CrS+s0wEu/wFabHlOwPdtgVt1cEJz5b4ycU0joXxTKJeMOmn+HX7Kq4OGnO5m5nQQWUE JgkH09b475ZUVbItRMueJNWDkKOp9D8BgDwA8hz22Mpug64b6JnksaJlPPARCfEbpBI+ BFbA== X-Gm-Message-State: APjAAAX9oPaAMHVoPeiT2MYe5oqi+Rj0N5JGTn8V/7MCJFFfRbb+RLC1 1VrlcywJYb5NRoXEG917Mx3SxcR67CgJn3ntIM0liK2ePr7AeyTnADKYXj1cWlsemNm/1Tb3egD Gp5ketoVTin3M X-Received: by 2002:a1c:6308:: with SMTP id x8mr27193850wmb.80.1580707997179; Sun, 02 Feb 2020 21:33:17 -0800 (PST) X-Received: by 2002:a1c:6308:: with SMTP id x8mr27193828wmb.80.1580707996983; Sun, 02 Feb 2020 21:33:16 -0800 (PST) Received: from redhat.com (ip-82-36-244-173.west.us.northamericancoax.com. [173.244.36.82]) by smtp.gmail.com with ESMTPSA id p11sm11553020wrn.40.2020.02.02.21.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Feb 2020 21:33:15 -0800 (PST) Date: Mon, 3 Feb 2020 00:33:08 -0500 From: "Michael S. Tsirkin" To: Heyi Guo Subject: Re: [PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID Message-ID: <20200203003301-mutt-send-email-mst@kernel.org> References: <20200203001505.52573-1-guoheyi@huawei.com> <20200203001505.52573-4-guoheyi@huawei.com> MIME-Version: 1.0 In-Reply-To: <20200203001505.52573-4-guoheyi@huawei.com> X-MC-Unique: 3fGjkFmtMmKy4p7kdD1ezQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Igor Mammedov , wanghaibin.wang@huawei.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 8PD3wU6AEBdY On Mon, Feb 03, 2020 at 08:15:01AM +0800, Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device on a bus that > has a standard enumeration algorithm, but not for device which is on > system bus and must be enumerated by OSPM. And it is not recommended > to contain both _HID and _ADR in a single device. >=20 > See ACPI 6.3, section 6.1, top of page 343: >=20 > A device object must contain either an _HID object or an _ADR object, > but should not contain both. >=20 > (https://uefi.org/sites/default/files/resources/ACPI_6_3_May16.pdf) >=20 > Signed-off-by: Heyi Guo > Acked-by: Igor Mammedov Acked-by: Michael S. Tsirkin > --- > Cc: Shannon Zhao > Cc: Peter Maydell > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: qemu-arm@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/arm/virt-acpi-build.c | 8 -------- > 1 file changed, 8 deletions(-) >=20 > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 9f4c7d1889..be752c0ad8 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -78,11 +78,6 @@ static void acpi_dsdt_add_uart(Aml *scope, const MemMa= pEntry *uart_memmap, > AML_EXCLUSIVE, &uart_irq, 1)); > aml_append(dev, aml_name_decl("_CRS", crs)); > =20 > - /* The _ADR entry is used to link this device to the UART described > - * in the SPCR table, i.e. SPCR.base_address.address =3D=3D _ADR. > - */ > - aml_append(dev, aml_name_decl("_ADR", aml_int(uart_memmap->base))); > - > aml_append(scope, dev); > } > =20 > @@ -170,7 +165,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMa= pEntry *memmap, > aml_append(dev, aml_name_decl("_CID", aml_string("PNP0A03"))); > aml_append(dev, aml_name_decl("_SEG", aml_int(0))); > aml_append(dev, aml_name_decl("_BBN", aml_int(0))); > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > aml_append(dev, aml_name_decl("_UID", aml_string("PCI0"))); > aml_append(dev, aml_name_decl("_STR", aml_unicode("PCIe 0 Device")))= ; > aml_append(dev, aml_name_decl("_CCA", aml_int(1))); > @@ -334,7 +328,6 @@ static void acpi_dsdt_add_gpio(Aml *scope, const MemM= apEntry *gpio_memmap, > { > Aml *dev =3D aml_device("GPO0"); > aml_append(dev, aml_name_decl("_HID", aml_string("ARMH0061"))); > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > aml_append(dev, aml_name_decl("_UID", aml_int(0))); > =20 > Aml *crs =3D aml_resource_template(); > @@ -364,7 +357,6 @@ static void acpi_dsdt_add_power_button(Aml *scope) > { > Aml *dev =3D aml_device(ACPI_POWER_BUTTON_DEVICE); > aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > - aml_append(dev, aml_name_decl("_ADR", aml_int(0))); > aml_append(dev, aml_name_decl("_UID", aml_int(0))); > aml_append(scope, dev); > } > --=20 > 2.19.1