From: Richard Cochran <richardcochran@gmail.com>
To: christopher.s.hall@intel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, hpa@zytor.com, mingo@redhat.com,
x86@kernel.org, jacob.e.keller@intel.com, davem@davemloft.net,
sean.v.kelley@intel.com
Subject: Re: [Intel PMC TGPIO Driver 3/5] drivers/ptp: Add user-space input polling interface
Date: Sun, 2 Feb 2020 18:28:50 -0800 [thread overview]
Message-ID: <20200203022850.GC3516@localhost> (raw)
In-Reply-To: <20191211214852.26317-4-christopher.s.hall@intel.com>
On Wed, Dec 11, 2019 at 01:48:50PM -0800, christopher.s.hall@intel.com wrote:
> From: Christopher Hall <christopher.s.hall@intel.com>
>
> The Intel PMC Time-Aware GPIO controller doesn't implement interrupts to
> notify software that an input event has occurred. To solve this problem,
> implement a user-space polling interface allowing the application to check
> for input events. The API returns an event count and time. This interface
> (EVENT_COUNT_TSTAMP2) is *reused* from the output frequency adjustment API.
> The event count delta indicates that one or more events have occurred and
> how many events may have been missed.
So I think this interface is truly horrible.
The ptp_pin_desc describes a pin's configuration WRT the PTP_PF_xxx
and the specific EXTTS/PEROUT_REQUEST channel. I don't know exactly
what you are trying to accomplish, but there has got to be a better
way. Re-using the ptp_pin_desc for a polling interface is surely not
the way forward.
Thanks,
Richard
next prev parent reply other threads:[~2020-02-03 2:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 21:48 [Intel PMC TGPIO Driver 0/5] Add support for Intel PMC Time GPIO Driver with PHC interface changes to support additional H/W Features christopher.s.hall
2019-12-11 21:48 ` [Intel PMC TGPIO Driver 1/5] drivers/ptp: Add Enhanced handling of reserve fields christopher.s.hall
2020-01-31 16:54 ` Jacob Keller
2020-02-03 1:45 ` Richard Cochran
2020-02-24 23:29 ` Christopher S. Hall
2020-01-31 17:02 ` Jacob Keller
2020-02-03 1:27 ` Richard Cochran
2020-02-24 23:23 ` Christopher S. Hall
2019-12-11 21:48 ` [Intel PMC TGPIO Driver 2/5] drivers/ptp: Add PEROUT2 ioctl frequency adjustment interface christopher.s.hall
2020-02-03 2:14 ` Richard Cochran
2020-02-26 0:20 ` Christopher S. Hall
2019-12-11 21:48 ` [Intel PMC TGPIO Driver 3/5] drivers/ptp: Add user-space input polling interface christopher.s.hall
2020-02-03 2:28 ` Richard Cochran [this message]
2019-12-11 21:48 ` [Intel PMC TGPIO Driver 4/5] x86/tsc: Add TSC support functions to support ART driven Time-Aware GPIO christopher.s.hall
2019-12-11 21:48 ` [Intel PMC TGPIO Driver 5/5] drivers/ptp: Add PMC Time-Aware GPIO Driver christopher.s.hall
2020-02-03 2:31 ` Richard Cochran
2020-02-07 17:10 ` Linus Walleij
2020-02-07 17:28 ` Andrew Lunn
2020-02-07 19:49 ` Andy Shevchenko
2020-02-07 19:52 ` Andy Shevchenko
2020-02-24 23:17 ` Christopher S. Hall
2020-01-31 15:08 ` [Intel PMC TGPIO Driver 0/5] Add support for Intel PMC Time GPIO Driver with PHC interface changes to support additional H/W Features Jakub Kicinski
2020-01-31 18:14 ` Thomas Gleixner
2020-02-24 22:40 ` Christopher S. Hall
2020-02-26 23:06 ` Thomas Gleixner
2020-03-03 1:56 ` Christopher S. Hall
2020-03-03 13:00 ` Linus Walleij
2020-03-03 15:23 ` Richard Cochran
2020-03-03 15:24 ` Thomas Gleixner
2020-03-08 19:14 ` Jonathan Cameron
2020-02-03 4:08 ` Richard Cochran
2020-02-03 18:27 ` Jacob Keller
2020-02-25 23:37 ` Christopher S. Hall
2020-02-26 2:47 ` Richard Cochran
2020-03-03 2:01 ` Christopher S. Hall
2020-02-07 17:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203022850.GC3516@localhost \
--to=richardcochran@gmail.com \
--cc=christopher.s.hall@intel.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sean.v.kelley@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.