From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Corey Minyard <cminyard@mvista.com>,
Eduardo Habkost <ehabkost@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PULL v3 17/18] i386:acpi: Remove _HID from the SMBus ACPI entry
Date: Mon, 3 Feb 2020 07:50:12 -0500 [thread overview]
Message-ID: <20200203073844-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA8c3wQ3AS9JD_NPvbG8pr000LGkRs8NwMSg5CY7dPiWXA@mail.gmail.com>
On Mon, Feb 03, 2020 at 12:10:33PM +0000, Peter Maydell wrote:
> On Mon, 3 Feb 2020 at 12:03, Corey Minyard <cminyard@mvista.com> wrote:
> >
> > I checked a few days ago and someone had already beat me to it.
>
> Yeah, we had a discussion on IRC about it and came to the
> conclusion that this was a fix. To avoid future confusion,
> my suggestion would be that commit messages that fix bugs
> should explicitly say they fix bugs they refer to; "See $BUG"
> implies to me a looser connection like "this is another bug in
> this area" or "this partially addresses that bug" or
> "this bug report mentioned this issue in passing while
> describing a different bug".
>
> thanks
> -- PMM
Right. Probably Fixes: <> that (I think) github pioneered.
--
MST
next prev parent reply other threads:[~2020-02-03 12:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 7:10 [PULL v3 00/18] virtio, pc: fixes, features Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 01/18] q35: implement 128K SMRAM at default SMBASE address Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 02/18] tests: q35: MCH: add default SMBASE SMRAM lock test Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 03/18] acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 04/18] acpi: cpuhp: spec: fix 'Command data' description Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 05/18] acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 06/18] acpi: cpuhp: introduce 'Command data 2' field Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 07/18] acpi: cpuhp: spec: add typical usecases Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 08/18] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 09/18] bios-tables-test: document expected file update Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 10/18] virtio-9p-device: fix memleak in virtio_9p_device_unrealize Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 11/18] virtio-9p-device: convert to new virtio_delete_queue Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 12/18] virtio-scsi: delete vqs in unrealize to avoid memleaks Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 13/18] virtio-scsi: convert to new virtio_delete_queue Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 14/18] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 15/18] vhost: Add names to section rounded warning Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 16/18] vhost: Only align sections for vhost-user Michael S. Tsirkin
2020-01-23 7:10 ` [PULL v3 17/18] i386:acpi: Remove _HID from the SMBus ACPI entry Michael S. Tsirkin
2020-01-30 19:05 ` Peter Maydell
2020-02-03 6:33 ` Michael S. Tsirkin
2020-02-03 12:03 ` Corey Minyard
2020-02-03 12:10 ` Peter Maydell
2020-02-03 12:50 ` Michael S. Tsirkin [this message]
2020-01-23 7:11 ` [PULL v3 18/18] vhost: coding style fix Michael S. Tsirkin
2020-01-23 7:45 ` [PULL v3 00/18] virtio, pc: fixes, features no-reply
2020-01-23 7:47 ` Michael S. Tsirkin
2020-01-23 14:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203073844-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cminyard@mvista.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.