From: Ingo Molnar <mingo@kernel.org>
To: "Jörg Otte" <jrg.otte@gmail.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: EFI boot crash regression (was: Re: 5.6-### doesn't boot)
Date: Mon, 3 Feb 2020 08:45:52 +0100 [thread overview]
Message-ID: <20200203074552.GA54169@gmail.com> (raw)
In-Reply-To: <CADDKRnAo9B=+cNO-_VbH4yADVsQqaTb61ithqxohYCwgAm6pvg@mail.gmail.com>
* Jörg Otte <jrg.otte@gmail.com> wrote:
> Am So., 2. Feb. 2020 um 10:22 Uhr schrieb Ingo Molnar <mingo@kernel.org>:
> >
> >
> > * Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >
> > > Hello Jörg,
> > >
> > > Could you please try whether the change below fixes the issue?
> > >
> > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> > > index 59f7f6d60cf6..ae923ee8e2b4 100644
> > > --- a/arch/x86/platform/efi/efi.c
> > > +++ b/arch/x86/platform/efi/efi.c
> > > @@ -308,7 +308,7 @@ static void __init efi_clean_memmap(void)
> > > .phys_map = efi.memmap.phys_map,
> > > .desc_version = efi.memmap.desc_version,
> > > .desc_size = efi.memmap.desc_size,
> > > - .size = data.desc_size * (efi.memmap.nr_map - n_removal),
> > > + .size = efi.memmap.desc_size * (efi.memmap.nr_map - n_removal),
> > > .flags = 0,
> >
> > Oh, I actually noticed this one, but convinced myself that it's correct,
> > because GCC didn't warn about uninitialized data.
> >
> > But maybe in this weird case data.desc_size as used within its own
> > initializer is zero?
>
> Patch makes my kernel booting again :)
Thank you! I'll send the fix to Linus later today.
Ingo
next prev parent reply other threads:[~2020-02-03 7:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 17:32 5.6-### doesn't boot Jörg Otte
2020-01-30 18:07 ` Linus Torvalds
2020-01-30 18:22 ` Andy Lutomirski
2020-01-31 6:43 ` Ingo Molnar
2020-01-31 10:35 ` Jörg Otte
2020-01-31 18:36 ` EFI boot crash regression (was: Re: 5.6-### doesn't boot) Ingo Molnar
2020-01-31 18:48 ` Dan Williams
2020-02-01 15:35 ` Jörg Otte
2020-02-01 16:02 ` Ard Biesheuvel
2020-02-02 9:22 ` Ingo Molnar
2020-02-02 9:32 ` Ard Biesheuvel
2020-02-02 11:07 ` Jörg Otte
2020-02-03 7:45 ` Ingo Molnar [this message]
2020-02-01 21:29 ` Dan Williams
2020-02-01 9:45 ` [TEST PATCH RFC] Revert the EFI leak fixes for now (was: Re: EFI boot crash regression (was: Re: 5.6-### doesn't boot)) Ingo Molnar
2020-02-01 16:23 ` Dan Williams
[not found] ` <CAKv+Gu-oPrM7oh-oTbpQsUmXcYvp9KxjXFb3DUGk__qu59rdBQ@mail.gmail.com>
2020-02-01 21:44 ` EFI boot crash regression (was: Re: 5.6-### doesn't boot) Dan Williams
2020-02-01 21:49 ` Ard Biesheuvel
2020-02-01 22:31 ` Dan Williams
2020-02-01 22:36 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203074552.GA54169@gmail.com \
--to=mingo@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=jrg.otte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.