From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Lei YU <mine260309@gmail.com>,
Luca Ceresoli <luca@lucaceresoli.net>
Subject: Re: [PATCH 2/2] docs: i2c: dev-interface: document the actual implementation
Date: Mon, 3 Feb 2020 13:21:37 +0100 [thread overview]
Message-ID: <20200203132137.6bed750a@endymion> (raw)
In-Reply-To: <20200129211337.GG7586@ninjato>
On Wed, 29 Jan 2020 22:13:37 +0100, Wolfram Sang wrote:
> > So let's say you want to access an I2C adapter from a C program.
> > -First, you need to include these two headers::
> > +First, you need to include these three header files::
>
> Just stumbled over it: maybe just drop the 'three'? No number makes
> maintenance easier and it is not important for the user, I'd think.
>
> >
> > + #include <linux/i2c.h>
> > #include <linux/i2c-dev.h>
> > - #include <i2c/smbus.h>
> > + #include <sys/ioctl.h>
Agreed, fixed.
Thanks,
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-02-03 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 9:52 [PATCH 0/2] Move the SMBus API documentation to libi2c Jean Delvare
2020-01-23 10:03 ` [PATCH 1/2] libi2c: Add a manual page to document the API Jean Delvare
2020-01-23 10:17 ` Jean Delvare
2020-01-23 10:11 ` [PATCH 2/2] docs: i2c: dev-interface: document the actual implementation Jean Delvare
2020-01-23 11:09 ` Wolfram Sang
2020-01-23 13:42 ` Luca Ceresoli
2020-02-03 13:27 ` Jean Delvare
2020-02-03 16:35 ` Luca Ceresoli
2020-02-03 19:43 ` Wolfram Sang
2020-02-04 17:17 ` Jean Delvare
2020-01-29 21:13 ` Wolfram Sang
2020-02-03 12:21 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203132137.6bed750a@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mine260309@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.