All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Graute <oliver.graute@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1
Date: Mon, 3 Feb 2020 16:31:30 +0100	[thread overview]
Message-ID: <20200203153130.GA687@optiplex> (raw)
In-Reply-To: <CAOMZO5CqXT3_McoSP8HvXpHUaxG25AzViuJqbon+TAPydQ8nrw@mail.gmail.com>

On 03/02/20, Fabio Estevam wrote:
> On Fri, Jan 31, 2020 at 10:56 AM Oliver Graute
> <oliver.graute@kococonnector.com> wrote:
> >
> > This fix the following issue on the imx8qm_rom7720 board:
> >
> > Booting from net ...
> > Could not get PHY for FEC0: addr 0
> > Could not get PHY for FEC0: addr 0
> > Could not get PHY for FEC0: addr 0
> > Could not get PHY for FEC0: addr 0
> > Can't find FEC0 clk rate: -19
> >
> > This fix is necessary because of the changes introduced by commit:
> >
> > 1f60789602e0d5f5f9a8b507f25737c65b5d8daa.
> >
> > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Peng Fan <peng.fan@nxp.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Ye Li <ye.li@nxp.com>
> > Cc: uboot-imx <uboot-imx@nxp.com>
> > ---
> >  include/configs/imx8qm_rom7720.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h
> > index 865863eb7c..d503ddbffe 100644
> > --- a/include/configs/imx8qm_rom7720.h
> > +++ b/include/configs/imx8qm_rom7720.h
> > @@ -171,6 +171,7 @@
> >
> >  /* Networking */
> >  #define CONFIG_FEC_XCV_TYPE            RGMII
> > +#define CONFIG_FEC_MXC_PHYADDR         -1
> 
> Shouldn't the Ethernet PHY address be retrieved from the device tree instead?

Yes, but phy addr 0 is currently not working that way for me. So I tried
to solve it by autodetecting the phy. Please see this thread:

https://lists.denx.de/pipermail/u-boot/2019-December/393969.html

Best Regards,

Oliver

  reply	other threads:[~2020-02-03 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 13:56 [PATCH v1] imx: set CONFIG_FEC_MXC_PHYADDR to -1 Oliver Graute
2020-02-03 15:13 ` Fabio Estevam
2020-02-03 15:31   ` Oliver Graute [this message]
2020-02-03 15:39     ` Fabio Estevam
2020-02-03 16:07       ` Oliver Graute
2020-02-05  0:49         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203153130.GA687@optiplex \
    --to=oliver.graute@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.