From: Luis Chamberlain <mcgrof@kernel.org>
To: Jari Ruusu <jari.ruusu@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, Fenghua Yu <fenghua.yu@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: Fix built-in early-load Intel microcode alignment
Date: Mon, 3 Feb 2020 20:10:47 +0000 [thread overview]
Message-ID: <20200203201047.GL11244@42.do-not-panic.com> (raw)
In-Reply-To: <CACMCwJK-2DHZDA_F5Z3wsEUEKJSc3uOwwPD4HRoYGW7A+kA75w@mail.gmail.com>
On Sun, Jan 12, 2020 at 03:00:53PM +0200, Jari Ruusu wrote:
> Intel Software Developer's Manual, volume 3, chapter 9.11.6 says:
> "Note that the microcode update must be aligned on a 16-byte
> boundary and the size of the microcode update must be 1-KByte
> granular"
>
> When early-load Intel microcode is loaded from initramfs,
> userspace tool 'iucode_tool' has already 16-byte aligned those
> microcode bits in that initramfs image. Image that was created
> something like this:
>
> iucode_tool --write-earlyfw=FOO.cpio microcode-files...
>
> However, when early-load Intel microcode is loaded from built-in
> firmware BLOB using CONFIG_EXTRA_FIRMWARE= kernel config option,
> that 16-byte alignment is not guaranteed.
>
> Fix this by forcing all built-in firmware BLOBs to 16-byte
> alignment.
>
>
> Signed-off-by: Jari Ruusu <jari.ruusu@gmail.com>
>
> --- a/drivers/base/firmware_loader/builtin/Makefile
> +++ b/drivers/base/firmware_loader/builtin/Makefile
> @@ -17,7 +17,7 @@
> filechk_fwbin = \
> echo "/* Generated by $(src)/Makefile */" ;\
> echo " .section .rodata" ;\
> - echo " .p2align $(ASM_ALIGN)" ;\
> + echo " .p2align 4" ;\
Why not just keep ASM_ALIGN and define it to 4, with a nice
comment explaining the ucode stuff. Now we have a raw 4 here
and still use ASM_ALIGN which will depend on 64-bit or not.
Luis
> echo "_fw_$(FWSTR)_bin:" ;\
> echo " .incbin \"$(fwdir)/$(FWNAME)\"" ;\
> echo "_fw_end:" ;\
>
> --
> Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD ACDF F073 3C80 8132 F189
prev parent reply other threads:[~2020-02-03 20:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 13:00 Fix built-in early-load Intel microcode alignment Jari Ruusu
2020-01-12 13:03 ` Jari Ruusu
2020-01-12 14:02 ` Greg KH
2020-01-13 6:30 ` Jari Ruusu
2020-01-13 6:42 ` Greg KH
2020-01-13 15:47 ` Luis Chamberlain
2020-01-13 19:44 ` Linus Torvalds
2020-01-15 2:27 ` Luis Chamberlain
2020-01-18 20:10 ` Bjorn Andersson
2020-01-18 20:10 ` Bjorn Andersson
2020-01-13 19:58 ` Jari Ruusu
2020-01-13 20:08 ` Borislav Petkov
2020-01-13 20:30 ` Jari Ruusu
2020-01-13 20:46 ` Borislav Petkov
2020-01-15 2:15 ` Luis Chamberlain
2020-01-15 18:46 ` Jari Ruusu
2020-01-15 18:58 ` Luis Chamberlain
2020-01-15 19:41 ` Linus Torvalds
2020-01-15 19:00 ` Andy Lutomirski
2020-01-15 19:15 ` Jari Ruusu
2020-01-15 19:49 ` Linus Torvalds
2020-01-16 6:55 ` Jari Ruusu
2020-01-16 19:16 ` Raj, Ashok
2020-01-17 9:47 ` Jari Ruusu
2020-02-03 20:10 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203201047.GL11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=jari.ruusu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.