From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander Steffen <Alexander.Steffen@infineon.com>
Cc: Stephen Boyd <swboyd@chromium.org>,
Peter Huewe <peterhuewe@gmx.de>,
Andrey Pronin <apronin@chromium.org>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v7 4/6] tpm: tpm_tis_spi: Support cr50 devices
Date: Tue, 4 Feb 2020 14:00:48 +0200 [thread overview]
Message-ID: <20200204120048.GA28552@linux.intel.com> (raw)
In-Reply-To: <9064d7e2-d0ae-0cf0-294f-a795da336a6f@infineon.com>
On Tue, Feb 04, 2020 at 08:15:49AM +0100, Alexander Steffen wrote:
> The scripts are effectively using modprobe/rmmod/etc. and those need the
> name. modprobe can be fixed by defining an alias, but this does not work for
> rmmod. Many other things also depend on the name, e.g. module blacklisting
> or the output of lsmod, where people might now get confused by the
> difference between "tpm_tis_spi_mod" and "tpm_tis_i2c". Also, there are many
> tutorials out there, that explicitly tell users to run something like
> "modprobe tpm_tis_spi", which won't work anymore now.
>
> So, if there is a good reason to break compatibility, I'm fine with that.
> But in this case, isn't there some way to achieve the desired functionality
> without changing the name? Even if it is a little more complex than the
> three-line change above, that would probably be worth it.
Nope, you're right. I'll work out a fix for this and
add you as reported-by.
/Jarkko
next prev parent reply other threads:[~2020-02-04 12:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:32 [PATCH v7 0/6] tpm: Add driver for cr50 Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 1/6] dt-bindings: tpm: document properties " Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 2/6] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 3/6] tpm: tpm_tis_spi: Introduce a flow control callback Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 4/6] tpm: tpm_tis_spi: Support cr50 devices Stephen Boyd
2019-10-06 22:32 ` Jarkko Sakkinen
2020-02-03 9:13 ` Alexander Steffen
2020-02-04 0:37 ` Stephen Boyd
2020-02-04 7:15 ` Alexander Steffen
2020-02-04 12:00 ` Jarkko Sakkinen [this message]
2019-09-20 18:32 ` [PATCH v7 5/6] tpm: tpm_tis_spi: Cleanup includes Stephen Boyd
2019-10-06 22:34 ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 6/6] tpm: tpm_tis_spi: Drop THIS_MODULE usage from driver struct Stephen Boyd
2019-10-06 22:35 ` Jarkko Sakkinen
2019-10-06 22:39 ` [PATCH v7 0/6] tpm: Add driver for cr50 Jarkko Sakkinen
2019-10-11 7:50 ` Heiko Stübner
2019-10-14 19:56 ` Jarkko Sakkinen
2019-10-15 20:23 ` Heiko Stuebner
2019-10-16 15:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204120048.GA28552@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.