From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D52C2D0B1 for ; Tue, 4 Feb 2020 13:32:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C5B820661 for ; Tue, 4 Feb 2020 13:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C5B820661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B9636EEA9; Tue, 4 Feb 2020 13:32:42 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2ECC6EEA9; Tue, 4 Feb 2020 13:32:41 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 05:32:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,401,1574150400"; d="scan'208";a="263836507" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga002.fm.intel.com with SMTP; 04 Feb 2020 05:32:13 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 04 Feb 2020 15:32:12 +0200 Date: Tue, 4 Feb 2020 15:32:12 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Shankar, Uma" Subject: Re: [Intel-gfx] [PATCH 6/8] drm/edid: Add a FIXME about DispID CEA data block revision Message-ID: <20200204133212.GI13686@intel.com> References: <20200124200231.10517-1-ville.syrjala@linux.intel.com> <20200124200231.10517-6-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , Andres Rodriguez , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 03, 2020 at 08:15:51PM +0000, Shankar, Uma wrote: > = > = > > -----Original Message----- > > From: Intel-gfx On Behalf Of = Ville Syrjala > > Sent: Saturday, January 25, 2020 1:32 AM > > To: dri-devel@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org; Andres Rodriguez > > Subject: [Intel-gfx] [PATCH 6/8] drm/edid: Add a FIXME about DispID CEA= data block > > revision > > = > > From: Ville Syrj=E4l=E4 > > = > > I don't understand what the DispID CEA data block revision means. The s= pec doesn't > > say. I guess some DispID must have a value of >=3D 3 in there or else w= e generally > > wouldn't even parse the CEA data blocks. Or does all this code actually= not do > > anything? > = > This signifies the CTA extension revision (byte 1 of the block). As per t= he spec, seems like > Version 1 is legacy and 2 is deprecated. So version >=3D3 is checked here. > Refer section 7.3 of CTA-861-G The confusion is about the revision field in the DispID CTA block, not in the CTA extension block. > = > > Cc: Andres Rodriguez > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/drm_edid.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > = > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c in= dex > > 0369a54e3d32..fd9b724067a7 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -3977,6 +3977,13 @@ cea_db_tag(const u8 *db) static int cea_revisi= on(const > > u8 *cea) { > > + /* > > + * FIXME is this correct for the DispID variant? > > + * The DispID spec doesn't really specify whether > > + * this is the revision of the CEA extension or > > + * the DispID CEA data block. And the only value > > + * given as an example is 0. > > + */ > > return cea[1]; > > } > > = > > -- > > 2.24.1 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E581C2D0B1 for ; Tue, 4 Feb 2020 13:32:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFC5020661 for ; Tue, 4 Feb 2020 13:32:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFC5020661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33FC56EEAB; Tue, 4 Feb 2020 13:32:43 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2ECC6EEA9; Tue, 4 Feb 2020 13:32:41 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 05:32:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,401,1574150400"; d="scan'208";a="263836507" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga002.fm.intel.com with SMTP; 04 Feb 2020 05:32:13 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 04 Feb 2020 15:32:12 +0200 Date: Tue, 4 Feb 2020 15:32:12 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Shankar, Uma" Message-ID: <20200204133212.GI13686@intel.com> References: <20200124200231.10517-1-ville.syrjala@linux.intel.com> <20200124200231.10517-6-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 6/8] drm/edid: Add a FIXME about DispID CEA data block revision X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , Andres Rodriguez , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 03, 2020 at 08:15:51PM +0000, Shankar, Uma wrote: > = > = > > -----Original Message----- > > From: Intel-gfx On Behalf Of = Ville Syrjala > > Sent: Saturday, January 25, 2020 1:32 AM > > To: dri-devel@lists.freedesktop.org > > Cc: intel-gfx@lists.freedesktop.org; Andres Rodriguez > > Subject: [Intel-gfx] [PATCH 6/8] drm/edid: Add a FIXME about DispID CEA= data block > > revision > > = > > From: Ville Syrj=E4l=E4 > > = > > I don't understand what the DispID CEA data block revision means. The s= pec doesn't > > say. I guess some DispID must have a value of >=3D 3 in there or else w= e generally > > wouldn't even parse the CEA data blocks. Or does all this code actually= not do > > anything? > = > This signifies the CTA extension revision (byte 1 of the block). As per t= he spec, seems like > Version 1 is legacy and 2 is deprecated. So version >=3D3 is checked here. > Refer section 7.3 of CTA-861-G The confusion is about the revision field in the DispID CTA block, not in the CTA extension block. > = > > Cc: Andres Rodriguez > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/drm_edid.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > = > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c in= dex > > 0369a54e3d32..fd9b724067a7 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -3977,6 +3977,13 @@ cea_db_tag(const u8 *db) static int cea_revisi= on(const > > u8 *cea) { > > + /* > > + * FIXME is this correct for the DispID variant? > > + * The DispID spec doesn't really specify whether > > + * this is the revision of the CEA extension or > > + * the DispID CEA data block. And the only value > > + * given as an example is 0. > > + */ > > return cea[1]; > > } > > = > > -- > > 2.24.1 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx