From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5955BC33CA1 for ; Wed, 5 Feb 2020 08:53:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 360EC2082E for ; Wed, 5 Feb 2020 08:53:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 360EC2082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 574FB6F4D4; Wed, 5 Feb 2020 08:52:55 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E6CD6E841 for ; Tue, 4 Feb 2020 14:37:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: alyssa) with ESMTPSA id 84EC7283BC0 Date: Tue, 4 Feb 2020 09:37:32 -0500 From: Alyssa Rosenzweig To: Boris Brezillon Subject: Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler Message-ID: <20200204143732.GA4525@kevin> References: <20200204143504.135388-1-boris.brezillon@collabora.com> <20200204143504.135388-2-boris.brezillon@collabora.com> MIME-Version: 1.0 In-Reply-To: <20200204143504.135388-2-boris.brezillon@collabora.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Wed, 05 Feb 2020 08:52:53 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Steven Price , Icecream95 , dri-devel@lists.freedesktop.org, Robin Murphy Content-Type: multipart/mixed; boundary="===============0606064272==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0606064272== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patch 2 is `Reviewed-by: Alyssa Rosenzweig ` On Tue, Feb 04, 2020 at 03:35:04PM +0100, Boris Brezillon wrote: > ->job_run() can return an ERR_PTR() if somethings fails. Let's > propagate the error returned by panfrost_fence_create() instead of > returning NULL. >=20 > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/pa= nfrost/panfrost_job.c > index b0716e49eeca..242147b36d8e 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -349,7 +349,7 @@ static struct dma_fence *panfrost_job_run(struct drm_= sched_job *sched_job) > =20 > fence =3D panfrost_fence_create(pfdev, slot); > if (IS_ERR(fence)) > - return NULL; > + return fence; > =20 > if (job->done_fence) > dma_fence_put(job->done_fence); > --=20 > 2.24.1 >=20 --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQ17gm7CvANAdqvY4/v5QWgr1WA0FAl45gaUACgkQ/v5QWgr1 WA3Z6A//Z7IvPOqQSlkCWq1gl3iJeDlUXRn3zEAtvHtixUgkz5Vv8vYGbdXkGjvd crlg4WhL3vmmbtMcNDpXp4JXMCSjwa6QLMNEaJh8XHWsqiqdhzhj2Z0b0sSXoRov n5mA1nTDdC4xS3Ji8CuE4+L1pGgSu3IKbcx9NgF7nTclJYeC462CZVaqzXrPrp3/ mvhx0h0TfQw06I0GWFUrMcGFz8W3kKey5XeWiArgQIr/vE//flp4c/HZTKglBdRE DKwn09Kq7PO6oMJdPewkeOixLOTskb0Opow+IiiT6ts9VlkMsccPDB4kwKVaJHa/ GSON0d4eVARcXMd1R9Fj8FN9u3vOVc+hbO3fU7H6SYnKA1WHX8kmKzf+BRtAaiCf VQ5yLrvw0xJ1+GplIGDM8bfZfuX9uvnFqSzGDyGorcbqjC9/y7rHtfbZlCzjgpG+ g2Q6jInwaYIgyQeTEX98caHLuEj5j/D2mUB8vTriudK4+8BNTUsCI6OmnGEodFXc PNL+NzfoY1V/7QhoYoVSQ9lDLGsYtrr32r0x1fIewZTSyyKToFYoiRcVeQPFeAqm vnaE77vXhGFAjmM7jgXL2CxmDLF6+uu1NuIOFT7VX2YN5byCVZYIF0wjF7F8hpXY r3p9yNyFhtt+m//QdZ0Ma0GJbbYVzVt7QwUqV0kX1wfSZFYQ2m4= =1Vul -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd-- --===============0606064272== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0606064272==--