All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: Honggang LI <honli@redhat.com>,
	"Goldman, Adam" <adam.goldman@intel.com>,
	linux-rdma@vger.kernel.org, mike.marciniszyn@intel.com,
	dennis.dalessandro@intel.com
Subject: Re: [PATCH] kernel-boot: Do not perform device rename on OPA devices
Date: Tue, 4 Feb 2020 17:51:42 +0200	[thread overview]
Message-ID: <20200204155142.GZ414821@unreal> (raw)
In-Reply-To: <984452af-7c41-cad0-be9c-ed74d269b89d@amazon.com>

On Tue, Feb 04, 2020 at 04:59:47PM +0200, Gal Pressman wrote:
> On 04/02/2020 16:14, Honggang LI wrote:
> >> +ACTION=="add", SUBSYSTEM=="infiniband", KERNEL!="hfi1*", PROGRAM="rdma_rename %k NAME_FALLBACK"
> >
> > Maybe, we should not enable device rename as default for all RDMA
> > hardware. Leave it to system admin to apply rename or not.
> >
> > We are observing issues with RDMA device renaming too.
>
> +1, we're experiencing similar issues as well.
> If not disabling by default, we need an easy way to disable the feature.

There is super easy way to disable it.

Copy 60-rdma-persistent-naming.rules to /etc/udev/rules.d folder and
change default to anything you want.

This file is not overwritten during rdma-core upgrades and will keep
whatever behavior you need.

Thanks

  reply	other threads:[~2020-02-04 15:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 13:55 [PATCH] kernel-boot: Do not perform device rename on OPA devices Goldman, Adam
2020-02-04 14:14 ` Honggang LI
2020-02-04 14:53   ` Leon Romanovsky
2020-02-04 14:59   ` Gal Pressman
2020-02-04 15:51     ` Leon Romanovsky [this message]
2020-02-04 14:56 ` Leon Romanovsky
2020-02-04 15:26   ` Dennis Dalessandro
2020-02-04 15:53     ` Leon Romanovsky
2020-02-05 19:12 ` Jason Gunthorpe
2020-02-05 19:22   ` Leon Romanovsky
2020-02-05 20:35   ` Dennis Dalessandro
2020-02-05 20:54     ` Jason Gunthorpe
2020-02-05 21:59       ` Dennis Dalessandro
2020-02-06 13:52         ` Jason Gunthorpe
2020-02-06 17:51           ` Dennis Dalessandro
2020-02-06 18:22             ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204155142.GZ414821@unreal \
    --to=leon@kernel.org \
    --cc=adam.goldman@intel.com \
    --cc=dennis.dalessandro@intel.com \
    --cc=galpress@amazon.com \
    --cc=honli@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.