All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Vitaliy Mysak <vitaliy.mysak@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Zhihong Wang <zhihong.wang@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_vhost: do not treat empty socket message as error
Date: Wed, 5 Feb 2020 13:08:15 +0800	[thread overview]
Message-ID: <20200205050814.GA434648@___> (raw)
In-Reply-To: <20200130080540.7616-1-vitaliy.mysak@intel.com>


[PATCH] rte_vhost: do not treat empty socket message as error

s/rte_vhost:/vhost:/

On Thu, Jan 30, 2020 at 09:05:39AM +0100, Vitaliy Mysak wrote:
> According to recvmsg() specification, 0 is a valid
> return code when client is disconnecting.
> Therefore, it should not be reported as error, unless there
> are other dependencies that require message to not be empty.
> But there are none, since the next immediate caller of recvmsg()
> reports "vhost peer closed" info (not error) when message is empty.
> 
> This patch changes return code check for recvmsg() so that
> misleading error message is not printed when the code is 0.

Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: stable@dpdk.org

> 
> Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com>
> ---
>  lib/librte_vhost/socket.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks,
Tiwei

  reply	other threads:[~2020-02-05  5:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30  8:05 [dpdk-dev] [PATCH] rte_vhost: do not treat empty socket message as error Vitaliy Mysak
2020-02-05  5:08 ` Tiwei Bie [this message]
2020-02-05  9:47 ` Maxime Coquelin
  -- strict thread matches above, loose matches on Subject: below --
2020-01-29  9:22 Vitaliy Mysak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205050814.GA434648@___ \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=vitaliy.mysak@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.