From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM
Date: Wed, 5 Feb 2020 11:38:07 +0100 [thread overview]
Message-ID: <20200205113807.04b1c60c@windsurf> (raw)
In-Reply-To: <20190909121525.13935-3-maeva.manuel@nxp.com>
Hello,
On Mon, 9 Sep 2019 12:15:00 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
I have applied, but with some changes. See below.
> -IMX_SC_FIRMWARE_VERSION = 1.0
> +IMX_SC_FIRMWARE_VERSION = 1.1
The bump to 1.2.1 was already done in commit
b74eaecb2232c4d2b717f867218ad731da836cbc, so I dropped this part.
> IMX_SC_FIRMWARE_SITE = $(FREESCALE_IMX_SITE)
> IMX_SC_FIRMWARE_SOURCE = imx-sc-firmware-$(IMX_SC_FIRMWARE_VERSION).bin
>
> @@ -18,10 +18,14 @@ endef
>
> IMX_SC_FIRMWARE_INSTALL_IMAGES = YES
> define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
> - # SCFW firmware is needed when generating imx8-boot-sd.bin which
> - # is done in post-image script.
> - cp $(@D)/mx8qx-mek-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-mek-scfw-tcm.bin
> - cp $(@D)/mx8qx-val-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-val-scfw-tcm.bin
> +# SCFW firmware is needed when generating imx8-boot-sd.bin which
> +# is done in post-image script.
> +
> +# For i.MX8QM support the SCFW needed is mx8qm-mek-scfw-tcm.bin
> +# and mx8qm-val-scfw-tcm.bin
> +# For i.MX8QXP support the SCFW needed is mx8qx-mek-scfw-tcm.bin
> +# and mx8qx-val-scfw-tcm.bin
> +cp $(@D)/*-scfw-tcm.bin $(BINARIES_DIR)/*-scfw-tcm.bin
Code inside commands should be indented with one tab. Also, as pointed
out by Gary, it is preferable to only install what we really need, so I
changed this to:
+# SCFW firmware is needed when generating imx8-boot-sd.bin which is
+# done in post-image script.
+ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y)
define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
- # SCFW firmware is needed when generating imx8-boot-sd.bin which
- # is done in post-image script.
cp $(@D)/mx8qx-mek-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-mek-scfw-tcm.bin
cp $(@D)/mx8qx-val-scfw-tcm.bin $(BINARIES_DIR)/mx8qx-val-scfw-tcm.bin
endef
+else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8),y)
+define IMX_SC_FIRMWARE_INSTALL_IMAGES_CMDS
+ cp $(@D)/mx8qm-*-scfw-tcm.bin $(BINARIES_DIR)/
+endef
+endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-05 10:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 12:14 [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Maeva Manuel
2019-09-09 12:14 ` [Buildroot] [PATCH 2/7] package/freescale-imx: add option " Maeva Manuel
2019-11-08 17:30 ` Gary Bisson
2020-02-05 10:36 ` Thomas Petazzoni
2020-02-05 10:31 ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 3/7] package/freescale-imx/imx-sc-firmware: bump to version 1.1 to support i.MX8QM Maeva Manuel
2019-11-08 17:33 ` Gary Bisson
2020-02-05 10:38 ` Thomas Petazzoni [this message]
2019-09-09 12:15 ` [Buildroot] [PATCH 4/7] package/freescale-imx/imx-sc-firmware: add hash file Maeva Manuel
2019-11-08 17:34 ` Gary Bisson
2020-02-05 10:38 ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 5/7] package/freescale-imx/firmware-imx: Maeva Manuel
2019-09-13 15:44 ` André Hentschel
2020-02-05 10:39 ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 6/7] configs/freescale_imx8qmmek: new defconfig Maeva Manuel
2020-02-05 11:20 ` Thomas Petazzoni
2019-09-09 12:15 ` [Buildroot] [PATCH 7/7] board/freescale/imx8qxpmek: update instructions Maeva Manuel
2020-02-05 11:12 ` Thomas Petazzoni
2020-02-05 10:30 ` [Buildroot] [PATCH 1/7] board/freescale/common/imx: add support for i.MX8QM Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205113807.04b1c60c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.