From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5731EC35254 for ; Wed, 5 Feb 2020 14:22:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33E0020702 for ; Wed, 5 Feb 2020 14:22:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33E0020702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFBA86F5C2; Wed, 5 Feb 2020 14:22:01 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBD686F5C2 for ; Wed, 5 Feb 2020 14:21:59 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8CC352946B1; Wed, 5 Feb 2020 14:21:58 +0000 (GMT) Date: Wed, 5 Feb 2020 15:21:55 +0100 From: Boris Brezillon To: Steven Price Subject: Re: [PATCH 2/2] drm/panfrost: Propagate panfrost_fence_create() errors to the scheduler Message-ID: <20200205152155.2dee52a8@collabora.com> In-Reply-To: <184d57ff-9193-ce08-c248-5c1de801fa6a@arm.com> References: <20200204143504.135388-1-boris.brezillon@collabora.com> <20200204143504.135388-2-boris.brezillon@collabora.com> <184d57ff-9193-ce08-c248-5c1de801fa6a@arm.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Rob Herring , Icecream95 , Alyssa Rosenzweig , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 5 Feb 2020 13:47:55 +0000 Steven Price wrote: > On 04/02/2020 14:35, Boris Brezillon wrote: > > ->job_run() can return an ERR_PTR() if somethings fails. Let's > > propagate the error returned by panfrost_fence_create() instead of > > returning NULL. > > > > Signed-off-by: Boris Brezillon > > In your previous posting[1] you also handled the case where > job->base.s_fence->finished.error is non-zero. Is there a good reason to > drop that? [2] has been applied in the meantime: returning NULL now preserves the finished.error field. > > [1] https://patchwork.kernel.org/patch/11267153/ [2]https://patchwork.kernel.org/patch/11218399/ > > But this change on its own stands, so: > > Reviewed-by: Steven Price > > > --- > > drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > > index b0716e49eeca..242147b36d8e 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > > @@ -349,7 +349,7 @@ static struct dma_fence *panfrost_job_run(struct drm_sched_job *sched_job) > > > > fence = panfrost_fence_create(pfdev, slot); > > if (IS_ERR(fence)) > > - return NULL; > > + return fence; > > > > if (job->done_fence) > > dma_fence_put(job->done_fence); > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel