From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC6BC35247 for ; Wed, 5 Feb 2020 17:12:49 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 900B2217BA for ; Wed, 5 Feb 2020 17:12:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gmwLCuBR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 900B2217BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3086E4A418; Wed, 5 Feb 2020 12:12:49 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gu1VrkXn+dX0; Wed, 5 Feb 2020 12:12:48 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 247D14A578; Wed, 5 Feb 2020 12:12:48 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AD36C4A52E for ; Wed, 5 Feb 2020 10:47:20 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hi5wUZZc1Knq for ; Wed, 5 Feb 2020 10:47:19 -0500 (EST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AE3164A418 for ; Wed, 5 Feb 2020 10:47:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580917639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oFsmPcTmpKK74hHiUMCVVaDBnbXf1XdgHTJLxT7DmFI=; b=gmwLCuBRA2tD1K84xlyOZUMTZIKbncjBcUR2asJ7e2WIJ2KdAzgc+6azV75l+ZFrhBRJ2q BR9aik8zQhHFtJvIua+8gDedIycUR06/cdwREx2Xni2BDSJevzzGMHiguonneF1yP8bIp0 EVotCPSNiYxTf6cIVYsmyNzN4carqUw= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-HNHn0V4LPviou4l41dYIdg-1; Wed, 05 Feb 2020 10:47:02 -0500 Received: by mail-qk1-f198.google.com with SMTP id a6so1547283qkl.7 for ; Wed, 05 Feb 2020 07:47:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7nlVGeHpp9SUIG8wrpMffu8Rdrv8R00fvHa/mYaOU0g=; b=RDE2kXGFZtFrHd8+2vYzfiUETcnYaNJM/vtM/yUKzAvc2tESUyPHVnGqQzL/gi3uvZ +cqvsBOOUtch0DpUQ135MEt32mehCuhvAvzVQcAZLojQEDpbyIsjZNN5aEMPzG0oDObI 56WE18xsJqdr7aWgJ874JTef+50gk6Jw92hclJ8BDTwCBch8c8ojXCSO65BVHBUUcsiM 42BODOxLVdhDqiAfLRgKeOU9yLPm+GkIFNwOiALXDc1rP1u2V1Htb7RZwgCg18FZJL2z /E6WN7aDjXJYDvKkByXctLBJpenu7705/wvxQmwNLMxasgUfUSGxMFyzLBkcvoWl28Qo eZgA== X-Gm-Message-State: APjAAAUuDO8PgHqv53U8x4aeH9ssH0ZDLI+7VxMbXBJlYQCaq1Zfxd2E M7Pvz/HWWg2/7SUYeiVbyQA5HScxoebhcHwmq42xXFhkQ76kiXcwG3CzhdSoo7wivx1qr3MK/xy 5N9+1c2/yRBqaBU3G0zgCWthl X-Received: by 2002:ac8:43c1:: with SMTP id w1mr33141980qtn.156.1580917622333; Wed, 05 Feb 2020 07:47:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyR3gtl04B5/ivAmSsxK+0IHBbTQlobHqHrH3aYmEjs8G/RJ/srgXoWDoXwLSsFiE3ITI4dCw== X-Received: by 2002:ac8:43c1:: with SMTP id w1mr33141949qtn.156.1580917622035; Wed, 05 Feb 2020 07:47:02 -0800 (PST) Received: from dev.jcline.org ([136.56.87.133]) by smtp.gmail.com with ESMTPSA id h7sm6394qke.30.2020.02.05.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 07:47:01 -0800 (PST) Date: Wed, 5 Feb 2020 10:46:59 -0500 From: Jeremy Cline To: Marc Zyngier Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h Message-ID: <20200205154659.GA83976@dev.jcline.org> References: <20200205134146.82678-1-jcline@redhat.com> MIME-Version: 1.0 In-Reply-To: X-MC-Unique: HNHn0V4LPviou4l41dYIdg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Mailman-Approved-At: Wed, 05 Feb 2020 12:12:47 -0500 Cc: linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Feb 05, 2020 at 03:18:05PM +0000, Marc Zyngier wrote: > On 2020-02-05 13:41, Jeremy Cline wrote: > > Fedora kernel builds on armv7hl began failing recently because > > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in > > trace.h. Add the missing include. > > > > Signed-off-by: Jeremy Cline > > --- > > > > I've not dug very deeply into what exactly changed between commit > > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907, > > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO > > handling"). > > > > Fedora's build config is available at > > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config > > This config doesn't have KVM enabled. > Whoops, I did indeed mean https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-lpae-fedora.config. Sorry about that. > > > > virt/kvm/arm/trace.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h > > index 204d210d01c2..cc94ccc68821 100644 > > --- a/virt/kvm/arm/trace.h > > +++ b/virt/kvm/arm/trace.h > > @@ -4,6 +4,7 @@ > > > > #include > > #include > > +#include > > > > #undef TRACE_SYSTEM > > #define TRACE_SYSTEM kvm > > After enabling KVM in the above config (which requires LPAE), I've managed > to reproduce > the problem. > > Fix now queued, thanks. > Thanks! - Jeremy _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6287AC35247 for ; Wed, 5 Feb 2020 15:47:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 343EA218AC for ; Wed, 5 Feb 2020 15:47:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f6G19mjr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K1gEwpxe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 343EA218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lzcttCqKMvQC7WNmP6vTWyqatVHpMl5j0AEVPIkx6JA=; b=f6G19mjrGO3vfG fD5nbFKFrvv+03ifRh0olHQVZ3H9n4I3HwcJoqcAz9TavE+mqg84SKefRf0UkPJhJO50owg3e7HVh 0EjEFoUpBfu4tT2UAl14MCzUSeE3qVoETpOXXU1WETpNRBOMa67iV+b9HgEWUcYOkj05WzPLtOZYn W5TXzd0dCf9WcZi4s2GpsKBv5L8F/3wWwSm2N/EOF0SwyRhAkrLXgaPvCWOiTEeXch2r0JeaTELdl cn8omgNC85YRoTtlL+hnmZqP1Z28BnHOJm62emU+G07ckdwxfyqsreLk9WVRty6E4IZP30UyJHGZ1 abQCoa1H4Ln67cpcLuKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izMtg-0004G1-Su; Wed, 05 Feb 2020 15:47:24 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izMtd-0004FX-UE for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 15:47:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580917638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oFsmPcTmpKK74hHiUMCVVaDBnbXf1XdgHTJLxT7DmFI=; b=K1gEwpxekmj1HubD8iHTJ/dIENFoKlQPcXh8jkIJLvcB/RxmHFbnaNb6tFksHvgsD63EOo fUTCPQpopSzMgJ+ay7Z95dULqmpz7dv7Ea/Unq+xbarA681/gD1oeAC/HTjBJuzKiBnDEh rq6UWtEBm6JMYrzBImFvXLNIj8aFMEM= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-K9xVjS_ZM9GD4Kk_XdsUsg-1; Wed, 05 Feb 2020 10:47:02 -0500 Received: by mail-qk1-f198.google.com with SMTP id c206so1540489qkg.6 for ; Wed, 05 Feb 2020 07:47:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7nlVGeHpp9SUIG8wrpMffu8Rdrv8R00fvHa/mYaOU0g=; b=FIas6Dlh7/1T58OyxGW7KfD5rOiTg1z/e1Y+Y5rOzfrCSB51BZg1Qg54Il+E3m5xxf zNKz+62f9qTtf/dIkAw6ReCwjWgk358LAwbEWHPKwQ7VuPKAUK0tzsN/3IWZ/BrqzzbH xYkL+yH4jP1rgGwEoKDx7oZ1eTnzhQQK47BgshoaOtMq5oYs7j9H8pXNAl4Uku4k3jVu 9dOfxTVh8sUNQ9K3do+/tK6EvXhkeeIlP85EF2tOhVZixIpYEmPrKhR8Jc8vDrVHbW2Z LcvvHC1q1bX1NZNW72htcbseb6An8ABL+H7YvLMGjeowjeSeiRtkmN1P6aXHVfhJnqoi AqzA== X-Gm-Message-State: APjAAAUnJqxuFdPh12MUmlkL1Z/41tjD/mjB1hwj+INrDFj/ItZjc78U JYm7Z9L3vfiErq2a3/cAeBOmyv+Mm6CO5dj7/KxdQLr6TEHDfyMctBlS5H/JP+gzQz8AuTRcSkA 3mQR6gucVp0IgHOkgjfAiPCn29GHOigt7Ens= X-Received: by 2002:ac8:43c1:: with SMTP id w1mr33141984qtn.156.1580917622333; Wed, 05 Feb 2020 07:47:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyR3gtl04B5/ivAmSsxK+0IHBbTQlobHqHrH3aYmEjs8G/RJ/srgXoWDoXwLSsFiE3ITI4dCw== X-Received: by 2002:ac8:43c1:: with SMTP id w1mr33141949qtn.156.1580917622035; Wed, 05 Feb 2020 07:47:02 -0800 (PST) Received: from dev.jcline.org ([136.56.87.133]) by smtp.gmail.com with ESMTPSA id h7sm6394qke.30.2020.02.05.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 07:47:01 -0800 (PST) Date: Wed, 5 Feb 2020 10:46:59 -0500 From: Jeremy Cline To: Marc Zyngier Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h Message-ID: <20200205154659.GA83976@dev.jcline.org> References: <20200205134146.82678-1-jcline@redhat.com> MIME-Version: 1.0 In-Reply-To: X-MC-Unique: K9xVjS_ZM9GD4Kk_XdsUsg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_074722_048066_EDAE89A3 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , linux-kernel@vger.kernel.org, James Morse , Julien Thierry , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 05, 2020 at 03:18:05PM +0000, Marc Zyngier wrote: > On 2020-02-05 13:41, Jeremy Cline wrote: > > Fedora kernel builds on armv7hl began failing recently because > > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in > > trace.h. Add the missing include. > > > > Signed-off-by: Jeremy Cline > > --- > > > > I've not dug very deeply into what exactly changed between commit > > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907, > > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO > > handling"). > > > > Fedora's build config is available at > > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config > > This config doesn't have KVM enabled. > Whoops, I did indeed mean https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-lpae-fedora.config. Sorry about that. > > > > virt/kvm/arm/trace.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h > > index 204d210d01c2..cc94ccc68821 100644 > > --- a/virt/kvm/arm/trace.h > > +++ b/virt/kvm/arm/trace.h > > @@ -4,6 +4,7 @@ > > > > #include > > #include > > +#include > > > > #undef TRACE_SYSTEM > > #define TRACE_SYSTEM kvm > > After enabling KVM in the above config (which requires LPAE), I've managed > to reproduce > the problem. > > Fix now queued, thanks. > Thanks! - Jeremy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB473C35247 for ; Wed, 5 Feb 2020 15:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBDF920730 for ; Wed, 5 Feb 2020 15:47:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HJyG7aCp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727540AbgBEPrZ (ORCPT ); Wed, 5 Feb 2020 10:47:25 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22734 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727029AbgBEPrY (ORCPT ); Wed, 5 Feb 2020 10:47:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580917643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7nlVGeHpp9SUIG8wrpMffu8Rdrv8R00fvHa/mYaOU0g=; b=HJyG7aCp2iBoUkNtwJyBEDTzSvSnjuvIGd8ig0egruScMNoWmyDrRE0FuyrfVYTXtKtbDN bFdQAW1fCn/lLYO8ScUX0NEuOhH73eRK2XD0hSFsJScUat6xz3f+pA+tEqNb/7lJMm30ud xsGknoRvns4NEhzseoPhUhoX6Y9fYIA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-ed22qHClMi2JY2IdfJulFw-1; Wed, 05 Feb 2020 10:47:02 -0500 X-MC-Unique: ed22qHClMi2JY2IdfJulFw-1 Received: by mail-qv1-f69.google.com with SMTP id cn2so1747609qvb.1 for ; Wed, 05 Feb 2020 07:47:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7nlVGeHpp9SUIG8wrpMffu8Rdrv8R00fvHa/mYaOU0g=; b=tl2Fe8O2sGkviH3UUe8AY7z4psKVP4Kmg68D11EcoRdyCGxvuL0y5KzLnb7lCaSM4u 6JkfSnnBGx/bM6nyp2feONxi/quPaYKbyLfYhdRj0mK4Qkxy4qAmw7VpsgKnoIt+oGwT 7rHyMQ9sxkLWtRG+YnquB/6O3c8R9FbeOT+U+otvmbKT1Urmf7aOWXO6DlZJ2EGzhraK 65n841EVaeDcpF06+ezFIXRhI9Y1qmj2AmGx7ke9VNHNL5vJnt02Ni7l1TkI7B48avx+ J/kdOTj7jmDdFHivX8yaMToZyXMDmtNDoZFunJBmTpG77YKXFlAT0srTq5cMg6/vc1A6 Fi2g== X-Gm-Message-State: APjAAAVColv12pbn84S6VYostbk7qVSWW4BbA+cB6itMn3bZ6QAzvMVH y52VLZ8kGe/bhdObfpO7snyTcyy+hD3SdMk/lil6Cfv/Jvy3BlTZ/cgACt/vrd+NZtCBb2Slv9Y /M3P1NfTfCx3Y8LTp0XpSEpjZ X-Received: by 2002:ac8:43c1:: with SMTP id w1mr33141986qtn.156.1580917622335; Wed, 05 Feb 2020 07:47:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyR3gtl04B5/ivAmSsxK+0IHBbTQlobHqHrH3aYmEjs8G/RJ/srgXoWDoXwLSsFiE3ITI4dCw== X-Received: by 2002:ac8:43c1:: with SMTP id w1mr33141949qtn.156.1580917622035; Wed, 05 Feb 2020 07:47:02 -0800 (PST) Received: from dev.jcline.org ([136.56.87.133]) by smtp.gmail.com with ESMTPSA id h7sm6394qke.30.2020.02.05.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2020 07:47:01 -0800 (PST) Date: Wed, 5 Feb 2020 10:46:59 -0500 From: Jeremy Cline To: Marc Zyngier Cc: James Morse , Julien Thierry , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h Message-ID: <20200205154659.GA83976@dev.jcline.org> References: <20200205134146.82678-1-jcline@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 05, 2020 at 03:18:05PM +0000, Marc Zyngier wrote: > On 2020-02-05 13:41, Jeremy Cline wrote: > > Fedora kernel builds on armv7hl began failing recently because > > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in > > trace.h. Add the missing include. > > > > Signed-off-by: Jeremy Cline > > --- > > > > I've not dug very deeply into what exactly changed between commit > > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907, > > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO > > handling"). > > > > Fedora's build config is available at > > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config > > This config doesn't have KVM enabled. > Whoops, I did indeed mean https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-lpae-fedora.config. Sorry about that. > > > > virt/kvm/arm/trace.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h > > index 204d210d01c2..cc94ccc68821 100644 > > --- a/virt/kvm/arm/trace.h > > +++ b/virt/kvm/arm/trace.h > > @@ -4,6 +4,7 @@ > > > > #include > > #include > > +#include > > > > #undef TRACE_SYSTEM > > #define TRACE_SYSTEM kvm > > After enabling KVM in the above config (which requires LPAE), I've managed > to reproduce > the problem. > > Fix now queued, thanks. > Thanks! - Jeremy