All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <billodo@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH] xfs: xchk_xattr_listent() fix context->seen_enough to -ECANCELED
Date: Wed,  5 Feb 2020 13:04:55 -0600	[thread overview]
Message-ID: <20200205190455.1834330-1-billodo@redhat.com> (raw)

Commit e7ee96dfb8c (xfs: remove all *_ITER_ABORT values)
replaced *_ITER_ABORT values with -ECANCELED. The replacement
in the case of scrub/attr.c xchk_xattr_listent() is in
error (context->seen_enough = 1;). Instead of '1', use
the intended -ECANCELED.

Fixes: e7ee96dfb8c (xfs: remove all *_ITER_ABORT values)
Signed-off-by: Bill O'Donnell <billodo@redhat.com>
---
 fs/xfs/scrub/attr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/scrub/attr.c b/fs/xfs/scrub/attr.c
index d9f0dd444b80..5d0590f78973 100644
--- a/fs/xfs/scrub/attr.c
+++ b/fs/xfs/scrub/attr.c
@@ -171,7 +171,7 @@ xchk_xattr_listent(
 					     args.blkno);
 fail_xref:
 	if (sx->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)
-		context->seen_enough = 1;
+		context->seen_enough = -ECANCELED;
 	return;
 }
 
-- 
2.24.1


             reply	other threads:[~2020-02-05 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 19:04 Bill O'Donnell [this message]
2020-02-06 23:07 ` [PATCH] xfs: xchk_xattr_listent() fix context->seen_enough to -ECANCELED Darrick J. Wong
2020-02-06 23:51   ` Bill O'Donnell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205190455.1834330-1-billodo@redhat.com \
    --to=billodo@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.