From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3AF8C352A1 for ; Wed, 5 Feb 2020 19:28:06 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96D2220720 for ; Wed, 5 Feb 2020 19:28:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UZeijFCY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96D2220720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DB88410FC33F5; Wed, 5 Feb 2020 11:31:23 -0800 (PST) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+a2b935cbc3c12af13a1b+6009+infradead.org+hch@bombadil.srs.infradead.org; receiver= Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C7E6410FC33EF for ; Wed, 5 Feb 2020 11:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QABBpGTAcCBsCMraQQqa4epo9mEJxyTHyWGoCeCqXq4=; b=UZeijFCYL90Ju1tY93FKw+Ovyk zxCkS0hA6/VyUT88ABiVyLEvL2YmCfkBb+A5F9s0mC8s/ttjcpKCfkawMH5vbl1cVbvyllyb9Vray Qwx98snsC4nwoQ5uqWqpLG8lnEtICzQlig426NvljpsdDTZQdxM+8yA3CUKBDNloVPOLA+KWNl3gY pdTHrBK7bfxsxTOpOGv7f+mlSVW8M+AsZNqpHtb+Sm+AQQSgJ6Z8JKOPjNysr0WkZweH/5Q8c8rJ8 9KXmVJsMkUkhbLDV0rPwbmOXJ95a3EArWndpMQa6OY8loopDTn0OYvPKz6m+2I4y/7wPWkESncpiB u/TaB2UQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1izQLC-0000eg-2S; Wed, 05 Feb 2020 19:28:02 +0000 Date: Wed, 5 Feb 2020 11:28:02 -0800 From: Christoph Hellwig To: Jeff Moyer Subject: Re: [patch] dax: pass NOWAIT flag to iomap_apply Message-ID: <20200205192802.GA2425@infradead.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Message-ID-Hash: QCFVRD2XSEQHCCT3W2PWRRZRX6PFB67C X-Message-ID-Hash: QCFVRD2XSEQHCCT3W2PWRRZRX6PFB67C X-MailFrom: BATV+a2b935cbc3c12af13a1b+6009+infradead.org+hch@bombadil.srs.infradead.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, willy@infradead.org, jack@suse.cz X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Feb 05, 2020 at 02:15:58PM -0500, Jeff Moyer wrote: > fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o > dax". The reason is that the initial pwrite to an empty file with the > RWF_NOWAIT flag set does not return -EAGAIN. It turns out that > dax_iomap_rw doesn't pass that flag through to iomap_apply. > > With this patch applied, generic/471 passes for me. > > Signed-off-by: Jeff Moyer Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0626C35247 for ; Wed, 5 Feb 2020 19:28:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5DBA217BA for ; Wed, 5 Feb 2020 19:28:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UZeijFCY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbgBET2F (ORCPT ); Wed, 5 Feb 2020 14:28:05 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:53168 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbgBET2F (ORCPT ); Wed, 5 Feb 2020 14:28:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QABBpGTAcCBsCMraQQqa4epo9mEJxyTHyWGoCeCqXq4=; b=UZeijFCYL90Ju1tY93FKw+Ovyk zxCkS0hA6/VyUT88ABiVyLEvL2YmCfkBb+A5F9s0mC8s/ttjcpKCfkawMH5vbl1cVbvyllyb9Vray Qwx98snsC4nwoQ5uqWqpLG8lnEtICzQlig426NvljpsdDTZQdxM+8yA3CUKBDNloVPOLA+KWNl3gY pdTHrBK7bfxsxTOpOGv7f+mlSVW8M+AsZNqpHtb+Sm+AQQSgJ6Z8JKOPjNysr0WkZweH/5Q8c8rJ8 9KXmVJsMkUkhbLDV0rPwbmOXJ95a3EArWndpMQa6OY8loopDTn0OYvPKz6m+2I4y/7wPWkESncpiB u/TaB2UQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1izQLC-0000eg-2S; Wed, 05 Feb 2020 19:28:02 +0000 Date: Wed, 5 Feb 2020 11:28:02 -0800 From: Christoph Hellwig To: Jeff Moyer Cc: dan.j.williams@intel.com, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, willy@infradead.org, jack@suse.cz Subject: Re: [patch] dax: pass NOWAIT flag to iomap_apply Message-ID: <20200205192802.GA2425@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 05, 2020 at 02:15:58PM -0500, Jeff Moyer wrote: > fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o > dax". The reason is that the initial pwrite to an empty file with the > RWF_NOWAIT flag set does not return -EAGAIN. It turns out that > dax_iomap_rw doesn't pass that flag through to iomap_apply. > > With this patch applied, generic/471 passes for me. > > Signed-off-by: Jeff Moyer Looks good, Reviewed-by: Christoph Hellwig