All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/4] tests/kms_frontbuffer_tracking: Enable positive test on linear tiling
Date: Thu, 6 Feb 2020 13:58:10 +0200	[thread overview]
Message-ID: <20200206115810.GP13686@intel.com> (raw)
In-Reply-To: <20200206020944.338033-3-jose.souza@intel.com>

On Wed, Feb 05, 2020 at 06:09:43PM -0800, José Roberto de Souza wrote:
> i915 is making fences not mandatory to enable FBC in newer platforms.
> As BSpec do not have restrictions against tiling formats to enable
> FBC it will be possible to enable FBC with linear tiling, so lets test
> it.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index d5a64a4d..2fda9ab7 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -2161,11 +2161,15 @@ static void format_draw_subtest(const struct test_mode *t)
>  
>  static bool tiling_is_valid(int feature_flags, enum tile_type tile)
>  {
> +	int devid = intel_get_drm_devid(drm.fd);
> +
>  	if (!(feature_flags & FEATURE_FBC))
>  		return true;
>  
>  	switch (tile) {
>  	case TILE_LINEAR:
> +		if (AT_LEAST_GEN(devid, 11))

gen9+ IIRC

> +			return true;
>  		return false;
>  	case TILE_X:
>  	case TILE_Y:
> -- 
> 2.25.0

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-02-06 11:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06  2:09 [igt-dev] [PATCH i-g-t 1/4] tests/kms_frontbuffer_tracking: Add tiling to test_mode José Roberto de Souza
2020-02-06  2:09 ` [igt-dev] [PATCH i-g-t 2/4] tests/kms_frontbuffer_tracking: Improve tiling test coverage José Roberto de Souza
2020-02-06 11:57   ` Ville Syrjälä
2020-03-10 23:59     ` Souza, Jose
2020-02-06 12:00   ` Ville Syrjälä
2020-03-11  0:00     ` Souza, Jose
2020-02-06  2:09 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_frontbuffer_tracking: Enable positive test on linear tiling José Roberto de Souza
2020-02-06 11:58   ` Ville Syrjälä [this message]
2020-02-06  2:09 ` [igt-dev] [PATCH i-g-t 4/4] DO_NOT_MERGE: Revert "tests/kms_frontbuffer_tracking: Enable positive test on linear tiling" José Roberto de Souza
2020-02-06  2:59 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_frontbuffer_tracking: Add tiling to test_mode Patchwork
2020-02-06 11:53 ` [igt-dev] [PATCH i-g-t 1/4] " Ville Syrjälä
2020-03-10 23:54   ` Souza, Jose
2020-02-06 15:58 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [i-g-t,1/4] " Patchwork
2020-02-08 14:56 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206115810.GP13686@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.