From: Eric Farman <farman@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Jason Herne <jjherne@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, Jared Rossi <jrossi@linux.ibm.com>
Subject: [RFC PATCH v2 1/7] vfio-ccw: Return IOINST_CC_NOT_OPERATIONAL for EIO
Date: Thu, 6 Feb 2020 22:45:03 +0100 [thread overview]
Message-ID: <20200206214509.16434-2-farman@linux.ibm.com> (raw)
In-Reply-To: <20200206214509.16434-1-farman@linux.ibm.com>
From: Farhan Ali <alifm@linux.ibm.com>
EIO is returned by vfio-ccw mediated device when the backing
host subchannel is not operational anymore. So return cc=3
back to the guest, rather than returning a unit check.
This way the guest can take appropriate action such as
issue an 'stsch'.
Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
Notes:
v1->v2: [EF]
- Add s-o-b
- [Seems the discussion on v1 centered on the return code
set in the kernel, rather than anything that needs to
change here, unless I've missed something.]
hw/vfio/ccw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index 50cc2ec75c..19144ecfc7 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -114,6 +114,7 @@ again:
return IOINST_CC_BUSY;
case -ENODEV:
case -EACCES:
+ case -EIO:
return IOINST_CC_NOT_OPERATIONAL;
case -EFAULT:
default:
--
2.17.1
next prev parent reply other threads:[~2020-02-06 21:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 21:45 [RFC PATCH v2 0/7] s390x/vfio_ccw: Channel Path Handling [QEMU] Eric Farman
2020-02-06 21:45 ` Eric Farman [this message]
2020-03-24 17:04 ` [RFC PATCH v2 1/7] vfio-ccw: Return IOINST_CC_NOT_OPERATIONAL for EIO Cornelia Huck
2020-03-25 2:24 ` Halil Pasic
2020-04-01 8:52 ` Cornelia Huck
2020-04-06 18:21 ` Eric Farman
2020-04-07 6:28 ` Cornelia Huck
2020-04-07 10:18 ` Eric Farman
2020-02-06 21:45 ` [RFC PATCH v2 2/7] linux-headers: update Eric Farman
2020-02-06 21:45 ` [RFC PATCH v2 3/7] vfio-ccw: Refactor cleanup of regions Eric Farman
2020-02-06 21:45 ` [RFC PATCH v2 4/7] vfio-ccw: Add support for the schib region Eric Farman
2020-02-06 21:45 ` [RFC PATCH v2 5/7] vfio-ccw: Add support for the crw region Eric Farman
2020-02-06 21:45 ` [RFC PATCH v2 6/7] vfio-ccw: Refactor ccw irq handler Eric Farman
2020-03-24 17:32 ` Cornelia Huck
2020-02-06 21:45 ` [RFC PATCH v2 7/7] vfio-ccw: Add support for the CRW irq Eric Farman
2020-04-06 16:22 ` Cornelia Huck
2020-04-06 21:37 ` Eric Farman
2020-04-07 6:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206214509.16434-2-farman@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.