From: Pratyush Yadav <p.yadav@ti.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
git@vger.kernel.org
Subject: Re: bug? illegal text in commit log
Date: Fri, 7 Feb 2020 16:32:16 +0530 [thread overview]
Message-ID: <20200207110216.ppf5aksfkam54bip@ti.com> (raw)
In-Reply-To: <xmqqd0arfyw8.fsf@gitster-ct.c.googlers.com>
On 06/02/20 08:45AM, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>
> > Like a Lines: header specifying the number of lines in the commit message?
>
> The only part of the workflow that can count the number reliably is
> format-patch. But the output of format-patch is designed to be
> edited further, and expecting users to adjust the number when they
> make such an edit is a bit too much.
I haven't thought this through, but I'll throw the idea out anyway:
How about counting lines in the diff (the one generated by format-patch,
not the one in the commit message) instead of lines in the commit
message? This way, the bottom n lines in the mail (barring the
signature) are the diff contents.
I personally have often edited the commit message and added comments
below the '---' line in the patches output by format-patch, but I rarely
ever manually edit the diff. It is just really easy to corrupt the patch
when you manually edit it.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2020-02-07 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 6:14 bug? illegal text in commit log Michael S. Tsirkin
2020-02-04 21:10 ` René Scharfe
2020-02-04 21:25 ` Junio C Hamano
2020-02-06 6:34 ` Michael S. Tsirkin
2020-02-06 16:17 ` Junio C Hamano
2020-02-06 16:45 ` Junio C Hamano
2020-02-06 17:30 ` René Scharfe
2020-02-07 5:40 ` Junio C Hamano
2020-02-07 20:30 ` René Scharfe
2020-02-12 2:24 ` Jeff King
2020-02-06 23:56 ` Michael S. Tsirkin
2020-02-07 11:02 ` Pratyush Yadav [this message]
2020-02-07 20:31 ` René Scharfe
2020-02-07 21:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207110216.ppf5aksfkam54bip@ti.com \
--to=p.yadav@ti.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.