From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCDDC04EB5 for ; Fri, 7 Feb 2020 14:13:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB79120838 for ; Fri, 7 Feb 2020 14:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB79120838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82E716FCBA; Fri, 7 Feb 2020 14:13:29 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 616AD6FCBD for ; Fri, 7 Feb 2020 14:13:28 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2020 06:13:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,413,1574150400"; d="scan'208";a="232387822" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.154]) by orsmga003.jf.intel.com with ESMTP; 07 Feb 2020 06:13:26 -0800 Date: Fri, 7 Feb 2020 19:43:37 +0530 From: Ramalingam C To: Anshuman Gupta Message-ID: <20200207141337.GE11460@intel.com> References: <20200128135425.14596-1-anshuman.gupta@intel.com> <20200128135425.14596-4-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200128135425.14596-4-anshuman.gupta@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: debugfs info print "HDCP shim isn't available" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2020-01-28 at 19:24:24 +0530, Anshuman Gupta wrote: > If HDCP shim is not initialized, i915_display_info > connector info returns EINVAL without providing any debug > information. Adding a print for that will be useful for debugging. > > CC: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/i915_debugfs.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 0ac98e39eb75..6d913a71cbdb 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2405,7 +2405,8 @@ static void intel_dp_info(struct seq_file *m, > if (intel_connector->hdcp.shim) { > seq_puts(m, "\tHDCP version: "); > intel_hdcp_info(m, intel_connector); > - } > + } else if (!intel_dp_is_edp(intel_dp)) > + seq_puts(m, "\tHDCP shim isn't available\n"); I would prefer "HDCP shim is not initialized" for this purpose. But when this can happen on DP/HDCP connector? Either has_hdcp is false or when port is >= E. Those info might help better for debugging. Infact as we discussed in other patch, we need to check whether we need\ port limitation for } > > static void intel_dp_mst_info(struct seq_file *m, > @@ -2432,6 +2433,8 @@ static void intel_hdmi_info(struct seq_file *m, > if (intel_connector->hdcp.shim) { > seq_puts(m, "\tHDCP version: "); > intel_hdcp_info(m, intel_connector); > + } else { > + seq_puts(m, "\tHDCP shim isn't available\n"); > } > } > > -- > 2.24.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx