diff for duplicates of <20200207153829.GA2401@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 5415545..f95ad25 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -80,7 +80,7 @@ to the top of the struct it would fail to compile. > > + old_size = sizeof(struct kvm_memslots) + > > + (sizeof(struct kvm_memory_slot) * old->used_slots); > > + -> > + if (change = KVM_MR_CREATE) +> > + if (change == KVM_MR_CREATE) > > + new_size = old_size + sizeof(struct kvm_memory_slot); > > + else > > + new_size = old_size; @@ -103,7 +103,7 @@ A more effecient implementation would be: slots = kvalloc(new_size, GFP_KERNEL_ACCOUNT); if (likely(slots)) { memcpy(slots, old, old_size); - if (change = KVM_MR_CREATE) + if (change == KVM_MR_CREATE) memset((void *)slots + old_size, 0, new_size - old_size); } @@ -130,7 +130,7 @@ any mixup would hit zeroed memory and not uninitialized memory. > > return -ENOMEM; > > - memcpy(slots, __kvm_memslots(kvm, as_id), sizeof(struct kvm_memslots)); > > -> > if (change = KVM_MR_DELETE || change = KVM_MR_MOVE) { +> > if (change == KVM_MR_DELETE || change == KVM_MR_MOVE) { > > /* > > -- > > 2.24.1 @@ -138,4 +138,8 @@ any mixup would hit zeroed memory and not uninitialized memory. > > -- > Peter Xu -> +> +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N1/content_digest index 8d55dab..8d44322 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,29 +3,25 @@ "ref\020200206221208.GI700495@xz-x1\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v5 18/19] KVM: Dynamically size memslot array based on number of used slots\0" - "Date\0Fri, 07 Feb 2020 15:38:29 +0000\0" + "Date\0Fri, 7 Feb 2020 07:38:29 -0800\0" "To\0Peter Xu <peterx@redhat.com>\0" - "Cc\0Paolo Bonzini <pbonzini@redhat.com>" + "Cc\0Wanpeng Li <wanpengli@tencent.com>" + kvm@vger.kernel.org + David Hildenbrand <david@redhat.com> + linux-mips@vger.kernel.org Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> + kvmarm@lists.cs.columbia.edu Janosch Frank <frankja@linux.ibm.com> - David Hildenbrand <david@redhat.com> - Cornelia Huck <cohuck@redhat.com> - Vitaly Kuznetsov <vkuznets@redhat.com> - Wanpeng Li <wanpengli@tencent.com> - Jim Mattson <jmattson@google.com> - Joerg Roedel <joro@8bytes.org> Marc Zyngier <maz@kernel.org> - James Morse <james.morse@arm.com> - Julien Thierry <julien.thierry.kdev@gmail.com> - Suzuki K Poulose <suzuki.poulose@arm.com> - linux-mips@vger.kernel.org - kvm@vger.kernel.org + Joerg Roedel <joro@8bytes.org> + Christian Borntraeger <borntraeger@de.ibm.com> kvm-ppc@vger.kernel.org linux-arm-kernel@lists.infradead.org - kvmarm@lists.cs.columbia.edu + Jim Mattson <jmattson@google.com> + Cornelia Huck <cohuck@redhat.com> linux-kernel@vger.kernel.org - Christoffer Dall <christoffer.dall@arm.com> + Paolo Bonzini <pbonzini@redhat.com> + Vitaly Kuznetsov <vkuznets@redhat.com> " Philippe Mathieu-Daud\303\251 <f4bug@amsat.org>\0" "\00:1\0" "b\0" @@ -111,7 +107,7 @@ "> > +\told_size = sizeof(struct kvm_memslots) +\n" "> > +\t\t (sizeof(struct kvm_memory_slot) * old->used_slots);\n" "> > +\n" - "> > +\tif (change = KVM_MR_CREATE)\n" + "> > +\tif (change == KVM_MR_CREATE)\n" "> > +\t\tnew_size = old_size + sizeof(struct kvm_memory_slot);\n" "> > +\telse\n" "> > +\t\tnew_size = old_size;\n" @@ -134,7 +130,7 @@ "\tslots = kvalloc(new_size, GFP_KERNEL_ACCOUNT);\n" "\tif (likely(slots)) {\n" "\t\tmemcpy(slots, old, old_size);\n" - "\t\tif (change = KVM_MR_CREATE)\n" + "\t\tif (change == KVM_MR_CREATE)\n" "\t\t\tmemset((void *)slots + old_size, 0, new_size - old_size);\n" "\t}\n" "\n" @@ -161,7 +157,7 @@ "> > \t\treturn -ENOMEM;\n" "> > -\tmemcpy(slots, __kvm_memslots(kvm, as_id), sizeof(struct kvm_memslots));\n" "> > \n" - "> > \tif (change = KVM_MR_DELETE || change = KVM_MR_MOVE) {\n" + "> > \tif (change == KVM_MR_DELETE || change == KVM_MR_MOVE) {\n" "> > \t\t/*\n" "> > -- \n" "> > 2.24.1\n" @@ -169,6 +165,10 @@ "> \n" "> -- \n" "> Peter Xu\n" - > + "> \n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -d05684eb075885d8d73cc0b0323b4724d78e97fcc76d5772c774b125c68791e9 +e555248f267ef022d3b0de2ebc07806dc2d76ba6c21f426e903b60d06b4f9632
diff --git a/a/1.txt b/N2/1.txt index 5415545..613db47 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -80,7 +80,7 @@ to the top of the struct it would fail to compile. > > + old_size = sizeof(struct kvm_memslots) + > > + (sizeof(struct kvm_memory_slot) * old->used_slots); > > + -> > + if (change = KVM_MR_CREATE) +> > + if (change == KVM_MR_CREATE) > > + new_size = old_size + sizeof(struct kvm_memory_slot); > > + else > > + new_size = old_size; @@ -103,7 +103,7 @@ A more effecient implementation would be: slots = kvalloc(new_size, GFP_KERNEL_ACCOUNT); if (likely(slots)) { memcpy(slots, old, old_size); - if (change = KVM_MR_CREATE) + if (change == KVM_MR_CREATE) memset((void *)slots + old_size, 0, new_size - old_size); } @@ -130,7 +130,7 @@ any mixup would hit zeroed memory and not uninitialized memory. > > return -ENOMEM; > > - memcpy(slots, __kvm_memslots(kvm, as_id), sizeof(struct kvm_memslots)); > > -> > if (change = KVM_MR_DELETE || change = KVM_MR_MOVE) { +> > if (change == KVM_MR_DELETE || change == KVM_MR_MOVE) { > > /* > > -- > > 2.24.1 diff --git a/a/content_digest b/N2/content_digest index 8d55dab..8d29054 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\020200206221208.GI700495@xz-x1\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v5 18/19] KVM: Dynamically size memslot array based on number of used slots\0" - "Date\0Fri, 07 Feb 2020 15:38:29 +0000\0" + "Date\0Fri, 7 Feb 2020 07:38:29 -0800\0" "To\0Peter Xu <peterx@redhat.com>\0" "Cc\0Paolo Bonzini <pbonzini@redhat.com>" Paul Mackerras <paulus@ozlabs.org> @@ -111,7 +111,7 @@ "> > +\told_size = sizeof(struct kvm_memslots) +\n" "> > +\t\t (sizeof(struct kvm_memory_slot) * old->used_slots);\n" "> > +\n" - "> > +\tif (change = KVM_MR_CREATE)\n" + "> > +\tif (change == KVM_MR_CREATE)\n" "> > +\t\tnew_size = old_size + sizeof(struct kvm_memory_slot);\n" "> > +\telse\n" "> > +\t\tnew_size = old_size;\n" @@ -134,7 +134,7 @@ "\tslots = kvalloc(new_size, GFP_KERNEL_ACCOUNT);\n" "\tif (likely(slots)) {\n" "\t\tmemcpy(slots, old, old_size);\n" - "\t\tif (change = KVM_MR_CREATE)\n" + "\t\tif (change == KVM_MR_CREATE)\n" "\t\t\tmemset((void *)slots + old_size, 0, new_size - old_size);\n" "\t}\n" "\n" @@ -161,7 +161,7 @@ "> > \t\treturn -ENOMEM;\n" "> > -\tmemcpy(slots, __kvm_memslots(kvm, as_id), sizeof(struct kvm_memslots));\n" "> > \n" - "> > \tif (change = KVM_MR_DELETE || change = KVM_MR_MOVE) {\n" + "> > \tif (change == KVM_MR_DELETE || change == KVM_MR_MOVE) {\n" "> > \t\t/*\n" "> > -- \n" "> > 2.24.1\n" @@ -171,4 +171,4 @@ "> Peter Xu\n" > -d05684eb075885d8d73cc0b0323b4724d78e97fcc76d5772c774b125c68791e9 +4791a4b636f08d5edeebe8b5a2e3629edea62493049fd9ac86be756e3cd4c213
diff --git a/a/1.txt b/N3/1.txt index 5415545..c2b0d1a 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -80,7 +80,7 @@ to the top of the struct it would fail to compile. > > + old_size = sizeof(struct kvm_memslots) + > > + (sizeof(struct kvm_memory_slot) * old->used_slots); > > + -> > + if (change = KVM_MR_CREATE) +> > + if (change == KVM_MR_CREATE) > > + new_size = old_size + sizeof(struct kvm_memory_slot); > > + else > > + new_size = old_size; @@ -103,7 +103,7 @@ A more effecient implementation would be: slots = kvalloc(new_size, GFP_KERNEL_ACCOUNT); if (likely(slots)) { memcpy(slots, old, old_size); - if (change = KVM_MR_CREATE) + if (change == KVM_MR_CREATE) memset((void *)slots + old_size, 0, new_size - old_size); } @@ -130,7 +130,7 @@ any mixup would hit zeroed memory and not uninitialized memory. > > return -ENOMEM; > > - memcpy(slots, __kvm_memslots(kvm, as_id), sizeof(struct kvm_memslots)); > > -> > if (change = KVM_MR_DELETE || change = KVM_MR_MOVE) { +> > if (change == KVM_MR_DELETE || change == KVM_MR_MOVE) { > > /* > > -- > > 2.24.1 @@ -138,4 +138,9 @@ any mixup would hit zeroed memory and not uninitialized memory. > > -- > Peter Xu -> +> + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index 8d55dab..b9f491b 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,29 +3,29 @@ "ref\020200206221208.GI700495@xz-x1\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v5 18/19] KVM: Dynamically size memslot array based on number of used slots\0" - "Date\0Fri, 07 Feb 2020 15:38:29 +0000\0" + "Date\0Fri, 7 Feb 2020 07:38:29 -0800\0" "To\0Peter Xu <peterx@redhat.com>\0" - "Cc\0Paolo Bonzini <pbonzini@redhat.com>" + "Cc\0Wanpeng Li <wanpengli@tencent.com>" + kvm@vger.kernel.org + David Hildenbrand <david@redhat.com> + linux-mips@vger.kernel.org Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> + kvmarm@lists.cs.columbia.edu Janosch Frank <frankja@linux.ibm.com> - David Hildenbrand <david@redhat.com> - Cornelia Huck <cohuck@redhat.com> - Vitaly Kuznetsov <vkuznets@redhat.com> - Wanpeng Li <wanpengli@tencent.com> - Jim Mattson <jmattson@google.com> - Joerg Roedel <joro@8bytes.org> Marc Zyngier <maz@kernel.org> - James Morse <james.morse@arm.com> + Joerg Roedel <joro@8bytes.org> + Christian Borntraeger <borntraeger@de.ibm.com> Julien Thierry <julien.thierry.kdev@gmail.com> Suzuki K Poulose <suzuki.poulose@arm.com> - linux-mips@vger.kernel.org - kvm@vger.kernel.org kvm-ppc@vger.kernel.org linux-arm-kernel@lists.infradead.org - kvmarm@lists.cs.columbia.edu - linux-kernel@vger.kernel.org + Jim Mattson <jmattson@google.com> + Cornelia Huck <cohuck@redhat.com> Christoffer Dall <christoffer.dall@arm.com> + linux-kernel@vger.kernel.org + James Morse <james.morse@arm.com> + Paolo Bonzini <pbonzini@redhat.com> + Vitaly Kuznetsov <vkuznets@redhat.com> " Philippe Mathieu-Daud\303\251 <f4bug@amsat.org>\0" "\00:1\0" "b\0" @@ -111,7 +111,7 @@ "> > +\told_size = sizeof(struct kvm_memslots) +\n" "> > +\t\t (sizeof(struct kvm_memory_slot) * old->used_slots);\n" "> > +\n" - "> > +\tif (change = KVM_MR_CREATE)\n" + "> > +\tif (change == KVM_MR_CREATE)\n" "> > +\t\tnew_size = old_size + sizeof(struct kvm_memory_slot);\n" "> > +\telse\n" "> > +\t\tnew_size = old_size;\n" @@ -134,7 +134,7 @@ "\tslots = kvalloc(new_size, GFP_KERNEL_ACCOUNT);\n" "\tif (likely(slots)) {\n" "\t\tmemcpy(slots, old, old_size);\n" - "\t\tif (change = KVM_MR_CREATE)\n" + "\t\tif (change == KVM_MR_CREATE)\n" "\t\t\tmemset((void *)slots + old_size, 0, new_size - old_size);\n" "\t}\n" "\n" @@ -161,7 +161,7 @@ "> > \t\treturn -ENOMEM;\n" "> > -\tmemcpy(slots, __kvm_memslots(kvm, as_id), sizeof(struct kvm_memslots));\n" "> > \n" - "> > \tif (change = KVM_MR_DELETE || change = KVM_MR_MOVE) {\n" + "> > \tif (change == KVM_MR_DELETE || change == KVM_MR_MOVE) {\n" "> > \t\t/*\n" "> > -- \n" "> > 2.24.1\n" @@ -169,6 +169,11 @@ "> \n" "> -- \n" "> Peter Xu\n" - > + "> \n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -d05684eb075885d8d73cc0b0323b4724d78e97fcc76d5772c774b125c68791e9 +301d45839ccbdb24d56a3c199192276ea36a90b7b69cd39b107ef9d7ddfaa075
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.