From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF18C3F68F for ; Fri, 7 Feb 2020 16:32:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7630E20720 for ; Fri, 7 Feb 2020 16:32:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="izEvmh70" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7630E20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D51E96EAFF; Fri, 7 Feb 2020 16:32:03 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 243466EAFE for ; Fri, 7 Feb 2020 16:32:03 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id m10so3521655wmc.0 for ; Fri, 07 Feb 2020 08:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=W07peGRSyneP+Jc5OMGDHyPXwj07l+1UxvUtVZ5QEBY=; b=izEvmh70uQ1tbUB1hQNUzc8tH/SbZ+wXFGUy+RXccYg2Mb+1ECPj9XdOayLonEA8qn +ueTB1Pk0RonRj9rcHt7Lt9fiZA61JcBnbsvYyEallfcrIEaqMKCTnrwtlhDFSZN714n bgWcL1AdqTWYUzR2HWxE9S/dMHuI/ejlYuNdM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=W07peGRSyneP+Jc5OMGDHyPXwj07l+1UxvUtVZ5QEBY=; b=fpZYEoZfbyc+lQjCqKsAeocFGt+J6b/tF+1zmBNMFc0IOldK9q1LcnBL1uI2vj1aYJ ag0Yu0BrLnuO+TA96T7R6ic/S3kr0S4olDaNaCMMOxUvMK32Po9ZTjNFL9NmyYlcZewl V29vLq3Y1+rkst9clCMXKxbHKdBljj0wcveoR7NdUlCqeAgplyys7LGiwDw9xj4JLN6x DmmqHN72MAPF0hwpOvoG2JFWXDGgT6OCQhyOznV1Ilz59GV5ArDiWqi1WZDoqfhNY8h/ byxL2Dqfr59fAKmWeY1aZ2taet4IUPzlypaJwdMKhhH4+FdiuiSRByHHmK2AS2ZCZ9L0 J1BA== X-Gm-Message-State: APjAAAW01O2VYb5IBkDf6nr8/RYy2ezcnQET0mLkULehZ19CfLjKwGmz CRoFUQitE/qanP4cwmP35b7UTQ== X-Google-Smtp-Source: APXvYqz2O+F63lWEy4DQnvghi8mR3ptDOibCq67yZa3m8D2Inx44lC+mQfyMr9X14xw4pnT44a/iZA== X-Received: by 2002:a1c:7dd4:: with SMTP id y203mr5277285wmc.67.1581093121773; Fri, 07 Feb 2020 08:32:01 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id y6sm3982661wrl.17.2020.02.07.08.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 08:32:00 -0800 (PST) Date: Fri, 7 Feb 2020 17:31:59 +0100 From: Daniel Vetter To: Thomas Zimmermann Subject: Re: [Intel-gfx] [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup Message-ID: <20200207163159.GL43062@phenom.ffwll.local> References: <20200207135950.6655-1-ville.syrjala@linux.intel.com> <20200207135950.6655-5-ville.syrjala@linux.intel.com> <02b04868-6f7b-f1cf-9cc7-fd1466b21761@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <02b04868-6f7b-f1cf-9cc7-fd1466b21761@suse.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 07, 2020 at 03:20:44PM +0100, Thomas Zimmermann wrote: > Hi > = > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > From: Ville Syrj=E4l=E4 > > = > > It's not at all clear what cloning options this driver supports. > > So let's just clear possible_clones instead of setting it to some > > bogus value. > > = > > Cc: Philipp Zabel > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index da87c70e413b..a0a709dfba34 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, > > encoder->possible_crtcs =3D crtc_mask; > > = > > /* FIXME: this is the mask of outputs which can clone this output. */ > > - encoder->possible_clones =3D ~0; > > + encoder->possible_clones =3D 0; > = > Maybe remove the comment as well. It's pointless. Maybe change it to "FIXME: cloning support not clear, disable it all for now". With that Acked-by: Daniel Vetter > = > Best regards > Thomas > = > > = > > return 0; > > } > > = > = > -- = > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 N=FCrnberg, Germany > (HRB 36809, AG N=FCrnberg) > Gesch=E4ftsf=FChrer: Felix Imend=F6rffer > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C4CC2BA83 for ; Fri, 7 Feb 2020 16:32:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C58C120720 for ; Fri, 7 Feb 2020 16:32:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="izEvmh70" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C58C120720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71FE96E0B9; Fri, 7 Feb 2020 16:32:03 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D58F6E0B9 for ; Fri, 7 Feb 2020 16:32:03 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id s144so3520502wme.1 for ; Fri, 07 Feb 2020 08:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=W07peGRSyneP+Jc5OMGDHyPXwj07l+1UxvUtVZ5QEBY=; b=izEvmh70uQ1tbUB1hQNUzc8tH/SbZ+wXFGUy+RXccYg2Mb+1ECPj9XdOayLonEA8qn +ueTB1Pk0RonRj9rcHt7Lt9fiZA61JcBnbsvYyEallfcrIEaqMKCTnrwtlhDFSZN714n bgWcL1AdqTWYUzR2HWxE9S/dMHuI/ejlYuNdM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=W07peGRSyneP+Jc5OMGDHyPXwj07l+1UxvUtVZ5QEBY=; b=bQ04YLO4n6e0aZzffutBnT9/9jhtuw8/pPZIU9g39TNnN/nxxdDOIPnFI5mZ5nYg62 gDpYneg31HvgflSNLCNr3xWSwan8fP+TlfJ2suOSX0YsB/VbL7nwHl4gbfV66CIpAlpn M2pdwZ/dairJZJJ1J9o4HOoZWA9IRDrPODzC6vVaFJBEueM95/6f2FT/3Vzf8oOfpD18 Kbupe93JfhgN5xoHqR+GWujISD5PqvaL3fW133PBDfg0U/7bOtshkBGSagpnJZ0IvRsd 1ZUK+nAN36s6y3+HqUd6Cu4L5q58/ElA67LXOqZna9C/osvUlqjfESO7srt/seo0IgmI mL4A== X-Gm-Message-State: APjAAAUVFx6AnmaXXzIl5C31YKLe3yixOM+TLU2YzV/044n9XRtDXyus fHqVNfjBc5Aw084LCWP1oqQX5Q== X-Google-Smtp-Source: APXvYqz2O+F63lWEy4DQnvghi8mR3ptDOibCq67yZa3m8D2Inx44lC+mQfyMr9X14xw4pnT44a/iZA== X-Received: by 2002:a1c:7dd4:: with SMTP id y203mr5277285wmc.67.1581093121773; Fri, 07 Feb 2020 08:32:01 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id y6sm3982661wrl.17.2020.02.07.08.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 08:32:00 -0800 (PST) Date: Fri, 7 Feb 2020 17:31:59 +0100 From: Daniel Vetter To: Thomas Zimmermann Message-ID: <20200207163159.GL43062@phenom.ffwll.local> References: <20200207135950.6655-1-ville.syrjala@linux.intel.com> <20200207135950.6655-5-ville.syrjala@linux.intel.com> <02b04868-6f7b-f1cf-9cc7-fd1466b21761@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <02b04868-6f7b-f1cf-9cc7-fd1466b21761@suse.de> X-Operating-System: Linux phenom 5.3.0-3-amd64 Subject: Re: [Intel-gfx] [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Feb 07, 2020 at 03:20:44PM +0100, Thomas Zimmermann wrote: > Hi > = > Am 07.02.20 um 14:59 schrieb Ville Syrjala: > > From: Ville Syrj=E4l=E4 > > = > > It's not at all clear what cloning options this driver supports. > > So let's just clear possible_clones instead of setting it to some > > bogus value. > > = > > Cc: Philipp Zabel > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/i= mx-drm-core.c > > index da87c70e413b..a0a709dfba34 100644 > > --- a/drivers/gpu/drm/imx/imx-drm-core.c > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > > @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, > > encoder->possible_crtcs =3D crtc_mask; > > = > > /* FIXME: this is the mask of outputs which can clone this output. */ > > - encoder->possible_clones =3D ~0; > > + encoder->possible_clones =3D 0; > = > Maybe remove the comment as well. It's pointless. Maybe change it to "FIXME: cloning support not clear, disable it all for now". With that Acked-by: Daniel Vetter > = > Best regards > Thomas > = > > = > > return 0; > > } > > = > = > -- = > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 N=FCrnberg, Germany > (HRB 36809, AG N=FCrnberg) > Gesch=E4ftsf=FChrer: Felix Imend=F6rffer > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx