From: Mike Snitzer <snitzer@redhat.com>
To: John Dorminy <jdorminy@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: dm: expose dm_copy_name_and_uuid()
Date: Fri, 7 Feb 2020 12:33:25 -0500 [thread overview]
Message-ID: <20200207173325.GA24010@redhat.com> (raw)
In-Reply-To: <CAMeeMh_m2EZsN_W0EzwNz7HsLs75QwTDEVY6UT+4HQkqEX8n8Q@mail.gmail.com>
On Thu, Feb 06 2020 at 10:19pm -0500,
John Dorminy <jdorminy@redhat.com> wrote:
> I agree that adding uuid to all messages would be gross bloat, and a
> bad idea to apply everywhere.
>
> I didn't actually realize that devices could be renamed with dmsetup.
> Thanks for pointing that out...
Also, device names can also be ridiculously long. I really just don't
think logging the name instead of major:minor is a great idea... but I'm
open to target authors electing to log it _in addition to_
dm_device_name() -- but I wouldn't want to go as far as imposing that
constraint with code...
Or would I? ;)
Create dm_pretty_device_name() that logs: "major:minor (name)" ?
Mike
prev parent reply other threads:[~2020-02-07 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 0:55 [PATCH] dm: expose dm_copy_name_and_uuid() John Dorminy
2020-02-03 16:54 ` Mike Snitzer
2020-02-07 0:28 ` John Dorminy
2020-02-07 1:24 ` Alasdair G Kergon
2020-02-07 1:42 ` Alasdair G Kergon
2020-02-07 3:19 ` John Dorminy
2020-02-07 17:33 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207173325.GA24010@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jdorminy@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.