All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20200207211016.GN2401@linux.intel.com>

diff --git a/a/1.txt b/N1/1.txt
index 26d64d0..7f47570 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -16,7 +16,7 @@ On Fri, Feb 07, 2020 at 03:39:09PM -0500, Peter Xu wrote:
 > > > Is this intended?
 > > 
 > > Yes.  It's possible to allow VA=0 for userspace mappings.  It's extremely
-> > uncommon, but possible.  Therefore "hva = 0" shouldn't be used to
+> > uncommon, but possible.  Therefore "hva == 0" shouldn't be used to
 > > indicate an invalid slot.
 > 
 > Note that this is the deletion path in __x86_set_memory_region() not
@@ -47,7 +47,7 @@ to indicate it's being destroyed.
 > > > > +	struct kvm_memory_slot *mslots = slots->memslots;
 > > > > +	int i;
 > > > > +
-> > > > +	if (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||
+> > > > +	if (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||
 > > > > +	    WARN_ON_ONCE(!slots->used_slots))
 > > > > +		return -1;
 > > > > +
@@ -60,7 +60,7 @@ to indicate it's being destroyed.
 > > > > +		if (memslot->base_gfn > mslots[i + 1].base_gfn)
 > > > > +			break;
 > > > > +
-> > > > +		WARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);
+> > > > +		WARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);
 > > > 
 > > > Will this trigger?  Note that in __kvm_set_memory_region() we have
 > > > already checked overlap of memslots.
@@ -119,3 +119,7 @@ can't be used incorrectly and thus cause silent failure.
 This is also another reason I'd like to keep the WARN_ONs.  When this code
 goes awry, the result is usually silent corruption and delayed explosions,
 i.e. failures that absolutely suck to debug.
+_______________________________________________
+kvmarm mailing list
+kvmarm@lists.cs.columbia.edu
+https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
diff --git a/a/content_digest b/N1/content_digest
index 3b5edf7..06f443b 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -5,29 +5,25 @@
  "ref\020200207203909.GE720553@xz-x1\0"
  "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0"
  "Subject\0Re: [PATCH v5 17/19] KVM: Terminate memslot walks via used_slots\0"
- "Date\0Fri, 07 Feb 2020 21:10:16 +0000\0"
+ "Date\0Fri, 7 Feb 2020 13:10:16 -0800\0"
  "To\0Peter Xu <peterx@redhat.com>\0"
- "Cc\0Paolo Bonzini <pbonzini@redhat.com>"
+ "Cc\0Wanpeng Li <wanpengli@tencent.com>"
+  kvm@vger.kernel.org
+  David Hildenbrand <david@redhat.com>
+  linux-mips@vger.kernel.org
   Paul Mackerras <paulus@ozlabs.org>
-  Christian Borntraeger <borntraeger@de.ibm.com>
+  kvmarm@lists.cs.columbia.edu
   Janosch Frank <frankja@linux.ibm.com>
-  David Hildenbrand <david@redhat.com>
-  Cornelia Huck <cohuck@redhat.com>
-  Vitaly Kuznetsov <vkuznets@redhat.com>
-  Wanpeng Li <wanpengli@tencent.com>
-  Jim Mattson <jmattson@google.com>
-  Joerg Roedel <joro@8bytes.org>
   Marc Zyngier <maz@kernel.org>
-  James Morse <james.morse@arm.com>
-  Julien Thierry <julien.thierry.kdev@gmail.com>
-  Suzuki K Poulose <suzuki.poulose@arm.com>
-  linux-mips@vger.kernel.org
-  kvm@vger.kernel.org
+  Joerg Roedel <joro@8bytes.org>
+  Christian Borntraeger <borntraeger@de.ibm.com>
   kvm-ppc@vger.kernel.org
   linux-arm-kernel@lists.infradead.org
-  kvmarm@lists.cs.columbia.edu
+  Jim Mattson <jmattson@google.com>
+  Cornelia Huck <cohuck@redhat.com>
   linux-kernel@vger.kernel.org
-  Christoffer Dall <christoffer.dall@arm.com>
+  Paolo Bonzini <pbonzini@redhat.com>
+  Vitaly Kuznetsov <vkuznets@redhat.com>
  " Philippe Mathieu-Daud\303\251 <f4bug@amsat.org>\0"
  "\00:1\0"
  "b\0"
@@ -49,7 +45,7 @@
  "> > > Is this intended?\n"
  "> > \n"
  "> > Yes.  It's possible to allow VA=0 for userspace mappings.  It's extremely\n"
- "> > uncommon, but possible.  Therefore \"hva = 0\" shouldn't be used to\n"
+ "> > uncommon, but possible.  Therefore \"hva == 0\" shouldn't be used to\n"
  "> > indicate an invalid slot.\n"
  "> \n"
  "> Note that this is the deletion path in __x86_set_memory_region() not\n"
@@ -80,7 +76,7 @@
  "> > > > +\tstruct kvm_memory_slot *mslots = slots->memslots;\n"
  "> > > > +\tint i;\n"
  "> > > > +\n"
- "> > > > +\tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||\n"
+ "> > > > +\tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||\n"
  "> > > > +\t    WARN_ON_ONCE(!slots->used_slots))\n"
  "> > > > +\t\treturn -1;\n"
  "> > > > +\n"
@@ -93,7 +89,7 @@
  "> > > > +\t\tif (memslot->base_gfn > mslots[i + 1].base_gfn)\n"
  "> > > > +\t\t\tbreak;\n"
  "> > > > +\n"
- "> > > > +\t\tWARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);\n"
+ "> > > > +\t\tWARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);\n"
  "> > > \n"
  "> > > Will this trigger?  Note that in __kvm_set_memory_region() we have\n"
  "> > > already checked overlap of memslots.\n"
@@ -151,6 +147,10 @@
  "\n"
  "This is also another reason I'd like to keep the WARN_ONs.  When this code\n"
  "goes awry, the result is usually silent corruption and delayed explosions,\n"
- i.e. failures that absolutely suck to debug.
+ "i.e. failures that absolutely suck to debug.\n"
+ "_______________________________________________\n"
+ "kvmarm mailing list\n"
+ "kvmarm@lists.cs.columbia.edu\n"
+ https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
 
-6b19957151838dbec7eefc3aad1df427176cf8bc8f7e5c5516ff23c41e95e850
+95f40dadb30d737c9ae8202d8b56083cff86d7c8d4761ec0a09a6a8a57bf6de1

diff --git a/a/1.txt b/N2/1.txt
index 26d64d0..8224d0c 100644
--- a/a/1.txt
+++ b/N2/1.txt
@@ -16,7 +16,7 @@ On Fri, Feb 07, 2020 at 03:39:09PM -0500, Peter Xu wrote:
 > > > Is this intended?
 > > 
 > > Yes.  It's possible to allow VA=0 for userspace mappings.  It's extremely
-> > uncommon, but possible.  Therefore "hva = 0" shouldn't be used to
+> > uncommon, but possible.  Therefore "hva == 0" shouldn't be used to
 > > indicate an invalid slot.
 > 
 > Note that this is the deletion path in __x86_set_memory_region() not
@@ -47,7 +47,7 @@ to indicate it's being destroyed.
 > > > > +	struct kvm_memory_slot *mslots = slots->memslots;
 > > > > +	int i;
 > > > > +
-> > > > +	if (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||
+> > > > +	if (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||
 > > > > +	    WARN_ON_ONCE(!slots->used_slots))
 > > > > +		return -1;
 > > > > +
@@ -60,7 +60,7 @@ to indicate it's being destroyed.
 > > > > +		if (memslot->base_gfn > mslots[i + 1].base_gfn)
 > > > > +			break;
 > > > > +
-> > > > +		WARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);
+> > > > +		WARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);
 > > > 
 > > > Will this trigger?  Note that in __kvm_set_memory_region() we have
 > > > already checked overlap of memslots.
diff --git a/a/content_digest b/N2/content_digest
index 3b5edf7..1603d3e 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -5,7 +5,7 @@
  "ref\020200207203909.GE720553@xz-x1\0"
  "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0"
  "Subject\0Re: [PATCH v5 17/19] KVM: Terminate memslot walks via used_slots\0"
- "Date\0Fri, 07 Feb 2020 21:10:16 +0000\0"
+ "Date\0Fri, 7 Feb 2020 13:10:16 -0800\0"
  "To\0Peter Xu <peterx@redhat.com>\0"
  "Cc\0Paolo Bonzini <pbonzini@redhat.com>"
   Paul Mackerras <paulus@ozlabs.org>
@@ -49,7 +49,7 @@
  "> > > Is this intended?\n"
  "> > \n"
  "> > Yes.  It's possible to allow VA=0 for userspace mappings.  It's extremely\n"
- "> > uncommon, but possible.  Therefore \"hva = 0\" shouldn't be used to\n"
+ "> > uncommon, but possible.  Therefore \"hva == 0\" shouldn't be used to\n"
  "> > indicate an invalid slot.\n"
  "> \n"
  "> Note that this is the deletion path in __x86_set_memory_region() not\n"
@@ -80,7 +80,7 @@
  "> > > > +\tstruct kvm_memory_slot *mslots = slots->memslots;\n"
  "> > > > +\tint i;\n"
  "> > > > +\n"
- "> > > > +\tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||\n"
+ "> > > > +\tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||\n"
  "> > > > +\t    WARN_ON_ONCE(!slots->used_slots))\n"
  "> > > > +\t\treturn -1;\n"
  "> > > > +\n"
@@ -93,7 +93,7 @@
  "> > > > +\t\tif (memslot->base_gfn > mslots[i + 1].base_gfn)\n"
  "> > > > +\t\t\tbreak;\n"
  "> > > > +\n"
- "> > > > +\t\tWARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);\n"
+ "> > > > +\t\tWARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);\n"
  "> > > \n"
  "> > > Will this trigger?  Note that in __kvm_set_memory_region() we have\n"
  "> > > already checked overlap of memslots.\n"
@@ -153,4 +153,4 @@
  "goes awry, the result is usually silent corruption and delayed explosions,\n"
  i.e. failures that absolutely suck to debug.
 
-6b19957151838dbec7eefc3aad1df427176cf8bc8f7e5c5516ff23c41e95e850
+35efdb34cb4aac2105036f6f85a2135f34bce6ab0de635cd1370f2f4ae622845

diff --git a/a/1.txt b/N3/1.txt
index 26d64d0..d7d06e9 100644
--- a/a/1.txt
+++ b/N3/1.txt
@@ -16,7 +16,7 @@ On Fri, Feb 07, 2020 at 03:39:09PM -0500, Peter Xu wrote:
 > > > Is this intended?
 > > 
 > > Yes.  It's possible to allow VA=0 for userspace mappings.  It's extremely
-> > uncommon, but possible.  Therefore "hva = 0" shouldn't be used to
+> > uncommon, but possible.  Therefore "hva == 0" shouldn't be used to
 > > indicate an invalid slot.
 > 
 > Note that this is the deletion path in __x86_set_memory_region() not
@@ -47,7 +47,7 @@ to indicate it's being destroyed.
 > > > > +	struct kvm_memory_slot *mslots = slots->memslots;
 > > > > +	int i;
 > > > > +
-> > > > +	if (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||
+> > > > +	if (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||
 > > > > +	    WARN_ON_ONCE(!slots->used_slots))
 > > > > +		return -1;
 > > > > +
@@ -60,7 +60,7 @@ to indicate it's being destroyed.
 > > > > +		if (memslot->base_gfn > mslots[i + 1].base_gfn)
 > > > > +			break;
 > > > > +
-> > > > +		WARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);
+> > > > +		WARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);
 > > > 
 > > > Will this trigger?  Note that in __kvm_set_memory_region() we have
 > > > already checked overlap of memslots.
@@ -119,3 +119,8 @@ can't be used incorrectly and thus cause silent failure.
 This is also another reason I'd like to keep the WARN_ONs.  When this code
 goes awry, the result is usually silent corruption and delayed explosions,
 i.e. failures that absolutely suck to debug.
+
+_______________________________________________
+linux-arm-kernel mailing list
+linux-arm-kernel@lists.infradead.org
+http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/a/content_digest b/N3/content_digest
index 3b5edf7..1a030e3 100644
--- a/a/content_digest
+++ b/N3/content_digest
@@ -5,29 +5,29 @@
  "ref\020200207203909.GE720553@xz-x1\0"
  "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0"
  "Subject\0Re: [PATCH v5 17/19] KVM: Terminate memslot walks via used_slots\0"
- "Date\0Fri, 07 Feb 2020 21:10:16 +0000\0"
+ "Date\0Fri, 7 Feb 2020 13:10:16 -0800\0"
  "To\0Peter Xu <peterx@redhat.com>\0"
- "Cc\0Paolo Bonzini <pbonzini@redhat.com>"
+ "Cc\0Wanpeng Li <wanpengli@tencent.com>"
+  kvm@vger.kernel.org
+  David Hildenbrand <david@redhat.com>
+  linux-mips@vger.kernel.org
   Paul Mackerras <paulus@ozlabs.org>
-  Christian Borntraeger <borntraeger@de.ibm.com>
+  kvmarm@lists.cs.columbia.edu
   Janosch Frank <frankja@linux.ibm.com>
-  David Hildenbrand <david@redhat.com>
-  Cornelia Huck <cohuck@redhat.com>
-  Vitaly Kuznetsov <vkuznets@redhat.com>
-  Wanpeng Li <wanpengli@tencent.com>
-  Jim Mattson <jmattson@google.com>
-  Joerg Roedel <joro@8bytes.org>
   Marc Zyngier <maz@kernel.org>
-  James Morse <james.morse@arm.com>
+  Joerg Roedel <joro@8bytes.org>
+  Christian Borntraeger <borntraeger@de.ibm.com>
   Julien Thierry <julien.thierry.kdev@gmail.com>
   Suzuki K Poulose <suzuki.poulose@arm.com>
-  linux-mips@vger.kernel.org
-  kvm@vger.kernel.org
   kvm-ppc@vger.kernel.org
   linux-arm-kernel@lists.infradead.org
-  kvmarm@lists.cs.columbia.edu
-  linux-kernel@vger.kernel.org
+  Jim Mattson <jmattson@google.com>
+  Cornelia Huck <cohuck@redhat.com>
   Christoffer Dall <christoffer.dall@arm.com>
+  linux-kernel@vger.kernel.org
+  James Morse <james.morse@arm.com>
+  Paolo Bonzini <pbonzini@redhat.com>
+  Vitaly Kuznetsov <vkuznets@redhat.com>
  " Philippe Mathieu-Daud\303\251 <f4bug@amsat.org>\0"
  "\00:1\0"
  "b\0"
@@ -49,7 +49,7 @@
  "> > > Is this intended?\n"
  "> > \n"
  "> > Yes.  It's possible to allow VA=0 for userspace mappings.  It's extremely\n"
- "> > uncommon, but possible.  Therefore \"hva = 0\" shouldn't be used to\n"
+ "> > uncommon, but possible.  Therefore \"hva == 0\" shouldn't be used to\n"
  "> > indicate an invalid slot.\n"
  "> \n"
  "> Note that this is the deletion path in __x86_set_memory_region() not\n"
@@ -80,7 +80,7 @@
  "> > > > +\tstruct kvm_memory_slot *mslots = slots->memslots;\n"
  "> > > > +\tint i;\n"
  "> > > > +\n"
- "> > > > +\tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] = -1) ||\n"
+ "> > > > +\tif (WARN_ON_ONCE(slots->id_to_index[memslot->id] == -1) ||\n"
  "> > > > +\t    WARN_ON_ONCE(!slots->used_slots))\n"
  "> > > > +\t\treturn -1;\n"
  "> > > > +\n"
@@ -93,7 +93,7 @@
  "> > > > +\t\tif (memslot->base_gfn > mslots[i + 1].base_gfn)\n"
  "> > > > +\t\t\tbreak;\n"
  "> > > > +\n"
- "> > > > +\t\tWARN_ON_ONCE(memslot->base_gfn = mslots[i + 1].base_gfn);\n"
+ "> > > > +\t\tWARN_ON_ONCE(memslot->base_gfn == mslots[i + 1].base_gfn);\n"
  "> > > \n"
  "> > > Will this trigger?  Note that in __kvm_set_memory_region() we have\n"
  "> > > already checked overlap of memslots.\n"
@@ -151,6 +151,11 @@
  "\n"
  "This is also another reason I'd like to keep the WARN_ONs.  When this code\n"
  "goes awry, the result is usually silent corruption and delayed explosions,\n"
- i.e. failures that absolutely suck to debug.
+ "i.e. failures that absolutely suck to debug.\n"
+ "\n"
+ "_______________________________________________\n"
+ "linux-arm-kernel mailing list\n"
+ "linux-arm-kernel@lists.infradead.org\n"
+ http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
 
-6b19957151838dbec7eefc3aad1df427176cf8bc8f7e5c5516ff23c41e95e850
+7d4db1175d9f81cb1c0320cd4edf72e3f7409c9c9266e43294dbc546f2b7ea0f

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.