From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j15q9-0001hl-GP for mharc-qemu-trivial@gnu.org; Mon, 10 Feb 2020 04:58:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47970) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j15q6-0001gN-RY for qemu-trivial@nongnu.org; Mon, 10 Feb 2020 04:58:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j15q5-0005Kq-RU for qemu-trivial@nongnu.org; Mon, 10 Feb 2020 04:58:50 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:28380 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j15q5-0005KP-Nh for qemu-trivial@nongnu.org; Mon, 10 Feb 2020 04:58:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581328729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uezzjb/M0zDb4Z6HHFJym8PgOrwYZqphLq4djMxoW/0=; b=AJTnfECbeqNR0+H7nYNrA/l075afj+Kks+76JCPrzCnrIqJBAvUPJSiUCkDYOuSJscNn+m iGlnhYtxFw8967Vz3RnBBWhYE17AWUj8rXg3vQqswUV/7h0DunpeRUlnPlCwvtOCp/nwdf fEJt0pj9Q6qzr9RfYSSKZEpinaM9j14= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-jNl1hSXDPBaXlunAwCN2AA-1; Mon, 10 Feb 2020 04:58:47 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8276610054E3; Mon, 10 Feb 2020 09:58:44 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCB14857B4; Mon, 10 Feb 2020 09:58:38 +0000 (UTC) Date: Mon, 10 Feb 2020 10:58:37 +0100 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Peter Maydell , "open list:Trivial patches" , Joaquin de Andres , Alistair Francis , Michael Tokarev , Andrew Baumann , Esteban Bosse , Niek Linnenbank , qemu-arm@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Laurent Vivier Subject: Re: [PATCH v3 06/13] hw/arm/raspi: Trivial code movement Message-ID: <20200210105837.16cc1c60@redhat.com> In-Reply-To: <20200208165645.15657-7-f4bug@amsat.org> References: <20200208165645.15657-1-f4bug@amsat.org> <20200208165645.15657-7-f4bug@amsat.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: jNl1hSXDPBaXlunAwCN2AA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2020 09:58:51 -0000 On Sat, 8 Feb 2020 17:56:38 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > There is no point in creating the SoC object before allocating the RAM. > Move the call to keep all the SoC-related calls together. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Igor Mammedov > --- > hw/arm/raspi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c > index 7a2ca97347..b3e6f72b55 100644 > --- a/hw/arm/raspi.c > +++ b/hw/arm/raspi.c > @@ -227,9 +227,6 @@ static void raspi_init(MachineState *machine, uint32_= t board_rev) > exit(1); > } > =20 > - object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->s= oc), > - board_soc_type(board_rev), &error_abort, NUL= L); > - > /* Allocate and map RAM */ > memory_region_allocate_system_memory(&s->ram, OBJECT(machine), "ram"= , > machine->ram_size); > @@ -237,6 +234,8 @@ static void raspi_init(MachineState *machine, uint32_= t board_rev) > memory_region_add_subregion_overlap(get_system_memory(), 0, &s->ram,= 0); > =20 > /* Setup the SOC */ > + object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->s= oc), > + board_soc_type(board_rev), &error_abort, NUL= L); > object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(&s->ra= m), > &error_abort); > object_property_set_int(OBJECT(&s->soc), board_rev, "board-rev", From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:3aa:0:0:0:0 with SMTP id v10csp3646572lfp; Mon, 10 Feb 2020 01:58:59 -0800 (PST) X-Google-Smtp-Source: APXvYqyRtsGl1PYS7Ndwlp6PS/f9U7z+fOExQ3WphdZA6DVuCG+GoicBlkv7E9APFqBtuqfBlgK5 X-Received: by 2002:aed:3022:: with SMTP id 31mr9066950qte.282.1581328739675; Mon, 10 Feb 2020 01:58:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581328739; cv=none; d=google.com; s=arc-20160816; b=GVo51x+Ev6KeRKwQ2UBTQiTJcE+lnuRMFuex6+5JFwf71eyjBZXToAtmj6m1O2R5Yl 9D/PkZ57AqOA96bIw+iraRhTb1jFn+9ZtBxP6Yq9pPSYwAGtjhOliBgNn2QZBoE6PzGt CGOcvFfy1YjLPTtr2xke7+uzCXVe07vUsY13xhrv7l4ENhQbim0N66MCYrJJIvMcYCmS K/JHMQSqMd8TU7UqIuHHRNm0GegdWVLlVxIsczmBUamG9GJB84DZrnIul+0xqLhyvClP JMlH0pBEramhOq7vkQjKGTWwed4k3aRJS5fNIcqQ1S+Pz4i7cYuq1SGCFczJiPpUSzL2 iniw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=uezzjb/M0zDb4Z6HHFJym8PgOrwYZqphLq4djMxoW/0=; b=aOACeCOOZsp2njGnHaRpXaRqQTBy+mYUGCg0Li/XGnzjX8tr4A0Z0JTFVCqtji2rCD trB7D1s9Jp5Up9fK93CNz9GDVuygtSpwEKxc70h2dC/W2PeGdXTgkMP4kxvsc5vGuEFI 5/7CogcQyoK159dCed3Zqo8Dg0UF3LQ7RgizXIkGWFs0mQVnQLL/iMge0rI3PE5erQEE MtpQwG8XxKE2hhZOG5wllg6gzMZUxBO9w6mJDU+P+AY8cF+/1uDrO03ng+SgCj8ESeWj dmnLuSgTO6EIsxES9an0OD89tmhOt27NuU9XMU5owuQw2tgmYIXehh4OcIZ1IDzElH4g Nrqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=AJTnfECb; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z67si4075295qka.219.2020.02.10.01.58.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Feb 2020 01:58:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=AJTnfECb; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:59222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j15qF-0001i9-3T for alex.bennee@linaro.org; Mon, 10 Feb 2020 04:58:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47971) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j15q6-0001gO-RY for qemu-arm@nongnu.org; Mon, 10 Feb 2020 04:58:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j15q5-0005Kx-TH for qemu-arm@nongnu.org; Mon, 10 Feb 2020 04:58:50 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45784 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j15q5-0005KR-QA for qemu-arm@nongnu.org; Mon, 10 Feb 2020 04:58:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581328729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uezzjb/M0zDb4Z6HHFJym8PgOrwYZqphLq4djMxoW/0=; b=AJTnfECbeqNR0+H7nYNrA/l075afj+Kks+76JCPrzCnrIqJBAvUPJSiUCkDYOuSJscNn+m iGlnhYtxFw8967Vz3RnBBWhYE17AWUj8rXg3vQqswUV/7h0DunpeRUlnPlCwvtOCp/nwdf fEJt0pj9Q6qzr9RfYSSKZEpinaM9j14= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-jNl1hSXDPBaXlunAwCN2AA-1; Mon, 10 Feb 2020 04:58:47 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8276610054E3; Mon, 10 Feb 2020 09:58:44 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCB14857B4; Mon, 10 Feb 2020 09:58:38 +0000 (UTC) Date: Mon, 10 Feb 2020 10:58:37 +0100 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v3 06/13] hw/arm/raspi: Trivial code movement Message-ID: <20200210105837.16cc1c60@redhat.com> In-Reply-To: <20200208165645.15657-7-f4bug@amsat.org> References: <20200208165645.15657-1-f4bug@amsat.org> <20200208165645.15657-7-f4bug@amsat.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: jNl1hSXDPBaXlunAwCN2AA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "open list:Trivial patches" , Joaquin de Andres , Alistair Francis , Michael Tokarev , qemu-devel@nongnu.org, Andrew Baumann , Laurent Vivier , Esteban Bosse , Niek Linnenbank , qemu-arm@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: kflQxUSV5MHl On Sat, 8 Feb 2020 17:56:38 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > There is no point in creating the SoC object before allocating the RAM. > Move the call to keep all the SoC-related calls together. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Igor Mammedov > --- > hw/arm/raspi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c > index 7a2ca97347..b3e6f72b55 100644 > --- a/hw/arm/raspi.c > +++ b/hw/arm/raspi.c > @@ -227,9 +227,6 @@ static void raspi_init(MachineState *machine, uint32_= t board_rev) > exit(1); > } > =20 > - object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->s= oc), > - board_soc_type(board_rev), &error_abort, NUL= L); > - > /* Allocate and map RAM */ > memory_region_allocate_system_memory(&s->ram, OBJECT(machine), "ram"= , > machine->ram_size); > @@ -237,6 +234,8 @@ static void raspi_init(MachineState *machine, uint32_= t board_rev) > memory_region_add_subregion_overlap(get_system_memory(), 0, &s->ram,= 0); > =20 > /* Setup the SOC */ > + object_initialize_child(OBJECT(machine), "soc", &s->soc, sizeof(s->s= oc), > + board_soc_type(board_rev), &error_abort, NUL= L); > object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(&s->ra= m), > &error_abort); > object_property_set_int(OBJECT(&s->soc), board_rev, "board-rev",