From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38760C352A3 for ; Mon, 10 Feb 2020 13:58:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 163ED206ED for ; Mon, 10 Feb 2020 13:58:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 163ED206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE6066E992; Mon, 10 Feb 2020 13:58:06 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADE5B6E992 for ; Mon, 10 Feb 2020 13:58:05 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2020 05:58:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,425,1574150400"; d="scan'208";a="227190281" Received: from aquilante.fi.intel.com (HELO intel.com) ([10.237.72.158]) by fmsmga008.fm.intel.com with ESMTP; 10 Feb 2020 05:58:03 -0800 Date: Mon, 10 Feb 2020 15:58:08 +0200 From: Andi Shyti To: Chris Wilson Message-ID: <20200210135808.GA2677@intel.intel> References: <20200210134039.2607-1-andi.shyti@intel.com> <158134240184.5235.12886695727708474620@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158134240184.5235.12886695727708474620@skylake-alporthouse-com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chris, > > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) > > > > I agree, change the functions name from "debugfs_*" to > > "intel_gt_*" prefix. > > An alternate way of looking at it is that these are all dependent on > CONFIG_DEBUGFS. So are they not the debugfs interface? this is a complete matter of taste, I might have a strong opinion if the concept of name prefix was something respected all over i915, but that's not always the case. If Jani feels like enforcing the idea of the function name prefix, I basically agree with the style. With "debugfs_*" I understand all those functions that handle the debugfs as framework. Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx