From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C22EEC35254 for ; Mon, 10 Feb 2020 19:00:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43D9E20870 for ; Mon, 10 Feb 2020 19:00:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="i6r13kPj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43D9E20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9954815E5; Mon, 10 Feb 2020 19:59:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9954815E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581361203; bh=Z8UnRcFcnXaSUOpzqaiZ45krClo+896G1C8hE1A6nfE=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i6r13kPjQrG97Nt0MWq7RO/PsmJL/S6HAfqiap8tqz77dPnQuNa1URDcbOzrOaFY2 aMPNoTFYV2R4MevooqBULm2Spz9r6KrIrgQ/zv584apeepZ90f6NkYMyhjc6dvigFK FuXSoH+eWoGt0nHFFVUXeWWtwaekNgPCctyuylM8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2A163F8014F; Mon, 10 Feb 2020 19:59:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79683F80157; Mon, 10 Feb 2020 19:59:12 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id DFA88F800E7 for ; Mon, 10 Feb 2020 19:59:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DFA88F800E7 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E06941FB; Mon, 10 Feb 2020 10:59:07 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64BA93F68F; Mon, 10 Feb 2020 10:59:07 -0800 (PST) Date: Mon, 10 Feb 2020 18:59:05 +0000 From: Mark Brown To: Brent Lu Message-ID: <20200210185905.GD14166@sirena.org.uk> References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> MIME-Version: 1.0 In-Reply-To: <1581322611-25695-1-git-send-email-brent.lu@intel.com> X-Cookie: No lifeguard on duty. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, Support Opensource , Liam Girdwood , Takashi Iwai , linux-kernel@vger.kernel.org, mac.chiang@intel.com, cychiang@google.com Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0630168081784007376==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============0630168081784007376== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2020 at 04:16:51PM +0800, Brent Lu wrote: > Intel sst firmware turns on BCLK/WCLK in START Ioctl call which timing is > later than the DAPM SUPPLY event handler da7219_dai_event is called (in > PREPARED state). Therefore, the SRM lock check always fail. >=20 > Moving the check to trigger callback could ensure the SRM is locked before > DSP starts to process data and avoid possisble noise. Independently of any other discussion trigger is expected to run very fast so doesn't feel like a good place to do this - given that we're talking about doing this to avoid noise the mute operation seems like a more idiomatic place to do this, it exists to avoid playing back glitches from the digitial interface during startup. --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Bp/kACgkQJNaLcl1U h9AW9ggAhE+Uf05vhaF0QzQQUHbDzslATig+bVtp+hnoVHtcvBpIiJfssALCeBlO 9ax23eqKKLc71AGPWz+0Q/SFXNKtQks8EcCVb3E7DtHCPuME2XweuKpUP3cChyIR PGC0auE4jAhRQYfUCHr/0h1mllN5eVB+CPIkvdlomAXdKVIIHh+RDfcWNzchlBqu iv7Z6JB30FDe21lVXVuVUsDCvRL/bGpq7Puo2gMlxbj/q0ZjHuUzzNxbbAb8qPQu Ck4FI/mgE+qoxGr1LvEmRU8/X9Z0FGRoA8j99UeYftSt338wTsYrMw9Q3vrrAwOJ vbWjkVfV4UqRZbk8c5Bm8D1weiYu/A== =kh32 -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd-- --===============0630168081784007376== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============0630168081784007376==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E09C35254 for ; Mon, 10 Feb 2020 18:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B25402085B for ; Mon, 10 Feb 2020 18:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581361149; bh=zwM11VDZADcIWfLyZG3N7GGJPOMp6VVhjO147xLOoc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sg0SLE6teDDyFOwmMrRSNSTerqr7JRD9yovPEqA4auPRRHHCxN7F5QRSxEuruYvun bSSz+JbaL6zO4b+nJCBaFpKYUz9dubf5B7aUyGPlC/D3Oho+56HoHtr6iXsKIqtL20 zT2kmyz4/ay+wUU9b/FPtMLgD/HNE1GesqA5Bv+g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbgBJS7J (ORCPT ); Mon, 10 Feb 2020 13:59:09 -0500 Received: from foss.arm.com ([217.140.110.172]:37732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727043AbgBJS7I (ORCPT ); Mon, 10 Feb 2020 13:59:08 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E06941FB; Mon, 10 Feb 2020 10:59:07 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64BA93F68F; Mon, 10 Feb 2020 10:59:07 -0800 (PST) Date: Mon, 10 Feb 2020 18:59:05 +0000 From: Mark Brown To: Brent Lu Cc: alsa-devel@alsa-project.org, Support Opensource , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, cychiang@google.com, mac.chiang@intel.com Subject: Re: [PATCH] ASoC: da7219: check SRM lock in trigger callback Message-ID: <20200210185905.GD14166@sirena.org.uk> References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline In-Reply-To: <1581322611-25695-1-git-send-email-brent.lu@intel.com> X-Cookie: No lifeguard on duty. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2020 at 04:16:51PM +0800, Brent Lu wrote: > Intel sst firmware turns on BCLK/WCLK in START Ioctl call which timing is > later than the DAPM SUPPLY event handler da7219_dai_event is called (in > PREPARED state). Therefore, the SRM lock check always fail. >=20 > Moving the check to trigger callback could ensure the SRM is locked before > DSP starts to process data and avoid possisble noise. Independently of any other discussion trigger is expected to run very fast so doesn't feel like a good place to do this - given that we're talking about doing this to avoid noise the mute operation seems like a more idiomatic place to do this, it exists to avoid playing back glitches from the digitial interface during startup. --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Bp/kACgkQJNaLcl1U h9AW9ggAhE+Uf05vhaF0QzQQUHbDzslATig+bVtp+hnoVHtcvBpIiJfssALCeBlO 9ax23eqKKLc71AGPWz+0Q/SFXNKtQks8EcCVb3E7DtHCPuME2XweuKpUP3cChyIR PGC0auE4jAhRQYfUCHr/0h1mllN5eVB+CPIkvdlomAXdKVIIHh+RDfcWNzchlBqu iv7Z6JB30FDe21lVXVuVUsDCvRL/bGpq7Puo2gMlxbj/q0ZjHuUzzNxbbAb8qPQu Ck4FI/mgE+qoxGr1LvEmRU8/X9Z0FGRoA8j99UeYftSt338wTsYrMw9Q3vrrAwOJ vbWjkVfV4UqRZbk8c5Bm8D1weiYu/A== =kh32 -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd--