From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
David Laight <David.Laight@aculab.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: x86: Emulate split-lock access as a write
Date: Mon, 10 Feb 2020 13:59:49 -0800 [thread overview]
Message-ID: <20200210215949.GD2510@linux.intel.com> (raw)
In-Reply-To: <87y2timmto.fsf@vitty.brq.redhat.com>
On Tue, Feb 04, 2020 at 03:47:15PM +0100, Vitaly Kuznetsov wrote:
> Sean Christopherson <sean.j.christopherson@intel.com> writes:
>
> > Exiting to host userspace with "emulation failed" is the other reasonable
> > alternative, but that's basically the same as killing the guest. We're
> > arguing that, in the extremely unlikely event that there is a workload out
> > there that hits this, it's preferable to *maybe* corrupt guest memory and
> > log the anomaly in the kernel log, as opposed to outright killing the guest
> > with a generic "emulation failed".
> >
>
> FWIW, if I was to cast a vote I'd pick 'kill the guest' one way or
> another. "Maybe corrupt guest memory" scares me much more and in many
> cases host and guest are different responsibility domains (think
> 'cloud').
I'm ok with that route as well. What I don't want to do is add a bunch of
logic to inject #AC at this point.
next prev parent reply other threads:[~2020-02-10 21:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 12:19 [PATCH 0/2] kvm: split_lock: Fix emulator and extend #AC handler Xiaoyao Li
2020-01-30 12:19 ` [PATCH 1/2] KVM: x86: Emulate split-lock access as a write Xiaoyao Li
2020-01-30 12:31 ` David Laight
2020-01-30 15:16 ` Andy Lutomirski
2020-01-31 20:01 ` Sean Christopherson
2020-02-04 14:47 ` Vitaly Kuznetsov
2020-02-10 21:59 ` Sean Christopherson [this message]
2020-01-30 12:19 ` [PATCH 2/2] KVM: VMX: Extend VMX's #AC handding Xiaoyao Li
2020-01-30 15:18 ` Andy Lutomirski
2020-01-30 16:29 ` Xiaoyao Li
2020-01-30 17:16 ` Andy Lutomirski
2020-01-31 7:22 ` Xiaoyao Li
2020-01-31 15:37 ` Andy Lutomirski
2020-01-31 17:47 ` Xiaoyao Li
2020-01-31 20:17 ` Sean Christopherson
2020-01-31 20:57 ` Andy Lutomirski
2020-01-31 21:04 ` Sean Christopherson
2020-01-31 21:33 ` Andy Lutomirski
2020-02-01 16:58 ` Xiaoyao Li
2020-02-01 17:56 ` Andy Lutomirski
2020-02-02 4:33 ` Xiaoyao Li
2020-02-03 18:49 ` Andy Lutomirski
2020-02-04 6:03 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210215949.GD2510@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=David.Laight@aculab.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.