From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1Svp-00013Q-4N for linux-um@lists.infradead.org; Tue, 11 Feb 2020 10:38:17 +0000 Received: by mail-qk1-f197.google.com with SMTP id e3so5225665qkf.7 for ; Tue, 11 Feb 2020 02:37:56 -0800 (PST) Date: Tue, 11 Feb 2020 05:37:50 -0500 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Message-ID: <20200211053502-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> MIME-Version: 1.0 In-Reply-To: <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Anton Ivanov Cc: netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org T24gVHVlLCBGZWIgMTEsIDIwMjAgYXQgMDc6NDI6MzdBTSArMDAwMCwgQW50b24gSXZhbm92IHdy b3RlOgo+IE9uIDExLzAyLzIwMjAgMDI6NTEsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiAKPiA+IE9u IDIwMjAvMi8xMSDkuIrljYgxMjo1NSwgQW50b24gSXZhbm92IHdyb3RlOgo+ID4gPiAKPiA+ID4g Cj4gPiA+IE9uIDA5LzEyLzIwMTkgMTA6NDgsIGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5j b20gd3JvdGU6Cj4gPiA+ID4gRnJvbTogQW50b24gSXZhbm92IDxhbnRvbi5pdmFub3ZAY2FtYnJp ZGdlZ3JleXMuY29tPgo+ID4gPiA+IAo+ID4gPiA+IFNvbWUgb2YgdGhlIGZyYW1lcyBtYXJrZWQg YXMgR1NPIHdoaWNoIGFycml2ZSBhdAo+ID4gPiA+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKCkg aGF2ZSBubyBHU09fVFlQRSwgbm8KPiA+ID4gPiBmcmFnbWVudHMgKGRhdGFfbGVuID0gMCkgYW5k IGxlbmd0aCBzaWduaWZpY2FudGx5IHNob3J0ZXIKPiA+ID4gPiB0aGFuIHRoZSBNVFUgKDc1MiBp biBteSBleHBlcmltZW50cykuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBpcyBvYnNlcnZlZCBvbiBy YXcgc29ja2V0cyByZWFkaW5nIG9mZiB2RXRoIGludGVyZmFjZXMKPiA+ID4gPiBpbiBhbGwgNC54 IGFuZCA1Lngga2VybmVscyBJIHRlc3RlZC4KPiA+ID4gPiAKPiA+ID4gPiBUaGVzZSBmcmFtZXMg YXJlIHJlcG9ydGVkIGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+ID4gPiA+IGdz by1sZXNzIGZyYW1lcy4KPiA+ID4gPiAKPiA+ID4gPiBUaGlzIHBhdGNoIG1hcmtzIHRoZSB2bmV0 IGhlYWRlciBhcyBuby1HU08gZm9yIHRoZW0gaW5zdGVhZAo+ID4gPiA+IG9mIHJlcG9ydGluZyBp dCBhcyBpbnZhbGlkLgo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEFudG9uIEl2YW5v diA8YW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiDC oCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysrLS0KPiA+ID4gPiDCoCAxIGZp bGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPiA+IAo+ID4g PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCBiL2luY2x1ZGUvbGlu dXgvdmlydGlvX25ldC5oCj4gPiA+ID4gaW5kZXggMGQxZmU5Mjk3YWM2Li5kOTBkNWNmZjFiOWEg MTAwNjQ0Cj4gPiA+ID4gLS0tIGEvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmgKPiA+ID4gPiAr KysgYi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+ID4gPiA+IEBAIC0xMTIsOCArMTEyLDEy IEBAIHN0YXRpYyBpbmxpbmUgaW50Cj4gPiA+ID4gdmlydGlvX25ldF9oZHJfZnJvbV9za2IoY29u c3Qgc3RydWN0IHNrX2J1ZmYgKnNrYiwKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RDUFY0Owo+ID4gPiA+IMKgwqDC oMKgwqDCoMKgwqDCoCBlbHNlIGlmIChzaW5mby0+Z3NvX3R5cGUgJiBTS0JfR1NPX1RDUFY2KQo+ ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgPSBWSVJUSU9f TkVUX0hEUl9HU09fVENQVjY7Cj4gPiA+ID4gLcKgwqDCoMKgwqDCoMKgIGVsc2UKPiA+ID4gPiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPiA+ID4gPiArwqDCoMKgwqDC oMKgwqAgZWxzZSB7Cj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNrYi0+ZGF0 YV9sZW4gPT0gMCkKPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+ Z3NvX3R5cGUgPSBWSVJUSU9fTkVUX0hEUl9HU09fTk9ORTsKPiA+ID4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBlbHNlCj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gLUVJTlZBTDsKPiA+ID4gPiArwqDCoMKgwqDCoMKgwqAgfQo+ID4gPiA+IMKgwqDCoMKg wqDCoMKgwqDCoCBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19UQ1BfRUNOKQo+ID4gPiA+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgfD0gVklSVElPX05FVF9I RFJfR1NPX0VDTjsKPiA+ID4gPiDCoMKgwqDCoMKgIH0gZWxzZQo+ID4gPiA+IAo+ID4gPiAKPiA+ ID4gcGluZy4KPiA+ID4gCj4gPiAKPiA+IERvIHlvdSBtZWFuIGdzb19zaXplIGlzIHNldCBidXQg Z3NvX3R5cGUgaXMgbm90PyBMb29rcyBsaWtlIGEgYnVnCj4gPiBlbHNld2hlcmUuCj4gPiAKPiA+ IFRoYW5rcwo+ID4gCj4gPiAKPiBZZXMuCj4gCj4gSSBjb3VsZCBub3QgdHJhY2UgaXQgd2hlcmUg aXQgaXMgY29taW5nIGZyb20uCj4gCj4gSSBzZWUgaXQgd2hlbiBkb2luZyByZWN2bW1zZyBvbiBy YXcgc29ja2V0cyBpbiB0aGUgVU1MIHZlY3RvciBuZXR3b3JrCj4gZHJpdmVycy4KPiAKCkkgdGhp bmsgd2UgbmVlZCB0byBmaW5kIHRoZSBjdWxwcml0IGFuZCBmaXggaXQgdGhlcmUsIGxvdHMgb2Yg b3RoZXIgdGhpbmdzCmNhbiBicmVhayBvdGhlcndpc2UuCkp1c3QgcHJpbnRpbmcgb3V0IHNrYi0+ ZGV2LT5uYW1lIHNob3VsZCBkbyB0aGUgdHJpY2ssIG5vPwoKCj4gLS0gCj4gQW50b24gUi4gSXZh bm92Cj4gQ2FtYnJpZGdlZ3JleXMgTGltaXRlZC4gUmVnaXN0ZXJlZCBpbiBFbmdsYW5kLiBDb21w YW55IE51bWJlciAxMDI3MzY2MQo+IGh0dHBzOi8vd3d3LmNhbWJyaWRnZWdyZXlzLmNvbS8KCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC11bSBt YWlsaW5nIGxpc3QKbGludXgtdW1AbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXVtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Date: Tue, 11 Feb 2020 05:37:50 -0500 Message-ID: <20200211053502-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> Sender: netdev-owner@vger.kernel.org To: Anton Ivanov Cc: Jason Wang , netdev@vger.kernel.org, linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Tue, Feb 11, 2020 at 07:42:37AM +0000, Anton Ivanov wrote: > On 11/02/2020 02:51, Jason Wang wrote: > > > > On 2020/2/11 上午12:55, Anton Ivanov wrote: > > > > > > > > > On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: > > > > From: Anton Ivanov > > > > > > > > Some of the frames marked as GSO which arrive at > > > > virtio_net_hdr_from_skb() have no GSO_TYPE, no > > > > fragments (data_len = 0) and length significantly shorter > > > > than the MTU (752 in my experiments). > > > > > > > > This is observed on raw sockets reading off vEth interfaces > > > > in all 4.x and 5.x kernels I tested. > > > > > > > > These frames are reported as invalid while they are in fact > > > > gso-less frames. > > > > > > > > This patch marks the vnet header as no-GSO for them instead > > > > of reporting it as invalid. > > > > > > > > Signed-off-by: Anton Ivanov > > > > --- > > > >   include/linux/virtio_net.h | 8 ++++++-- > > > >   1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > > > > index 0d1fe9297ac6..d90d5cff1b9a 100644 > > > > --- a/include/linux/virtio_net.h > > > > +++ b/include/linux/virtio_net.h > > > > @@ -112,8 +112,12 @@ static inline int > > > > virtio_net_hdr_from_skb(const struct sk_buff *skb, > > > >               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; > > > >           else if (sinfo->gso_type & SKB_GSO_TCPV6) > > > >               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; > > > > -        else > > > > -            return -EINVAL; > > > > +        else { > > > > +            if (skb->data_len == 0) > > > > +                hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; > > > > +            else > > > > +                return -EINVAL; > > > > +        } > > > >           if (sinfo->gso_type & SKB_GSO_TCP_ECN) > > > >               hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > > > >       } else > > > > > > > > > > ping. > > > > > > > Do you mean gso_size is set but gso_type is not? Looks like a bug > > elsewhere. > > > > Thanks > > > > > Yes. > > I could not trace it where it is coming from. > > I see it when doing recvmmsg on raw sockets in the UML vector network > drivers. > I think we need to find the culprit and fix it there, lots of other things can break otherwise. Just printing out skb->dev->name should do the trick, no? > -- > Anton R. Ivanov > Cambridgegreys Limited. Registered in England. Company Number 10273661 > https://www.cambridgegreys.com/