From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0C4C352A3 for ; Tue, 11 Feb 2020 10:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59C34206D7 for ; Tue, 11 Feb 2020 10:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbgBKKjn (ORCPT ); Tue, 11 Feb 2020 05:39:43 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:59725 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728312AbgBKKjm (ORCPT ); Tue, 11 Feb 2020 05:39:42 -0500 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 70D68200005; Tue, 11 Feb 2020 10:39:39 +0000 (UTC) Date: Tue, 11 Feb 2020 11:39:39 +0100 From: Alexandre Belloni To: Michal Simek Cc: Srinivas Neeli , Alessandro Zummo , Srinivas Goud , Shubhrajyoti Datta , linux-rtc@vger.kernel.org, LKML , linux-arm , git Subject: Re: [PATCH] rtc: zynqmp: Clear alarm interrupt status before interrupt enable Message-ID: <20200211103939.GD3527@piout.net> References: <1576155618-7933-1-git-send-email-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 10/02/2020 12:48:14+0100, Michal Simek wrote: > Hi, > > čt 12. 12. 2019 v 14:01 odesílatel Srinivas Neeli > napsal: > > > > Fix multiple occurring interrupts for alarm interrupt. RTC module doesn't > > clear the alarm interrupt status bit immediately after the interrupt is > > triggered.This is due to the sticky nature of the alarm interrupt status > > register. The alarm interrupt status register can be cleared only after > > the second counter outruns the set alarm value. To fix multiple spurious > > interrupts, disable alarm interrupt in the handler and clear the status > > bit before enabling the alarm interrupt. > > > > Fixes: 11143c19eb57 ("rtc: add xilinx zynqmp rtc driver") > > Signed-off-by: Srinivas Neeli > > --- > > drivers/rtc/rtc-zynqmp.c | 29 ++++++++++++++++++++++++----- > > 1 file changed, 24 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c > > index 5786866c09e9..d311e3ef1f21 100644 > > --- a/drivers/rtc/rtc-zynqmp.c > > +++ b/drivers/rtc/rtc-zynqmp.c > > @@ -38,6 +38,8 @@ > > > > #define RTC_CALIB_DEF 0x198233 > > #define RTC_CALIB_MASK 0x1FFFFF > > +#define RTC_ALRM_MASK BIT(1) > > +#define RTC_MSEC 1000 > > > > struct xlnx_rtc_dev { > > struct rtc_device *rtc; > > @@ -124,11 +126,28 @@ static int xlnx_rtc_alarm_irq_enable(struct device *dev, u32 enabled) > > { > > struct xlnx_rtc_dev *xrtcdev = dev_get_drvdata(dev); > > > > here shouldn't be empty line. > > > - if (enabled) > > + unsigned int status; > > + ulong timeout; > > + > > + timeout = jiffies + msecs_to_jiffies(RTC_MSEC); > > + > > + if (enabled) { > > + while (1) { > > + status = readl(xrtcdev->reg_base + RTC_INT_STS); > > + if (!((status & RTC_ALRM_MASK) == RTC_ALRM_MASK)) > > + break; > > + > > + if (time_after_eq(jiffies, timeout)) { > > + dev_err(dev, "Time out occur, while clearing alarm status bit\n"); > > + return -ETIMEDOUT; > > + } > > + writel(RTC_INT_ALRM, xrtcdev->reg_base + RTC_INT_STS); > > + } > > + > > writel(RTC_INT_ALRM, xrtcdev->reg_base + RTC_INT_EN); > > - else > > + } else { > > writel(RTC_INT_ALRM, xrtcdev->reg_base + RTC_INT_DIS); > > - > > + } > > And here it was good to have empty line. > > > return 0; > > } > > > > @@ -183,8 +202,8 @@ static irqreturn_t xlnx_rtc_interrupt(int irq, void *id) > > if (!(status & (RTC_INT_SEC | RTC_INT_ALRM))) > > return IRQ_NONE; > > > > - /* Clear RTC_INT_ALRM interrupt only */ > > - writel(RTC_INT_ALRM, xrtcdev->reg_base + RTC_INT_STS); > > + /* Disable RTC_INT_ALRM interrupt only */ > > + writel(RTC_INT_ALRM, xrtcdev->reg_base + RTC_INT_DIS); > > > > if (status & RTC_INT_ALRM) > > rtc_update_irq(xrtcdev->rtc, 1, RTC_IRQF | RTC_AF); > > -- > > 2.7.4 > > Other then these two above things look good. > > Alexandre: Any issue with this patch? > No issue, I was kind of waiting for your review. I'll take the patch once your comments are addressed. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0ACC352A3 for ; Tue, 11 Feb 2020 10:40:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4AB9206D7 for ; Tue, 11 Feb 2020 10:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d2BEk24U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4AB9206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CCAkTCW5EAp4nB6PPaDolvPK0TNM31cJjteDjAdkhW8=; b=d2BEk24Uo9AJkx OUCsQSVK6sc8Ydq3pXTYzljR3NUi5s3YdaK4lNzPnEH3cO+oeeFPv9tdr7D2zaZky5hZCpgvMH+C1 kTFHO9/znto3VENyN/GSlGsHLWrLeE2FhJqyGsZqwE8OFbT5FawOjd4xZUmfWgfH0K38X6+eZdAz7 Bm+I5g8QF61RIfngu59E2F7ptj16UZKIB50Nfc88ruIyONU92VPdT2GdxPtwOvoXlkcx5oEY4nXpL RSbk3RGHEUexFWKUNnSTDe9RbgOaMhjbNwuLxXc0t713fxNABILH8Lu1xFKEor4F8sZ1Dy9VZg24x 5wQVgXt+Q/573/FZ06Vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1SxQ-0002Aw-53; Tue, 11 Feb 2020 10:39:56 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1SxL-0002AO-QY for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 10:39:54 +0000 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 70D68200005; Tue, 11 Feb 2020 10:39:39 +0000 (UTC) Date: Tue, 11 Feb 2020 11:39:39 +0100 From: Alexandre Belloni To: Michal Simek Subject: Re: [PATCH] rtc: zynqmp: Clear alarm interrupt status before interrupt enable Message-ID: <20200211103939.GD3527@piout.net> References: <1576155618-7933-1-git-send-email-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_023952_131164_5827A3F2 X-CRM114-Status: GOOD ( 19.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Srinivas Neeli , Srinivas Goud , LKML , git , Shubhrajyoti Datta , linux-arm Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTAvMDIvMjAyMCAxMjo0ODoxNCswMTAwLCBNaWNoYWwgU2ltZWsgd3JvdGU6Cj4gSGksCj4g Cj4gxI10IDEyLiAxMi4gMjAxOSB2IDE0OjAxIG9kZXPDrWxhdGVsIFNyaW5pdmFzIE5lZWxpCj4g PHNyaW5pdmFzLm5lZWxpQHhpbGlueC5jb20+IG5hcHNhbDoKPiA+Cj4gPiBGaXggbXVsdGlwbGUg b2NjdXJyaW5nIGludGVycnVwdHMgZm9yIGFsYXJtIGludGVycnVwdC4gUlRDIG1vZHVsZSBkb2Vz bid0Cj4gPiBjbGVhciB0aGUgYWxhcm0gaW50ZXJydXB0IHN0YXR1cyBiaXQgaW1tZWRpYXRlbHkg YWZ0ZXIgdGhlIGludGVycnVwdCBpcwo+ID4gdHJpZ2dlcmVkLlRoaXMgaXMgZHVlIHRvIHRoZSBz dGlja3kgbmF0dXJlIG9mIHRoZSBhbGFybSBpbnRlcnJ1cHQgc3RhdHVzCj4gPiByZWdpc3Rlci4g VGhlIGFsYXJtIGludGVycnVwdCBzdGF0dXMgcmVnaXN0ZXIgY2FuIGJlIGNsZWFyZWQgb25seSBh ZnRlcgo+ID4gdGhlIHNlY29uZCBjb3VudGVyIG91dHJ1bnMgdGhlIHNldCBhbGFybSB2YWx1ZS4g VG8gZml4IG11bHRpcGxlIHNwdXJpb3VzCj4gPiBpbnRlcnJ1cHRzLCBkaXNhYmxlIGFsYXJtIGlu dGVycnVwdCBpbiB0aGUgaGFuZGxlciBhbmQgY2xlYXIgdGhlIHN0YXR1cwo+ID4gYml0IGJlZm9y ZSBlbmFibGluZyB0aGUgYWxhcm0gaW50ZXJydXB0Lgo+ID4KPiA+IEZpeGVzOiAxMTE0M2MxOWVi NTcgKCJydGM6IGFkZCB4aWxpbnggenlucW1wIHJ0YyBkcml2ZXIiKQo+ID4gU2lnbmVkLW9mZi1i eTogU3Jpbml2YXMgTmVlbGkgPHNyaW5pdmFzLm5lZWxpQHhpbGlueC5jb20+Cj4gPiAtLS0KPiA+ ICBkcml2ZXJzL3J0Yy9ydGMtenlucW1wLmMgfCAyOSArKysrKysrKysrKysrKysrKysrKysrKyst LS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3J0Yy9ydGMtenlucW1wLmMgYi9kcml2ZXJz L3J0Yy9ydGMtenlucW1wLmMKPiA+IGluZGV4IDU3ODY4NjZjMDllOS4uZDMxMWUzZWYxZjIxIDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ydGMvcnRjLXp5bnFtcC5jCj4gPiArKysgYi9kcml2ZXJz L3J0Yy9ydGMtenlucW1wLmMKPiA+IEBAIC0zOCw2ICszOCw4IEBACj4gPgo+ID4gICNkZWZpbmUg UlRDX0NBTElCX0RFRiAgICAgICAgICAweDE5ODIzMwo+ID4gICNkZWZpbmUgUlRDX0NBTElCX01B U0sgICAgICAgICAweDFGRkZGRgo+ID4gKyNkZWZpbmUgUlRDX0FMUk1fTUFTSyAgICAgICAgICBC SVQoMSkKPiA+ICsjZGVmaW5lIFJUQ19NU0VDICAgICAgICAgICAgICAgMTAwMAo+ID4KPiA+ICBz dHJ1Y3QgeGxueF9ydGNfZGV2IHsKPiA+ICAgICAgICAgc3RydWN0IHJ0Y19kZXZpY2UgICAgICAg KnJ0YzsKPiA+IEBAIC0xMjQsMTEgKzEyNiwyOCBAQCBzdGF0aWMgaW50IHhsbnhfcnRjX2FsYXJt X2lycV9lbmFibGUoc3RydWN0IGRldmljZSAqZGV2LCB1MzIgZW5hYmxlZCkKPiA+ICB7Cj4gPiAg ICAgICAgIHN0cnVjdCB4bG54X3J0Y19kZXYgKnhydGNkZXYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2 KTsKPiA+Cj4gCj4gaGVyZSBzaG91bGRuJ3QgYmUgZW1wdHkgbGluZS4KPiAKPiA+IC0gICAgICAg aWYgKGVuYWJsZWQpCj4gPiArICAgICAgIHVuc2lnbmVkIGludCBzdGF0dXM7Cj4gPiArICAgICAg IHVsb25nIHRpbWVvdXQ7Cj4gPiArCj4gPiArICAgICAgIHRpbWVvdXQgPSBqaWZmaWVzICsgbXNl Y3NfdG9famlmZmllcyhSVENfTVNFQyk7Cj4gPiArCj4gPiArICAgICAgIGlmIChlbmFibGVkKSB7 Cj4gPiArICAgICAgICAgICAgICAgd2hpbGUgKDEpIHsKPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgIHN0YXR1cyA9IHJlYWRsKHhydGNkZXYtPnJlZ19iYXNlICsgUlRDX0lOVF9TVFMpOwo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgaWYgKCEoKHN0YXR1cyAmIFJUQ19BTFJNX01BU0spID09 IFJUQ19BTFJNX01BU0spKQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVh azsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmICh0aW1lX2FmdGVyX2VxKGpp ZmZpZXMsIHRpbWVvdXQpKSB7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRl dl9lcnIoZGV2LCAiVGltZSBvdXQgb2NjdXIsIHdoaWxlIGNsZWFyaW5nIGFsYXJtIHN0YXR1cyBi aXRcbiIpOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVUSU1F RE9VVDsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIH0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIHdyaXRlbChSVENfSU5UX0FMUk0sIHhydGNkZXYtPnJlZ19iYXNlICsgUlRDX0lOVF9T VFMpOwo+ID4gKyAgICAgICAgICAgICAgIH0KPiA+ICsKPiA+ICAgICAgICAgICAgICAgICB3cml0 ZWwoUlRDX0lOVF9BTFJNLCB4cnRjZGV2LT5yZWdfYmFzZSArIFJUQ19JTlRfRU4pOwo+ID4gLSAg ICAgICBlbHNlCj4gPiArICAgICAgIH0gZWxzZSB7Cj4gPiAgICAgICAgICAgICAgICAgd3JpdGVs KFJUQ19JTlRfQUxSTSwgeHJ0Y2Rldi0+cmVnX2Jhc2UgKyBSVENfSU5UX0RJUyk7Cj4gPiAtCj4g PiArICAgICAgIH0KPiAKPiBBbmQgaGVyZSBpdCB3YXMgZ29vZCB0byBoYXZlIGVtcHR5IGxpbmUu Cj4gCj4gPiAgICAgICAgIHJldHVybiAwOwo+ID4gIH0KPiA+Cj4gPiBAQCAtMTgzLDggKzIwMiw4 IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCB4bG54X3J0Y19pbnRlcnJ1cHQoaW50IGlycSwgdm9pZCAq aWQpCj4gPiAgICAgICAgIGlmICghKHN0YXR1cyAmIChSVENfSU5UX1NFQyB8IFJUQ19JTlRfQUxS TSkpKQo+ID4gICAgICAgICAgICAgICAgIHJldHVybiBJUlFfTk9ORTsKPiA+Cj4gPiAtICAgICAg IC8qIENsZWFyIFJUQ19JTlRfQUxSTSBpbnRlcnJ1cHQgb25seSAqLwo+ID4gLSAgICAgICB3cml0 ZWwoUlRDX0lOVF9BTFJNLCB4cnRjZGV2LT5yZWdfYmFzZSArIFJUQ19JTlRfU1RTKTsKPiA+ICsg ICAgICAgLyogRGlzYWJsZSBSVENfSU5UX0FMUk0gaW50ZXJydXB0IG9ubHkgKi8KPiA+ICsgICAg ICAgd3JpdGVsKFJUQ19JTlRfQUxSTSwgeHJ0Y2Rldi0+cmVnX2Jhc2UgKyBSVENfSU5UX0RJUyk7 Cj4gPgo+ID4gICAgICAgICBpZiAoc3RhdHVzICYgUlRDX0lOVF9BTFJNKQo+ID4gICAgICAgICAg ICAgICAgIHJ0Y191cGRhdGVfaXJxKHhydGNkZXYtPnJ0YywgMSwgUlRDX0lSUUYgfCBSVENfQUYp Owo+ID4gLS0KPiA+IDIuNy40Cj4gCj4gT3RoZXIgdGhlbiB0aGVzZSB0d28gYWJvdmUgdGhpbmdz IGxvb2sgZ29vZC4KPiAKPiBBbGV4YW5kcmU6IEFueSBpc3N1ZSB3aXRoIHRoaXMgcGF0Y2g/Cj4g CgpObyBpc3N1ZSwgSSB3YXMga2luZCBvZiB3YWl0aW5nIGZvciB5b3VyIHJldmlldy4gSSdsbCB0 YWtlIHRoZSBwYXRjaApvbmNlIHlvdXIgY29tbWVudHMgYXJlIGFkZHJlc3NlZC4KCi0tIApBbGV4 YW5kcmUgQmVsbG9uaSwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVy aW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK