Re: [PATCH v15 0/9] VIRTIO-IOMMU device

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Feb 11, 2020 at 03:02:28PM +0000, Peter Maydell wrote:
> On Tue, 11 Feb 2020 at 13:56, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Sat, Feb 08, 2020 at 01:00:13PM +0100, Eric Auger wrote:
> > > This series implements the QEMU virtio-iommu device.
> > >
> > > This matches the v0.12 spec (voted) and the corresponding
> > > virtio-iommu driver upstreamed in 5.3. All kernel dependencies
> > > are resolved for DT integration. The virtio-iommu can be
> > > instantiated in ARM virt using:
> > >
> > > "-device virtio-iommu-pci".
> > >
> > > Non DT mode is not yet supported as it has non resolved kernel
> > > dependencies [1].
> > >
> > > This feature targets 5.0.
> > >
> > > Integration with vhost devices and vfio devices is not part
> > > of this series. Please follow Bharat's respins [2].
> > >
> > > Best Regards
> > >
> > > Eric
> >
> >
> > Looks good.
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > I can see this merged through ARM tree, or through my tree with
> > Peters's ack for the ARM bits.
> 
> Either way would work for me. I left some review comments
> on patch 8 which I think is the only arm-specific one.
> 
> Can you use the virtio-iommu on x86 ? Would you want to?

Potentially yes.

> If I'm not misreading the MAINTAINERS file the new
> files in hw/virtio aren't covered by any existing
> entry there, so we should probably have a new one.
> 
> thanks
> -- PMM