All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: kbuild test robot <lkp@intel.com>
Cc: Alexandru Gagniuc <mr.nuke.me@gmail.com>,
	kbuild-all@lists.01.org, linux-pci@vger.kernel.org,
	Stuart Hayes <stuart.w.hayes@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [pci:pci/hotplug 2/3] drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared; did you mean 'to_ctrl'?
Date: Tue, 11 Feb 2020 08:20:05 -0600	[thread overview]
Message-ID: <20200211142005.GA207907@google.com> (raw)
In-Reply-To: <202002111451.U5ATnnUR%lkp@intel.com>

On Tue, Feb 11, 2020 at 02:04:54PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head:   c4e85e3f147644d222f7d2da21a812f8ff3b7cbc
> commit: 8fe64774eb64d97900d4b0551b6cbedfe4358636 [2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled
> config: sparc64-randconfig-a001-20200211 (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 8fe64774eb64d97900d4b0551b6cbedfe4358636
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=sparc64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/device.h:15:0,
>                     from include/linux/pci.h:37,
>                     from drivers/pci/hotplug/pciehp_hpc.c:21:
>    drivers/pci/hotplug/pciehp_hpc.c: In function 'pcie_wait_for_presence':
> >> drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared (first use in this function); did you mean 'to_ctrl'?
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>                ^
>    include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
>      _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                ^~~
> >> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
>      pci_info(ctrl->pcie->port, format, ## arg)
>      ^~~~~~~~
> >> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>      ^~~~~~~~~
>    drivers/pci/hotplug/pciehp_hpc.c:268:12: note: each undeclared identifier is reported only once for each function it appears in
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>                ^
>    include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
>      _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                ^~~
> >> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
>      pci_info(ctrl->pcie->port, format, ## arg)
>      ^~~~~~~~
> >> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>      ^~~~~~~~~

My fault, fixed.  Sorry, don't know what I was thinking.  Obviously
not much.

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [pci:pci/hotplug 2/3] drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared; did you mean 'to_ctrl'?
Date: Tue, 11 Feb 2020 08:20:05 -0600	[thread overview]
Message-ID: <20200211142005.GA207907@google.com> (raw)
In-Reply-To: <202002111451.U5ATnnUR%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2641 bytes --]

On Tue, Feb 11, 2020 at 02:04:54PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head:   c4e85e3f147644d222f7d2da21a812f8ff3b7cbc
> commit: 8fe64774eb64d97900d4b0551b6cbedfe4358636 [2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled
> config: sparc64-randconfig-a001-20200211 (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 8fe64774eb64d97900d4b0551b6cbedfe4358636
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=sparc64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/device.h:15:0,
>                     from include/linux/pci.h:37,
>                     from drivers/pci/hotplug/pciehp_hpc.c:21:
>    drivers/pci/hotplug/pciehp_hpc.c: In function 'pcie_wait_for_presence':
> >> drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared (first use in this function); did you mean 'to_ctrl'?
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>                ^
>    include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
>      _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                ^~~
> >> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
>      pci_info(ctrl->pcie->port, format, ## arg)
>      ^~~~~~~~
> >> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>      ^~~~~~~~~
>    drivers/pci/hotplug/pciehp_hpc.c:268:12: note: each undeclared identifier is reported only once for each function it appears in
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>                ^
>    include/linux/dev_printk.h:110:12: note: in definition of macro 'dev_info'
>      _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
>                ^~~
> >> drivers/pci/hotplug/pciehp.h:40:2: note: in expansion of macro 'pci_info'
>      pci_info(ctrl->pcie->port, format, ## arg)
>      ^~~~~~~~
> >> drivers/pci/hotplug/pciehp_hpc.c:268:2: note: in expansion of macro 'ctrl_info'
>      ctrl_info(ctrl, "Timeout waiting for Presence Detect\n");
>      ^~~~~~~~~

My fault, fixed.  Sorry, don't know what I was thinking.  Obviously
not much.

  reply	other threads:[~2020-02-11 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  6:04 [pci:pci/hotplug 2/3] drivers/pci/hotplug/pciehp_hpc.c:268:12: error: 'ctrl' undeclared; did you mean 'to_ctrl'? kbuild test robot
2020-02-11  6:04 ` kbuild test robot
2020-02-11 14:20 ` Bjorn Helgaas [this message]
2020-02-11 14:20   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211142005.GA207907@google.com \
    --to=helgaas@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lukas@wunner.de \
    --cc=mr.nuke.me@gmail.com \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.