From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Darren Hart <dvhart@infradead.org>,
Lee Jones <lee.jones@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Zha Qipeng <qipeng.zha@intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 09/18] mfd: intel_soc_pmic: Add SCU IPC member to struct intel_soc_pmic
Date: Tue, 11 Feb 2020 17:57:06 +0200 [thread overview]
Message-ID: <20200211155706.GH10400@smile.fi.intel.com> (raw)
In-Reply-To: <20200211132603.73509-10-mika.westerberg@linux.intel.com>
On Tue, Feb 11, 2020 at 04:25:54PM +0300, Mika Westerberg wrote:
> Both PMIC drivers (intel_soc_pmic_mrfld and intel_soc_pmic_bxtwc) will
> be using this field going forward to access the SCU IPC instance.
>
> While there add kernel-doc for the intel_soc_pmic structure.
> + * @irq_chip_data_pwrbtn: Chained IRQ chip data for the power button
> + * @irq_chip_data_tmu: Chained IRQ chip data for the time management unit
> + * @irq_chip_data_bcu: Chained IRQ chip data for the burst control unit
> + * @irq_chip_data_adc: Chained IRQ chip data for the general purpose ADC
> + * @irq_chip_data_chgr: Chained IRQ chip data for the external charger
> + * @irq_chip_data_crit: Chained IRQ chip data for the critical event handler
Perhaps capitalize the decoded abbreviation, e.g.
general purpose ADC -> General Purpose ADC ?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-11 15:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 13:25 [PATCH v5 00/18] platform/x86: Rework intel_scu_ipc and intel_pmc_ipc drivers Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 01/18] platform/x86: intel_scu_ipc: Split out SCU IPC functionality from the SCU driver Mika Westerberg
2020-02-11 15:39 ` Andy Shevchenko
2020-02-12 11:34 ` Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 02/18] platform/x86: intel_scu_ipc: Log more information if SCU IPC command fails Mika Westerberg
2020-02-11 15:41 ` Andy Shevchenko
2020-02-12 11:36 ` Mika Westerberg
2020-02-12 11:54 ` Andy Shevchenko
2020-02-12 11:57 ` Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 03/18] platform/x86: intel_scu_ipc: Introduce new SCU IPC API Mika Westerberg
2020-02-11 15:48 ` Andy Shevchenko
2020-02-12 11:43 ` Mika Westerberg
2020-02-12 11:55 ` Andy Shevchenko
2020-02-12 12:45 ` Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 04/18] platform/x86: intel_mid_powerbtn: Convert to use " Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 05/18] watchdog: intel-mid_wdt: " Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 06/18] platform/x86: intel_scu_ipcutil: " Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 07/18] platform/x86: intel_scu_ipc: Add managed function to register SCU IPC Mika Westerberg
2020-02-11 15:51 ` Andy Shevchenko
2020-02-12 11:44 ` Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 08/18] platform/x86: intel_pmc_ipc: Start using " Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 09/18] mfd: intel_soc_pmic: Add SCU IPC member to struct intel_soc_pmic Mika Westerberg
2020-02-11 15:57 ` Andy Shevchenko [this message]
2020-02-12 11:44 ` Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 10/18] mfd: intel_soc_pmic_bxtwc: Convert to use new SCU IPC API Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 11/18] mfd: intel_soc_pmic_mrfld: " Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 12/18] platform/x86: intel_telemetry: " Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 13/18] platform/x86: intel_pmc_ipc: Drop intel_pmc_ipc_command() Mika Westerberg
2020-02-11 13:25 ` [PATCH v5 14/18] x86/platform/intel-mid: Add empty stubs for intel_scu_devices_[create|destroy]() Mika Westerberg
2020-02-11 13:26 ` [PATCH v5 15/18] platform/x86: intel_pmc_ipc: Move PCI IDs to intel_scu_pcidrv.c Mika Westerberg
2020-02-11 13:26 ` [PATCH v5 16/18] platform/x86: intel_telemetry: Add telemetry_get_pltdata() Mika Westerberg
2020-02-11 13:26 ` [PATCH v5 17/18] platform/x86: intel_pmc_ipc: Convert to MFD Mika Westerberg
2020-02-11 16:09 ` Andy Shevchenko
2020-02-11 13:26 ` [PATCH v5 18/18] MAINTAINERS: Update entry for Intel Broxton PMC driver Mika Westerberg
2020-02-11 16:01 ` Andy Shevchenko
2020-02-12 11:48 ` Mika Westerberg
2020-02-11 16:10 ` [PATCH v5 00/18] platform/x86: Rework intel_scu_ipc and intel_pmc_ipc drivers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211155706.GH10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=david.e.box@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpa@zytor.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.