From: Matthias Kaehlcke <mka@chromium.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, hemantg@codeaurora.org,
robh+dt@kernel.org, mark.rutland@arm.com,
gubbaven@codeaurora.org
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990
Date: Tue, 11 Feb 2020 09:33:23 -0800 [thread overview]
Message-ID: <20200211173323.GE18972@google.com> (raw)
In-Reply-To: <20200211121612.29075-1-bgodavar@codeaurora.org>
On Tue, Feb 11, 2020 at 05:46:12PM +0530, Balakrishna Godavarthi wrote:
> subject: arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990
Preferably say in the subjct that the node is added for the IDP board.
> Add node for bluetooth soc wcn3990.
>
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 388f50ad4fde..19f82ddc1f09 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -19,6 +19,7 @@
> aliases {
> hsuart0 = &uart3;
> serial0 = &uart8;
> + bluetooth0 = &bluetooth;
> };
>
> chosen {
> @@ -256,6 +257,16 @@
>
> &uart3 {
> status = "okay";
nit: add a blank line
> + bluetooth: wcn3990-bt {
> + compatible = "qcom,wcn3990-bt";
> + vddio-supply = <&vreg_l10a_1p8>;
> + vddxo-supply = <&vreg_l1c_1p8>;
> + vddrf-supply = <&vreg_l2c_1p3>;
> + vddch0-supply = <&vreg_l10c_3p3>;
> + max-speed = <3200000>;
> + clocks = <&rpmhcc RPMH_RF_CLK2>;
> + status = "okay";
status is not needed here AFAIK.
next prev parent reply other threads:[~2020-02-11 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 12:16 [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990 Balakrishna Godavarthi
2020-02-11 17:33 ` Matthias Kaehlcke [this message]
2020-02-12 6:23 ` bgodavar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211173323.GE18972@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bgodavar@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gubbaven@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.