From: Jason Gunthorpe <jgg@ziepe.ca>
To: Shiraz Saleem <shiraz.saleem@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 rdma-next] i40iw: Do an RCU lookup in i40iw_add_ipv4_addr
Date: Tue, 11 Feb 2020 14:32:06 -0400 [thread overview]
Message-ID: <20200211183206.GA14213@ziepe.ca> (raw)
In-Reply-To: <20200204223840.2151-1-shiraz.saleem@intel.com>
On Tue, Feb 04, 2020 at 04:38:40PM -0600, Shiraz Saleem wrote:
> The in_dev_for_each_ifa_rtnl iterator in i40iw_add_ipv4_addr
> requires that the rtnl lock be held. But the rtnl_trylock/unlock
> scheme in this function does not guarantee it.
>
> Replace the rtnl locking with an RCU lookup.
>
> Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> v0-->v1:
> Annotate dev->flags with READ_ONCE
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-02-11 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 22:38 [PATCH v1 rdma-next] i40iw: Do an RCU lookup in i40iw_add_ipv4_addr Shiraz Saleem
2020-02-11 18:32 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211183206.GA14213@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.