From: Patrick Steinhardt <ps@pks.im>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
gmazyland@gmail.com, leif@nuviainc.com, agraf@csgraf.de,
pjones@redhat.com, mjg59@google.com, phcoder@gmail.com
Subject: Re: [PATCH 0/5] Support Argon2 KDF in LUKS2
Date: Wed, 12 Feb 2020 08:47:49 +0100 [thread overview]
Message-ID: <20200212074749.GA4330@ncase> (raw)
In-Reply-To: <20200211215359.m7dpfsq45zssqvtq@tomti.i.net-space.pl>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
On Tue, Feb 11, 2020 at 10:53:59PM +0100, Daniel Kiper wrote:
> > GRUB's codebase. This included both stripping off unneeded
> > functionality as well as converting the code to use our own coding
>
> Stripping unneeded functionality is OK. However, I think that it does
> not make sense to convert coding style to the GRUB one. Especially if we
> do not do that for other modules. So, I would leave coding style in
> Argon2 module as is and save your precious minutes for something more
> productive... ;-)
Fair enough, I'll send out a v2 with the original coding style. I
thought as much when I was ready with v1, but was too lazy to do the
work and change back the coding style.
Anyway, to save myself another roundtrip: would you prefer to merge
Argon2 functionality into a single file like I've done it right now or
to retain the original set of files? The reason why I've opted for the
latter is mainly to be able to annotate more functions as static.
> > style. While it makes importing upstream fixes harder, I'd argue
> > the code is still very similar in its structure and thus
> > backporting should be easy enough.
> >
> > Anyway. With these changes I'm able to successfully decrypt LUKS2
> > partitions making use of either PBKDF2, Argon2i or Argon2id.
>
> I will take deeper dive into the code if we hammer out things listed above.
Cool, thanks!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-12 7:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 14:27 [PATCH 0/5] Support Argon2 KDF in LUKS2 Patrick Steinhardt
2020-02-06 14:27 ` [PATCH 1/5] efi: Allocate half of available memory by default Patrick Steinhardt
2020-02-13 11:47 ` Leif Lindholm
2020-02-20 19:29 ` Patrick Steinhardt
2020-02-06 14:27 ` [PATCH 2/5] argon2: Import Argon2 from cryptsetup Patrick Steinhardt
2020-02-08 11:30 ` Milan Broz
2020-02-08 22:25 ` Patrick Steinhardt
2020-02-06 14:27 ` [PATCH 3/5] disk: luks2: Add missing newline to debug message Patrick Steinhardt
2020-02-11 21:36 ` Daniel Kiper
2020-02-12 7:48 ` Patrick Steinhardt
2020-02-06 14:27 ` [PATCH 4/5] disk: luks2: Discern Argon2i and Argon2id Patrick Steinhardt
2020-02-06 14:27 ` [PATCH 5/5] disk: luks2: Support key derival via Argon2 Patrick Steinhardt
2020-02-11 21:53 ` [PATCH 0/5] Support Argon2 KDF in LUKS2 Daniel Kiper
2020-02-12 7:18 ` Milan Broz
2020-02-20 19:34 ` Patrick Steinhardt
2020-02-12 7:47 ` Patrick Steinhardt [this message]
2020-02-13 11:42 ` Daniel Kiper
2020-02-20 14:50 ` Patrick Steinhardt
2020-02-20 18:00 ` [PATCH v2 0/6] " Patrick Steinhardt
2020-02-20 18:00 ` [PATCH v2 1/6] efi: Allocate half of available memory by default Patrick Steinhardt
2020-02-20 18:00 ` [PATCH v2 2/6] types.h: add UINT-related macros needed for Argon2 Patrick Steinhardt
2020-02-21 12:34 ` Daniel Kiper
2020-02-20 18:00 ` [PATCH v2 3/6] argon2: Import Argon2 from cryptsetup Patrick Steinhardt
2020-02-21 12:39 ` Daniel Kiper
2020-02-20 18:00 ` [PATCH v2 4/6] luks2: Add missing newline to debug message Patrick Steinhardt
2020-02-20 18:00 ` [PATCH v2 5/6] luks2: Discern Argon2i and Argon2id Patrick Steinhardt
2020-02-21 12:54 ` Daniel Kiper
2020-02-20 18:00 ` [PATCH v2 6/6] luks2: Support key derival via Argon2 Patrick Steinhardt
2020-02-21 13:03 ` Daniel Kiper
2020-02-20 18:38 ` [PATCH v2 0/6] Support Argon2 KDF in LUKS2 Leif Lindholm
2020-02-21 12:26 ` Daniel Kiper
2020-02-21 14:29 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212074749.GA4330@ncase \
--to=ps@pks.im \
--cc=agraf@csgraf.de \
--cc=daniel.kiper@oracle.com \
--cc=dkiper@net-space.pl \
--cc=gmazyland@gmail.com \
--cc=grub-devel@gnu.org \
--cc=leif@nuviainc.com \
--cc=mjg59@google.com \
--cc=phcoder@gmail.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.