From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E78C2BA83 for ; Wed, 12 Feb 2020 12:00:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D54872073C for ; Wed, 12 Feb 2020 12:00:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Kg5oJb7l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D54872073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0AEDA166C; Wed, 12 Feb 2020 12:59:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0AEDA166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581508814; bh=RAyZV8KoW2D3+EZHbiUvfzB0t3HfKUUg43f1+HN9vuY=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Kg5oJb7lgALYhsur/QhV5BIOMAO3HCqJaDY+ydfQ9QEdDlP95HKbLRagp9Cxne3Nd 4UOH9Cn9bwsK0fTzuUm/nAl2ORuSBug87UqtDQgNdCVFKApdLk73s9mNCOSgfx4+A7 p5tsMXKPBg/1zcI37zfkxHZky274Th2h3LvTnl+s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8DB01F8014F; Wed, 12 Feb 2020 12:59:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B55FF80157; Wed, 12 Feb 2020 12:59:22 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id E92A8F800E7 for ; Wed, 12 Feb 2020 12:59:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E92A8F800E7 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B358A30E; Wed, 12 Feb 2020 03:59:17 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37AB13F6CF; Wed, 12 Feb 2020 03:59:17 -0800 (PST) Date: Wed, 12 Feb 2020 11:59:15 +0000 From: Mark Brown To: Adam Thomson Message-ID: <20200212115915.GC4028@sirena.org.uk> References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> <855c88fb-4438-aefb-ac9b-a9a5a2dc8caa@linux.intel.com> <2eeca7fe-aec9-c680-5d61-930de18b952b@linux.intel.com> MIME-Version: 1.0 In-Reply-To: X-Cookie: Violence is molding. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Pierre-Louis Bossart , "alsa-devel@alsa-project.org" , Support Opensource , "linux-kernel@vger.kernel.org" , "Sridharan, Ranjani" , Liam Girdwood , Takashi Iwai , "Chiang, Mac" , Ranjani Sridharan , "Lu, Brent" , "cychiang@google.com" Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4443036295175269361==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============4443036295175269361== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5QAgd0e35j3NYeGe" Content-Disposition: inline --5QAgd0e35j3NYeGe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 12, 2020 at 10:16:54AM +0000, Adam Thomson wrote: > So far I've not found a way in the codec driver to be able to get around this. > I spent a very long time with Sathya in the early days (Apollo Lake) looking at > options but nothing would fit which is why I have the solution that's in place > right now. We could probably reduce the number of rechecks before timeout in the > driver but that's really just papering over the crack and there's still the > possibility of noise later when SRM finally does lock. This really needs the componentisation refactoring I think, that way we can annotate individual devices and links with what they need rather than essentially guessing about what works most of the time which is more or less what we do at the minute. Like you say as things are at the minute there's a lot of crack papering going on. --5QAgd0e35j3NYeGe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5D6JMACgkQJNaLcl1U h9DlEAf/fBK6srxM34hrUWp+RSB46rzwi3VulG9ye6DrZYE18FThapihpLCSCPw5 UUFuOf2G/w+8hcwf22J0gh7LZky8ReBsMWiFahKijYInxiEB6ioRdgKj6o+XoSR3 K5f7JP8QGkbkclgTpjytuIFWw6C32pGyojS2pL82ZUbbhRXPik9NWAp+UOXTWp4Y 7nAT+kvot9ixAECLYwT3mhXYRtouMUU1jXD9nlDMoViI5AC5+OKfItlBpL/Pu1+k 5a8bFXfRuhRqXN0zubbL7gfS81FyYS1PLZ2dWFWR9hEFSHJrblGW5dFLQw1hiie/ 1U75ZlU+4ns6rHFlV8jHNTRK3XUH+w== =V8px -----END PGP SIGNATURE----- --5QAgd0e35j3NYeGe-- --===============4443036295175269361== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============4443036295175269361==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F16FC2BA83 for ; Wed, 12 Feb 2020 11:59:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3244D2073C for ; Wed, 12 Feb 2020 11:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581508759; bh=IVTsnwcPvRGMFvND6nmMakxl63Cdn8QdhLHDV3yh2Po=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ycwOK+S1bBBMk1/t2cyxvCK76NMHfWV/QI8zaMR/0wjrCnVpmCy709FRn+fRxzpCF KMxn8RikdLjFw7P+W8ROGuirMa4U7hO1Dx8iSlO874dNcdzKn7E7KYD9pBABYK3Y/w TIVAL/GhnUZ9DFT+OYVKRul/LJob9Jpr/JdHYMgA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728328AbgBLL7S (ORCPT ); Wed, 12 Feb 2020 06:59:18 -0500 Received: from foss.arm.com ([217.140.110.172]:60078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgBLL7S (ORCPT ); Wed, 12 Feb 2020 06:59:18 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B358A30E; Wed, 12 Feb 2020 03:59:17 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37AB13F6CF; Wed, 12 Feb 2020 03:59:17 -0800 (PST) Date: Wed, 12 Feb 2020 11:59:15 +0000 From: Mark Brown To: Adam Thomson Cc: Pierre-Louis Bossart , "Sridharan, Ranjani" , "alsa-devel@alsa-project.org" , Support Opensource , Takashi Iwai , Liam Girdwood , "linux-kernel@vger.kernel.org" , "Chiang, Mac" , Ranjani Sridharan , "Lu, Brent" , "cychiang@google.com" Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback Message-ID: <20200212115915.GC4028@sirena.org.uk> References: <1581322611-25695-1-git-send-email-brent.lu@intel.com> <855c88fb-4438-aefb-ac9b-a9a5a2dc8caa@linux.intel.com> <2eeca7fe-aec9-c680-5d61-930de18b952b@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5QAgd0e35j3NYeGe" Content-Disposition: inline In-Reply-To: X-Cookie: Violence is molding. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5QAgd0e35j3NYeGe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 12, 2020 at 10:16:54AM +0000, Adam Thomson wrote: > So far I've not found a way in the codec driver to be able to get around this. > I spent a very long time with Sathya in the early days (Apollo Lake) looking at > options but nothing would fit which is why I have the solution that's in place > right now. We could probably reduce the number of rechecks before timeout in the > driver but that's really just papering over the crack and there's still the > possibility of noise later when SRM finally does lock. This really needs the componentisation refactoring I think, that way we can annotate individual devices and links with what they need rather than essentially guessing about what works most of the time which is more or less what we do at the minute. Like you say as things are at the minute there's a lot of crack papering going on. --5QAgd0e35j3NYeGe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5D6JMACgkQJNaLcl1U h9DlEAf/fBK6srxM34hrUWp+RSB46rzwi3VulG9ye6DrZYE18FThapihpLCSCPw5 UUFuOf2G/w+8hcwf22J0gh7LZky8ReBsMWiFahKijYInxiEB6ioRdgKj6o+XoSR3 K5f7JP8QGkbkclgTpjytuIFWw6C32pGyojS2pL82ZUbbhRXPik9NWAp+UOXTWp4Y 7nAT+kvot9ixAECLYwT3mhXYRtouMUU1jXD9nlDMoViI5AC5+OKfItlBpL/Pu1+k 5a8bFXfRuhRqXN0zubbL7gfS81FyYS1PLZ2dWFWR9hEFSHJrblGW5dFLQw1hiie/ 1U75ZlU+4ns6rHFlV8jHNTRK3XUH+w== =V8px -----END PGP SIGNATURE----- --5QAgd0e35j3NYeGe--