From: Jean Delvare <jdelvare@suse.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, Tom Abraham <tabraham@suse.com>
Subject: Re: wdat_wdt: access width inconsistency
Date: Wed, 12 Feb 2020 12:05:45 +0100 [thread overview]
Message-ID: <20200212120545.56e8ec42@endymion> (raw)
In-Reply-To: <20200212104747.GR2667@lahna.fi.intel.com>
On Wed, 12 Feb 2020 12:47:47 +0200, Mika Westerberg wrote:
> On Wed, Feb 12, 2020 at 11:30:30AM +0100, Jean Delvare wrote:
> > (The underlying question being: can I get rid of that ALIGN()
> > altogether while fixing the gas->access_width misuse bug?)
>
> I think the ALIGN() was there just because I did not realize that
> access_width is 3 and not 4 for 32-bit memory. So it is not needed.
>
> I actually have a patch series that should fix this and the other issue
> you found (I found a couple of spare cycles in the morning) so if you
> don't mind I'll submit them soon.
Sure please do, I don't care about ownership, I only want these bugs to
be fixed. I got myself side-tracked by another issue at work this
morning.
I'll be happy to review your changes.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-02-12 11:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:16 wdat_wdt: access width inconsistency Jean Delvare
2020-02-10 11:23 ` Mika Westerberg
2020-02-11 13:11 ` Jean Delvare
2020-02-11 13:59 ` Mika Westerberg
2020-02-11 16:25 ` Jean Delvare
2020-02-11 16:37 ` Mika Westerberg
2020-02-11 17:03 ` Jean Delvare
2020-02-12 11:05 ` [PATCH 1/3] ACPICA: Introduce ACPI_ACCESS_BIT_WIDTH() macro Mika Westerberg
2020-02-12 11:05 ` [PATCH 2/3] ACPI / watchdog: Fix gas->access_width usage Mika Westerberg
2020-02-12 11:56 ` Jean Delvare
2020-02-12 12:10 ` Mika Westerberg
2020-02-12 11:05 ` [PATCH 3/3] ACPI / watchdog: Set default timeout in probe Mika Westerberg
2020-02-12 12:07 ` Jean Delvare
2020-02-12 12:13 ` Mika Westerberg
2020-02-12 11:52 ` [PATCH 1/3] ACPICA: Introduce ACPI_ACCESS_BIT_WIDTH() macro Jean Delvare
2020-02-12 12:08 ` Mika Westerberg
2020-02-11 16:45 ` wdat_wdt: access width inconsistency Guenter Roeck
2020-02-12 10:30 ` Jean Delvare
2020-02-12 10:47 ` Mika Westerberg
2020-02-12 11:05 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212120545.56e8ec42@endymion \
--to=jdelvare@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tabraham@suse.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.